All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jidong Xiao <jidong.xiao@gmail.com>
To: qemu-devel@nongnu.org, KVM <kvm@vger.kernel.org>
Subject: [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000
Date: Tue, 3 Jun 2014 21:10:06 -0400	[thread overview]
Message-ID: <CAG4AFWajxKx_VWMLGMzto19Tfk6XwtGpLa9H=bRGbug+3O6mBA@mail.gmail.com> (raw)

Hi,

Since Linux kernel 3.5, KVM has set eax to KVM_CPUID_FEATURES, for
leaf 0x40000000, see this:

https://github.com/torvalds/linux/commit/57c22e5f35aa4b9b2fe11f73f3e62bbf9ef36190

But qemu still tries to set it to 0. It would be better to make qemu
and kvm consistent. This patch just fixes this issue.

Signed-off-by: Jidong Xiao <jidong.xiao@gmail.com>
---
diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c
index 4389959..b8b282d 100644
--- a/qemu-2.0.0/target-i386/kvm.c.orig
+++ b/qemu-2.0.0/target-i386/kvm.c
@@ -530,7 +530,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
     memcpy(signature, "KVMKVMKVM\0\0\0", 12);
     c = &cpuid_data.entries[cpuid_i++];
     c->function = KVM_CPUID_SIGNATURE | kvm_base;
-    c->eax = 0;
+   c->eax = KVM_CPUID_FEATURES;
     c->ebx = signature[0];
     c->ecx = signature[1];
     c->edx = signature[2];

WARNING: multiple messages have this Message-ID (diff)
From: Jidong Xiao <jidong.xiao@gmail.com>
To: qemu-devel@nongnu.org, KVM <kvm@vger.kernel.org>
Subject: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000
Date: Tue, 3 Jun 2014 21:10:06 -0400	[thread overview]
Message-ID: <CAG4AFWajxKx_VWMLGMzto19Tfk6XwtGpLa9H=bRGbug+3O6mBA@mail.gmail.com> (raw)

Hi,

Since Linux kernel 3.5, KVM has set eax to KVM_CPUID_FEATURES, for
leaf 0x40000000, see this:

https://github.com/torvalds/linux/commit/57c22e5f35aa4b9b2fe11f73f3e62bbf9ef36190

But qemu still tries to set it to 0. It would be better to make qemu
and kvm consistent. This patch just fixes this issue.

Signed-off-by: Jidong Xiao <jidong.xiao@gmail.com>
---
diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c
index 4389959..b8b282d 100644
--- a/qemu-2.0.0/target-i386/kvm.c.orig
+++ b/qemu-2.0.0/target-i386/kvm.c
@@ -530,7 +530,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
     memcpy(signature, "KVMKVMKVM\0\0\0", 12);
     c = &cpuid_data.entries[cpuid_i++];
     c->function = KVM_CPUID_SIGNATURE | kvm_base;
-    c->eax = 0;
+   c->eax = KVM_CPUID_FEATURES;
     c->ebx = signature[0];
     c->ecx = signature[1];
     c->edx = signature[2];

             reply	other threads:[~2014-06-04  1:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  1:10 Jidong Xiao [this message]
2014-06-04  1:10 ` [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000 Jidong Xiao
2014-06-04  7:09 ` Paolo Bonzini
2014-06-04  7:09   ` [Qemu-devel] " Paolo Bonzini
2014-06-04  7:17   ` Jidong Xiao
2014-06-04  7:17     ` [Qemu-devel] " Jidong Xiao
2014-06-04 19:08     ` Bandan Das
2014-06-04 19:47       ` Jidong Xiao
2014-06-04 19:47         ` [Qemu-devel] " Jidong Xiao
2014-06-04 21:26         ` Bandan Das
2014-08-12 18:55     ` Eduardo Habkost
2014-08-12 19:12       ` Paolo Bonzini
2014-08-12 19:29         ` Eduardo Habkost
2014-08-13 12:18           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG4AFWajxKx_VWMLGMzto19Tfk6XwtGpLa9H=bRGbug+3O6mBA@mail.gmail.com' \
    --to=jidong.xiao@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.