All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Wendling <morbo@google.com>
To: kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier
Date: Mon, 9 Sep 2019 14:28:22 -0700	[thread overview]
Message-ID: <CAGG=3QV-0hPrWx8dFptjqbKMNfne+iTfq2e-KL89ebecO8Ta1w@mail.gmail.com> (raw)

The extended assembly documentation list only "q" as an operand modifier
for DImode registers. The "d" seems to be an AMD-ism, which appears to
be only begrudgingly supported by gcc.

Signed-off-by: Bill Wendling <morbo@google.com>
---
 x86/emulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x86/emulator.c b/x86/emulator.c
index b132b90..621caf9 100644
--- a/x86/emulator.c
+++ b/x86/emulator.c
@@ -799,7 +799,7 @@ static void test_smsw_reg(uint64_t *mem)
  asm(KVM_FEP "smswl %k0\n\t" : "=a" (rax) : "0" (in_rax));
  report("32-bit smsw reg", rax == (u32)cr0);

- asm(KVM_FEP "smswq %d0\n\t" : "=a" (rax) : "0" (in_rax));
+ asm(KVM_FEP "smswq %q0\n\t" : "=a" (rax) : "0" (in_rax));
  report("64-bit smsw reg", rax == cr0);
 }

             reply	other threads:[~2019-09-09 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 21:28 Bill Wendling [this message]
2019-09-10 16:44 ` [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier Jim Mattson
2019-09-11 19:11 ` Sean Christopherson
     [not found]   ` <CAGG=3QXbCriXR+FER2ex9nN_aHENRgDvJNQ_HDCFniPP0NJNpg@mail.gmail.com>
2019-09-24 19:35     ` Bill Wendling
2019-09-25 13:44 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGG=3QV-0hPrWx8dFptjqbKMNfne+iTfq2e-KL89ebecO8Ta1w@mail.gmail.com' \
    --to=morbo@google.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.