All of lore.kernel.org
 help / color / mirror / Atom feed
From: Negreanu Marius <groleo@gmail.com>
To: "Tapani Pälli" <tapani.palli@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] Android support
Date: Fri, 12 Oct 2012 21:45:57 +0300	[thread overview]
Message-ID: <CAGV5d_06rVvbeV6g-0A0VuzuRErLW2GA2U=SeaLxJ5nRYsh9eQ@mail.gmail.com> (raw)
In-Reply-To: <507693E0.5050704@intel.com>

On Thu, Oct 11, 2012 at 12:39 PM, Tapani Pälli <tapani.palli@intel.com> wrote:
> On 10/10/2012 08:05 PM, Chad Versace wrote:
>> On 10/07/2012 10:50 PM, Tapani Pälli wrote:
>>> Upstreaming old set of patches here to enable Android support in libdrm.
>>> Some little rebasing was required for the first one.
>>>
>>> Chad Versace (2):
>>>   libdrm,intel: Factor source file lists into sources.mk
>>>   libdrm,intel: Add Android makefiles (v2)
>>>
>>> Haitao Huang (1):
>>>   Android.mk: use LOCAL_COPY_HEADERS to export headers.
>>>
>>>  Android.mk        | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  Makefile.am       |  9 ++++----
>>>  intel/Android.mk  | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  intel/Makefile.am |  9 ++++----
>>>  intel/sources.mk  | 30 +++++++++++++++++++++++++++
>>>  sources.mk        | 30 +++++++++++++++++++++++++++
>>
>> This series looks good to me. Before committing, though, I'd like to see either
>> an Acked-by or an "Sure, whatever" from one of the regular libdrm_intel committers.
>
> Thanks for checking it out. I've tried out androgenizer as Eric
> suggested but not really convinced we would like to start using it.

To bring an pro-argument for Tapani, this is how it looks to make it
work with androgenizer.
As you can see, it's not much different from the Android.mk itself,
only the variable names changes.


diff --git a/Makefile.am b/Makefile.am
index 273abf9..b200509 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -77,3 +77,23 @@ copy-headers :
 commit-headers : copy-headers
        git add include
        git commit -am "Copy headers from kernel $$(GIT_DIR=$(kernel_source)/.gi
+
+Android.mk: Makefile.am
+               androgenizer \
+               -:PROJECT testlib \
+               -:REL_TOP $(top_srcdir) \
+               -:ABS_TOP $(abs_top_srcdir) \
+               -:SHARED libdrm \
+               -:SOURCES $(LIBDRM_SOURCES) \
+               -:LDFLAGS $(libdrm_la_LDFLAGS) \
+               -:CPPFLAGS $(libdrm_la_CPPFLAGS) \
+               -:TAGS optional\
+               -:HEADERS xf86drm.h          \
+                       include/drm/drm_fourcc.h \
+                       include/drm/drm.h        \
+                       include/drm/drm_mode.h   \
+                       include/drm/drm_sarea.h  \
+                       include/drm/i915_drm.h   \
+                       intel/intel_bufmgr.h     \
+               -:HEADER_TARGET libdrm \
+               > $@


-- 
Regards!
http://groleo.wordpress.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2012-10-12 18:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08  5:50 [PATCH 0/3] Android support Tapani Pälli
2012-10-08  5:50 ` [PATCH 1/3] libdrm,intel: Factor source file lists into sources.mk Tapani Pälli
2012-10-08 11:38   ` Oliver McFadden
2012-10-08  5:50 ` [PATCH 2/3] libdrm,intel: Add Android makefiles (v2) Tapani Pälli
2012-10-08 11:40   ` Oliver McFadden
2012-10-08  5:50 ` [PATCH 3/3] Android.mk: use LOCAL_COPY_HEADERS to export headers Tapani Pälli
2012-10-08 11:37   ` Oliver McFadden
2012-10-08 15:37 ` [PATCH 0/3] Android support Eric Anholt
2012-10-09  6:14   ` Tapani Pälli
2012-10-10 17:05 ` Chad Versace
2012-10-11  9:39   ` Tapani Pälli
2012-10-12 18:45     ` Negreanu Marius [this message]
2012-10-12 22:27       ` Eric Anholt
2012-10-14 16:39         ` Pekka Paalanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGV5d_06rVvbeV6g-0A0VuzuRErLW2GA2U=SeaLxJ5nRYsh9eQ@mail.gmail.com' \
    --to=groleo@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tapani.palli@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.