From: Steve French <smfrench@gmail.com>
To: Paulo Alcantara <pc@cjr.nz>, CIFS <linux-cifs@vger.kernel.org>
Subject: patch to removing minor DFS compile warnings
Date: Wed, 10 Nov 2021 03:14:24 -0600 [thread overview]
Message-ID: <CAH2r5mtcGWchWxk8S7MCJa6zsuJZy6bxuwX7SeGm5K7MTT59cw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
CHECK /home/smfrench/cifs-2.6/fs/cifs/connect.c
/home/smfrench/cifs-2.6/fs/cifs/connect.c:4137:5: warning: symbol
'__tree_connect_dfs_target' was not declared. Should it be static?
/home/smfrench/cifs-2.6/fs/cifs/connect.c:4236:5: warning: symbol
'tree_connect_dfs_target' was not declared. Should it be static?
--
Thanks,
Steve
[-- Attachment #2: 0001-smb3-remove-trivial-dfs-compile-warning.patch --]
[-- Type: text/x-patch, Size: 1476 bytes --]
From c14a9424dc360a9125cb4e7558bafe9426bc05f1 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Wed, 10 Nov 2021 03:09:52 -0600
Subject: [PATCH] smb3: remove trivial dfs compile warning
Fix warning caused by recent changes to the dfs code:
symbol 'tree_connect_dfs_target' was not declared. Should it be static?
Cc: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
fs/cifs/connect.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index c07d5915b9b0..f645f994a523 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4134,7 +4134,7 @@ static int target_share_matches_server(struct TCP_Server_Info *server, const cha
return rc;
}
-int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
+static int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
struct cifs_sb_info *cifs_sb, char *tree,
struct dfs_cache_tgt_list *tl, struct dfs_info3_param *ref)
{
@@ -4233,7 +4233,7 @@ int __tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
return rc;
}
-int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
+static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tcon,
struct cifs_sb_info *cifs_sb, char *tree,
struct dfs_cache_tgt_list *tl, struct dfs_info3_param *ref)
{
--
2.32.0
next reply other threads:[~2021-11-10 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 9:14 Steve French [this message]
2021-11-10 10:18 ` patch to removing minor DFS compile warnings Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mtcGWchWxk8S7MCJa6zsuJZy6bxuwX7SeGm5K7MTT59cw@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.