Re: [PATCH] drivers/acpi/apei: remove redundant rc variable

From: "Rafael J. Wysocki" <rafael@kernel.org>
To: cgel.zte@gmail.com
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
	Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Minghao Chi <chi.minghao@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers/acpi/apei: remove redundant rc variable
Date: Wed, 12 Jan 2022 17:34:02 +0100	[thread overview]
Message-ID: <CAJZ5v0iipOm6DX3Fd8iNKF_LC6kJWCy=1LxFsh47z01UYDrRow@mail.gmail.com> (raw)
In-Reply-To: <20220112080155.666868-1-chi.minghao@zte.com.cn>

On Wed, Jan 12, 2022 at 9:02 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from apei_exec_write_register() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>

Well, this doesn't look like an e-mail address of a physical person
which is required for S-o-b tags.

> ---
>  drivers/acpi/apei/apei-base.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
> index c7fdb12c3310..87145b6b89aa 100644
> --- a/drivers/acpi/apei/apei-base.c
> +++ b/drivers/acpi/apei/apei-base.c
> @@ -125,12 +125,9 @@ EXPORT_SYMBOL_GPL(apei_exec_write_register);
>  int apei_exec_write_register_value(struct apei_exec_context *ctx,
>                                    struct acpi_whea_header *entry)
>  {
> -       int rc;
> -
>         ctx->value = entry->value;
> -       rc = apei_exec_write_register(ctx, entry);
> +       return apei_exec_write_register(ctx, entry);
>
> -       return rc;
>  }
>  EXPORT_SYMBOL_GPL(apei_exec_write_register_value);
>
> --
> 2.25.1
>