From: Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
"linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] [CIFS] Fix signed/unsigned pointer warning
Date: Sun, 14 Dec 2014 16:54:12 -0800 [thread overview]
Message-ID: <CAJiQ=7B5L=ZrJYSCuUDkG+qtUOUHueAwsWut4KyBTsj0xE+q5w@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mucwo_FH4M=UUoLNDZNRFFcG9hd=Gxc7ma5jwkJQ2-qTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Sun, Dec 14, 2014 at 4:28 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Sat, Dec 13, 2014 at 11:29 PM, Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Sat, Dec 13, 2014 at 9:20 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> Probably harmless patch - but I didn't notice the warning on x86
>>> kernel build (building on Fedora 21, gcc 4.9.2)
>>
>> Did you test x86 32-bit or 64-bit? In the generic do_div()
>
> I built current mainline with 64 bit disabled. No warnings on this
> before or after the patch.
Ah, right, it only shows up on 32-bit architectures that use the
generic do_div implementation. To see the warning on x86, you'd need
to do something like this:
$ git --no-pager diff
diff --git a/arch/x86/include/asm/div64.h b/arch/x86/include/asm/div64.h
index ced283a..f693002 100644
--- a/arch/x86/include/asm/div64.h
+++ b/arch/x86/include/asm/div64.h
@@ -1,7 +1,7 @@
#ifndef _ASM_X86_DIV64_H
#define _ASM_X86_DIV64_H
-#ifdef CONFIG_X86_32
+#if 0//def CONFIG_X86_32
#include <linux/types.h>
#include <linux/log2.h>
$ touch fs/cifs/netmisc.c
$ make ARCH=x86 vmlinux
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CC fs/cifs/netmisc.o
fs/cifs/netmisc.c: In function ‘cifs_NTtimeToUnix’:
fs/cifs/netmisc.c:937:23: warning: comparison of distinct pointer
types lacks a cast [enabled by default]
fs/cifs/netmisc.c:941:22: warning: comparison of distinct pointer
types lacks a cast [enabled by default]
LD fs/cifs/cifs.o
LD fs/cifs/built-in.o
LD fs/built-in.o
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
KSYM .tmp_kallsyms1.o
KSYM .tmp_kallsyms2.o
LD vmlinux
SORTEX vmlinux
SYSMAP System.map
$
> merged into cifs-2.6.git
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Cernekee <cernekee@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: Steve French <sfrench@samba.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] [CIFS] Fix signed/unsigned pointer warning
Date: Sun, 14 Dec 2014 16:54:12 -0800 [thread overview]
Message-ID: <CAJiQ=7B5L=ZrJYSCuUDkG+qtUOUHueAwsWut4KyBTsj0xE+q5w@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mucwo_FH4M=UUoLNDZNRFFcG9hd=Gxc7ma5jwkJQ2-qTg@mail.gmail.com>
On Sun, Dec 14, 2014 at 4:28 PM, Steve French <smfrench@gmail.com> wrote:
> On Sat, Dec 13, 2014 at 11:29 PM, Kevin Cernekee <cernekee@gmail.com> wrote:
>> On Sat, Dec 13, 2014 at 9:20 PM, Steve French <smfrench@gmail.com> wrote:
>>> Probably harmless patch - but I didn't notice the warning on x86
>>> kernel build (building on Fedora 21, gcc 4.9.2)
>>
>> Did you test x86 32-bit or 64-bit? In the generic do_div()
>
> I built current mainline with 64 bit disabled. No warnings on this
> before or after the patch.
Ah, right, it only shows up on 32-bit architectures that use the
generic do_div implementation. To see the warning on x86, you'd need
to do something like this:
$ git --no-pager diff
diff --git a/arch/x86/include/asm/div64.h b/arch/x86/include/asm/div64.h
index ced283a..f693002 100644
--- a/arch/x86/include/asm/div64.h
+++ b/arch/x86/include/asm/div64.h
@@ -1,7 +1,7 @@
#ifndef _ASM_X86_DIV64_H
#define _ASM_X86_DIV64_H
-#ifdef CONFIG_X86_32
+#if 0//def CONFIG_X86_32
#include <linux/types.h>
#include <linux/log2.h>
$ touch fs/cifs/netmisc.c
$ make ARCH=x86 vmlinux
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CC fs/cifs/netmisc.o
fs/cifs/netmisc.c: In function ‘cifs_NTtimeToUnix’:
fs/cifs/netmisc.c:937:23: warning: comparison of distinct pointer
types lacks a cast [enabled by default]
fs/cifs/netmisc.c:941:22: warning: comparison of distinct pointer
types lacks a cast [enabled by default]
LD fs/cifs/cifs.o
LD fs/cifs/built-in.o
LD fs/built-in.o
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
KSYM .tmp_kallsyms1.o
KSYM .tmp_kallsyms2.o
LD vmlinux
SORTEX vmlinux
SYSMAP System.map
$
> merged into cifs-2.6.git
Thanks!
next prev parent reply other threads:[~2014-12-15 0:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 21:09 [PATCH 1/2] [CIFS] Fix signed/unsigned pointer warning Kevin Cernekee
2014-11-10 21:09 ` Kevin Cernekee
2014-11-10 21:09 ` [PATCH 2/2] [CIFS] Update MAINTAINERS entry Kevin Cernekee
[not found] ` <1415653764-22162-2-git-send-email-cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-11 2:58 ` Steve French
2014-11-11 2:58 ` Steve French
[not found] ` <1415653764-22162-1-git-send-email-cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-12 17:19 ` [PATCH 1/2] [CIFS] Fix signed/unsigned pointer warning Kevin Cernekee
2014-12-12 17:19 ` Kevin Cernekee
[not found] ` <CAJiQ=7C9qV2acVLWjacwsRmGMbyKUqCT5VbnO5TzeLLX73xMaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-14 5:20 ` Steve French
2014-12-14 5:20 ` Steve French
[not found] ` <CAH2r5mteTRPVNTgVxNLqjdzok87HXxhC+xo+tnR3L0DKntSe6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-14 5:29 ` Kevin Cernekee
2014-12-14 5:29 ` Kevin Cernekee
[not found] ` <CAJiQ=7APtRLarnAFFaDy1_KgnBN-wcK2=scOP5Ks0v5GH=AR3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-15 0:28 ` Steve French
2014-12-15 0:28 ` Steve French
[not found] ` <CAH2r5mucwo_FH4M=UUoLNDZNRFFcG9hd=Gxc7ma5jwkJQ2-qTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-15 0:54 ` Kevin Cernekee [this message]
2014-12-15 0:54 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJiQ=7B5L=ZrJYSCuUDkG+qtUOUHueAwsWut4KyBTsj0xE+q5w@mail.gmail.com' \
--to=cernekee-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.