From: Arnd Bergmann <arnd@arndb.de>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Leonard Crestez" <leonard.crestez@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] soc: imx: check ls1021a
Date: Fri, 17 Jul 2020 18:19:22 +0200 [thread overview]
Message-ID: <CAK8P3a0hxO1TmK6oOMQ70AHSWJnP_CAq57YMOutrxkSYNjFeuw@mail.gmail.com> (raw)
In-Reply-To: <1594283145-7981-1-git-send-email-peng.fan@nxp.com>
On Thu, Jul 9, 2020 at 10:31 AM <peng.fan@nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> fsl,ls1021a is a mach under arch/arm/mach-imx/, however it could
> not use the soc driver which will break caam on ls1021a platform.
>
> So directly return if it is compatible with fsl,ls1021a.
>
> Fixes: 52102a3ba6a61 ("soc: imx: move cpu code to drivers/soc/imx")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
I just forwarded this patch to Linus as part of the v5.8 fixes.
The patch goes in the right direction, but as far as I can tell,
the code is still wrong and needs to be fixed. Can you create
another patch on top?
The problem is that loading this driver on *anything* other
than an i.MX machine will cause unexpected results, and
it first has to check that it is running on a compatible machine
to start with!
In a distro kernel, this driver is always built-in at the moment
if CONFIG_ARCH_MXC is enabled, regardless of what other
platforms are enabled in addition, and what machine we
end up running on.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-17 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 8:25 [PATCH] soc: imx: check ls1021a peng.fan
2020-07-10 10:32 ` Horia Geantă
2020-07-10 14:05 ` Fabio Estevam
2020-07-13 8:28 ` Shawn Guo
2020-07-17 16:19 ` Arnd Bergmann [this message]
2020-07-20 6:30 ` Peng Fan
2020-07-20 7:01 ` Arnd Bergmann
2020-07-20 7:05 ` Peng Fan
2020-07-20 7:19 ` Arnd Bergmann
2020-07-20 9:01 ` Peng Fan
2020-07-20 12:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0hxO1TmK6oOMQ70AHSWJnP_CAq57YMOutrxkSYNjFeuw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=aisheng.dong@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.