All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.ml.walleij@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations
Date: Wed, 10 Aug 2011 07:54:52 +0000	[thread overview]
Message-ID: <CAKnu2Mofp+f7Khu1d0j9Pz3Pr03EawBgkRPWEqDy7mf4DzoETA@mail.gmail.com> (raw)
In-Reply-To: <E1QqhM1-0003af-U5@rmk-PC.arm.linux.org.uk>

2011/8/9 Russell King - ARM Linux <linux@arm.linux.org.uk>:

> Consolidate 24 trivial gpiolib implementions out of mach/gpio.h
> into asm/gpio.h.  This is basically the include of asm-generic/gpio.h
> and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep
> as described in Documentation/gpio.txt
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

reaks compile of plat-nomadik due to missing u32, feel free to fold in
the below fix. With that it's
Tested-by: Linus Walleij <linus.walleij@linaro.org>
for Nomadik, U300 and Ux500.

From 2e4496fc7643d804ccf50a8efe1a0304210176d1 Mon Sep 17 00:00:00 2001
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 10 Aug 2011 09:51:16 +0200
Subject: [PATCH] plat-nomadik: small fixup for gpio.h

Removing the generic gpio.h broke compilation of the Nomadik
GPIO driver since it implicitly got u32 from it. Explicitly
include <linux/kernel.h> so we get u32 defined.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/plat-nomadik/include/plat/gpio.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-nomadik/include/plat/gpio.h
b/arch/arm/plat-nomadik/include/plat/gpio.h
index cf0b78b..b894a53 100644
--- a/arch/arm/plat-nomadik/include/plat/gpio.h
+++ b/arch/arm/plat-nomadik/include/plat/gpio.h
@@ -12,6 +12,8 @@
 #ifndef __ASM_PLAT_GPIO_H
 #define __ASM_PLAT_GPIO_H

+#include <linux/kernel.h>
+
 /*
  * "nmk_gpio" and "NMK_GPIO" stand for "Nomadik GPIO", leaving
  * the "gpio" namespace for generic and cross-machine functions
-- 
1.7.3.2

Thanks,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.ml.walleij@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations
Date: Wed, 10 Aug 2011 09:54:52 +0200	[thread overview]
Message-ID: <CAKnu2Mofp+f7Khu1d0j9Pz3Pr03EawBgkRPWEqDy7mf4DzoETA@mail.gmail.com> (raw)
In-Reply-To: <E1QqhM1-0003af-U5@rmk-PC.arm.linux.org.uk>

2011/8/9 Russell King - ARM Linux <linux@arm.linux.org.uk>:

> Consolidate 24 trivial gpiolib implementions out of mach/gpio.h
> into asm/gpio.h.  This is basically the include of asm-generic/gpio.h
> and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep
> as described in Documentation/gpio.txt
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

reaks compile of plat-nomadik due to missing u32, feel free to fold in
the below fix. With that it's
Tested-by: Linus Walleij <linus.walleij@linaro.org>
for Nomadik, U300 and Ux500.

From 2e4496fc7643d804ccf50a8efe1a0304210176d1 Mon Sep 17 00:00:00 2001
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 10 Aug 2011 09:51:16 +0200
Subject: [PATCH] plat-nomadik: small fixup for gpio.h

Removing the generic gpio.h broke compilation of the Nomadik
GPIO driver since it implicitly got u32 from it. Explicitly
include <linux/kernel.h> so we get u32 defined.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/plat-nomadik/include/plat/gpio.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-nomadik/include/plat/gpio.h
b/arch/arm/plat-nomadik/include/plat/gpio.h
index cf0b78b..b894a53 100644
--- a/arch/arm/plat-nomadik/include/plat/gpio.h
+++ b/arch/arm/plat-nomadik/include/plat/gpio.h
@@ -12,6 +12,8 @@
 #ifndef __ASM_PLAT_GPIO_H
 #define __ASM_PLAT_GPIO_H

+#include <linux/kernel.h>
+
 /*
  * "nmk_gpio" and "NMK_GPIO" stand for "Nomadik GPIO", leaving
  * the "gpio" namespace for generic and cross-machine functions
-- 
1.7.3.2

Thanks,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations
Date: Wed, 10 Aug 2011 09:54:52 +0200	[thread overview]
Message-ID: <CAKnu2Mofp+f7Khu1d0j9Pz3Pr03EawBgkRPWEqDy7mf4DzoETA@mail.gmail.com> (raw)
In-Reply-To: <E1QqhM1-0003af-U5@rmk-PC.arm.linux.org.uk>

2011/8/9 Russell King - ARM Linux <linux@arm.linux.org.uk>:

> Consolidate 24 trivial gpiolib implementions out of mach/gpio.h
> into asm/gpio.h. ?This is basically the include of asm-generic/gpio.h
> and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep
> as described in Documentation/gpio.txt
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

reaks compile of plat-nomadik due to missing u32, feel free to fold in
the below fix. With that it's
Tested-by: Linus Walleij <linus.walleij@linaro.org>
for Nomadik, U300 and Ux500.

  parent reply	other threads:[~2011-08-10  7:54 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09  8:04 [PATCH 00/13] Clean up mach/gpio.h headers Russell King - ARM Linux
2011-08-09  8:04 ` Russell King - ARM Linux
2011-08-09  8:04 ` Russell King - ARM Linux
2011-08-09  8:04 ` [PATCH 01/13] ARM: gpio: at91: remove redundant include of Russell King - ARM Linux
2011-08-09  8:04   ` [PATCH 01/13] ARM: gpio: at91: remove redundant include of mach/gpio.h Russell King - ARM Linux
2011-08-09  8:04   ` Russell King - ARM Linux
2011-08-09  8:05 ` [PATCH 02/13] ARM: gpio: convert includes of mach/gpio.h and Russell King - ARM Linux
2011-08-09  8:05   ` [PATCH 02/13] ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h Russell King - ARM Linux
2011-08-09  8:05   ` Russell King - ARM Linux
2011-08-09  8:05 ` [PATCH 03/13] ARM: gpio: omap: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:05   ` [PATCH 03/13] ARM: gpio: omap: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:05   ` Russell King - ARM Linux
2011-08-29 18:20   ` Kevin Hilman
2011-08-29 18:20     ` Kevin Hilman
2011-08-29 18:20     ` Kevin Hilman
2011-08-09  8:05 ` [PATCH 04/13] ARM: gpio: at91: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:05   ` [PATCH 04/13] ARM: gpio: at91: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:05   ` Russell King - ARM Linux
2011-08-09  8:06 ` [PATCH 05/13] ARM: gpio: nomadik: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:06   ` [PATCH 05/13] ARM: gpio: nomadik: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:06   ` Russell King - ARM Linux
2011-08-09  8:06 ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:06   ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:06   ` Russell King - ARM Linux
2011-08-09 12:06   ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use asm/gpio.h Sergei Shtylyov
2011-08-09 12:06     ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use asm/gpio.h rather than mach/gpio.h Sergei Shtylyov
2011-08-09 12:06     ` Sergei Shtylyov
2011-08-09 19:45     ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use Russell King - ARM Linux
2011-08-09 19:45       ` [PATCH 06/13] ARM: gpio: davinci: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09 19:45       ` Russell King - ARM Linux
2011-08-09  8:06 ` [PATCH 07/13] ARM: gpio: pnx4008: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:06   ` [PATCH 07/13] ARM: gpio: pnx4008: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:06   ` Russell King - ARM Linux
2011-08-09  8:07 ` [PATCH 08/13] ARM: gpio: ixp2000: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:07   ` [PATCH 08/13] ARM: gpio: ixp2000: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:07   ` Russell King - ARM Linux
2011-08-09  8:07 ` [PATCH 09/13] ARM: gpio: tegra: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:07   ` [PATCH 09/13] ARM: gpio: tegra: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:07   ` Russell King - ARM Linux
2011-08-09  8:07 ` [PATCH 10/13] ARM: gpio: pxa: convert drivers to use asm/gpio.h Russell King - ARM Linux
2011-08-09  8:07   ` [PATCH 10/13] ARM: gpio: pxa: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-09  8:07   ` Russell King - ARM Linux
2011-08-09  8:08 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Russell King - ARM Linux
2011-08-09  8:08   ` Russell King - ARM Linux
2011-08-09  8:08   ` Russell King - ARM Linux
2011-08-09 17:02   ` H Hartley Sweeten
2011-08-09 17:02   ` H Hartley Sweeten
2011-08-09 17:02   ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib H Hartley Sweeten
2011-08-09 17:02     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations H Hartley Sweeten
2011-08-09 17:02     ` H Hartley Sweeten
2011-08-09 17:02   ` H Hartley Sweeten
2011-08-09 17:59   ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib David Brown
2011-08-09 17:59     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations David Brown
2011-08-09 17:59     ` David Brown
2011-08-10  7:54   ` Linus Walleij [this message]
2011-08-10  7:54     ` Linus Walleij
2011-08-10  7:54     ` Linus Walleij
     [not found]   ` <E1QqhM1-0003af-U5-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2011-08-11 11:47     ` Kukjin Kim
2011-08-11 11:47   ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Kukjin Kim
2011-08-11 11:47     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Kukjin Kim
2011-08-11 11:47     ` Kukjin Kim
2011-08-11 15:08     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Russell King - ARM Linux
2011-08-11 15:08       ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Russell King - ARM Linux
2011-08-11 15:08       ` Russell King - ARM Linux
2011-08-11 16:24       ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib David Brown
2011-08-11 16:24         ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations David Brown
2011-08-11 16:24         ` David Brown
2011-08-11 14:15   ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Felipe Balbi
2011-08-11 14:15     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Felipe Balbi
2011-08-11 14:15     ` Felipe Balbi
2011-08-11 15:07     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Russell King - ARM Linux
2011-08-11 15:07       ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Russell King - ARM Linux
2011-08-11 15:07       ` Russell King - ARM Linux
2011-08-11 18:50       ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Felipe Balbi
2011-08-11 18:50         ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Felipe Balbi
2011-08-11 18:50         ` Felipe Balbi
2011-08-12  5:54   ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib Shawn Guo
2011-08-12  5:54     ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Shawn Guo
2011-08-12  5:54     ` Shawn Guo
2011-08-29 18:23   ` Kevin Hilman
2011-08-29 18:23     ` Kevin Hilman
2011-08-29 18:23     ` Kevin Hilman
2011-08-09  8:08 ` [PATCH 12/13] ARM: gpio: consolidate gpio_to_irq Russell King - ARM Linux
2011-08-09  8:08   ` Russell King - ARM Linux
2011-08-09  8:08   ` Russell King - ARM Linux
     [not found]   ` <E1QqhMM-0003aj-C7-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2011-08-11 11:58     ` Kukjin Kim
2011-08-11 11:58   ` Kukjin Kim
2011-08-11 11:58     ` Kukjin Kim
2011-08-11 11:58     ` Kukjin Kim
2011-08-09  8:08 ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the Russell King - ARM Linux
2011-08-09  8:08   ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the default Russell King - ARM Linux
2011-08-09  8:08   ` Russell King - ARM Linux
2011-08-09 17:04   ` H Hartley Sweeten
2011-08-09 17:04   ` H Hartley Sweeten
2011-08-09 17:04   ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation H Hartley Sweeten
2011-08-09 17:04     ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the default H Hartley Sweeten
2011-08-09 17:04   ` H Hartley Sweeten
     [not found]   ` <E1QqhMg-0003an-GW-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2011-08-09 17:04     ` H Hartley Sweeten
2011-08-11 12:02     ` Kukjin Kim
2011-08-11 12:02   ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the Kukjin Kim
2011-08-11 12:02     ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the default Kukjin Kim
2011-08-11 12:02     ` Kukjin Kim
2011-08-09  9:58 ` [PATCH 00/13] Clean up mach/gpio.h headers Jamie Iles
2011-08-09  9:58   ` Jamie Iles
2011-08-09  9:58   ` Jamie Iles
2011-08-09 21:00 ` Grant Likely
2011-08-09 21:00   ` Grant Likely
2011-08-09 21:00   ` Grant Likely
2011-08-09 21:32   ` Russell King - ARM Linux
2011-08-09 21:32     ` Russell King - ARM Linux
2011-08-09 21:32     ` Russell King - ARM Linux
2011-08-09 21:50     ` Grant Likely
2011-08-09 21:50       ` Grant Likely
2011-08-09 21:50       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKnu2Mofp+f7Khu1d0j9Pz3Pr03EawBgkRPWEqDy7mf4DzoETA@mail.gmail.com \
    --to=linus.ml.walleij@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.