Re: [PATCH 3/6] pgo: modules Add module profile data export machinery.

[Nick Desaulniers <ndesaulniers@google.com>]

On Tue, Jun 1, 2021 at 1:46 PM <jarmo.tiitto@gmail.com> wrote:
>
> Kirjoitit tiistaina 1. kesäkuuta 2021 20.27.01 EEST:
>
> > Hi Jarmo,
> > Thanks for the series! Would you mind including the above in a cover letter
> > in a v2? (You can use --cover-letter command line arg to `git format-patch`
> > to generate a stub).  The please explicitly cc
> > Sami Tolvanen <samitolvanen@google.com>
> > Bill Wendling <morbo@google.com>
> > on the series? Finally, please specify the cover letter and all patch files
> > to git send-email in one command, so that the individual patch files are
> > linked on lore.kernel.org. This makes it significantly easier to review and
> > test.
> >
>
> Hello,
>
> Yeah, I realized afterwards that I screwed up at the git send-mail/message
> threading task. Sorry about that. I will correct all of it in my next v2
> patch. Make mistakes, and learn new things.

No worries; best way to learn to swim is to jump in the pool!
(Well...I might not actually recommend that to kids, but you catch the
drift; maybe "sink or swim" is the better expression?).  Also, you
should use text/plain for your email; you're probably getting
automated responses from LKML about that. In gmail, you can click the
vertical ellipses in the bottom right of a reply; make sure to check
"Plain Text."

> I will post new v2 patch once I'm done writing and testing it. Based on the
> feed back here I will try keep it simple and unify the vmlinux + modules code
> such that there is no fs_mod.c source any more nor necessary code duplication.
>
> Basically it will be an rewrite on my part but I'm just excited to do it.

Better to rewrite it now rather than later, I suppose.

> I feel this first attempt was more like of RFC/prototype such that I could get
> in contact with you guys.

Yep, that's common for v1 of patches.  If you're interested in Clang
Built Linux generally, send me your github account name and I'll add
you to our org on github.
https://github.com/ClangBuiltLinux

> Just one question about copyrights: do I need to add my statement to the
> sources, if yes, then how should I proceed ?

Sure, you can add them to the top level of each source file you touch
(we don't do this for Makefiles I think).  I think the signed-off-by
tag is enough though, which implies agreement with the Developer's
Certificate of Origin:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1.
For instance, I don't think I ever have added my name/copyright to the
top of a file, but that also has to do with my employment agreement I
have with my employer. IANAL
-- 
Thanks,
~Nick Desaulniers