From: "Оля Тележная" <olyatelezhnaya@gmail.com>
To: git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Christian Couder <christian.couder@gmail.com>
Subject: [PATCH 0/3] ref-filter: reduce memory leaks
Date: Tue, 9 Oct 2018 11:12:32 +0300 [thread overview]
Message-ID: <CAL21BmkdUiNgr4NqpwTdi9f47i85s8oXCZMmVx5VyNKotL78uA@mail.gmail.com> (raw)
Reduce memory leaks in ref-filter.c.
We still have leaks, but at least not so much.
I use command valgrind --leak-check=full -v ./git for-each-ref to check results.
Before:
==24727== LEAK SUMMARY:
==24727== definitely lost: 69,424 bytes in 724 blocks
==24727== indirectly lost: 29,643 bytes in 723 blocks
==24727== possibly lost: 120 bytes in 3 blocks
==24727== still reachable: 16,535 bytes in 185 blocks
==24727== suppressed: 0 bytes in 0 blocks
==24727== Reachable blocks (those to which a pointer was found) are not shown.
==24727== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==24727==
==24727== ERROR SUMMARY: 107 errors from 107 contexts (suppressed: 0 from 0)
==24727== ERROR SUMMARY: 107 errors from 107 contexts (suppressed: 0 from 0)
After:
==16419== LEAK SUMMARY:
==16419== definitely lost: 17,144 bytes in 1,447 blocks
==16419== indirectly lost: 0 bytes in 0 blocks
==16419== possibly lost: 120 bytes in 3 blocks
==16419== still reachable: 16,217 bytes in 181 blocks
==16419== suppressed: 0 bytes in 0 blocks
==16419== Reachable blocks (those to which a pointer was found) are not shown.
==16419== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==16419==
==16419== ERROR SUMMARY: 82 errors from 82 contexts (suppressed: 0 from 0)
==16419== ERROR SUMMARY: 82 errors from 82 contexts (suppressed: 0 from 0)
Travis build failed, but it also failed in master, so I guess it's not my fault.
https://github.com/git/git/pull/538
Thank you!
Olga
next reply other threads:[~2018-10-09 8:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 8:12 Оля Тележная [this message]
2018-10-09 8:18 ` [PATCH 1/3] ref-filter: free memory from used_atom Olga Telezhnaya
2018-10-09 8:18 ` [PATCH 3/3] ref-filter: free item->value and item->value->s Olga Telezhnaya
2018-10-11 1:19 ` Junio C Hamano
2018-10-12 19:09 ` Jeff King
2018-10-09 8:18 ` [PATCH 2/3] ls-remote: release memory instead of UNLEAK Olga Telezhnaya
2018-10-11 1:20 ` Junio C Hamano
2018-10-11 1:03 ` [PATCH 1/3] ref-filter: free memory from used_atom Junio C Hamano
2018-10-12 2:35 ` Junio C Hamano
2018-10-18 6:33 ` Jeff King
2018-10-18 6:50 ` Junio C Hamano
2018-10-18 7:26 ` Оля Тележная
2018-10-18 7:28 ` [PATCH v2 " Olga Telezhnaya
2018-10-18 7:28 ` [PATCH v2 2/3] ls-remote: release memory instead of UNLEAK Olga Telezhnaya
2018-10-18 7:28 ` [PATCH v2 3/3] ref-filter: free item->value and item->value->s Olga Telezhnaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL21BmkdUiNgr4NqpwTdi9f47i85s8oXCZMmVx5VyNKotL78uA@mail.gmail.com \
--to=olyatelezhnaya@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.