Re: odd msg using kvalo firmware-5.bin w/ KillerAC 1535(QCA6174)

[Marcin Rokicki <marcin.rokicki@tieto.com>]

I made quick check and the last existing ev is:
ath10k_pci 0000:03:00.0: WMI_TLV_RADIO_LINK_STATS_EVENTID: 90116

If you don't want to implement this feature now then could you please
define these 2 missing ev's name
for simple suppress not implemented ev. (to avoid naming like this)

 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 5 +++++
 drivers/net/wireless/ath/ath10k/wmi-tlv.h | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index f918802..c0ec27b 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -552,6 +552,11 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k
*ar, struct sk_buff *skb)
  case WMI_TLV_TX_PAUSE_EVENTID:
  ath10k_wmi_tlv_event_tx_pause(ar, skb);
  break;
+ case WMI_TLV_RSVD1_STATS_EVENTID:
+ case WMI_TLV_RSVD2_STATS_EVENTID:
+ ath10k_dbg(ar, ATH10K_DBG_WMI,
+   "received event id %d is not implemented\n", id);
+ break;
  default:
  ath10k_warn(ar, "Unknown eventid: %d\n", id);
  break;
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
index 22cf011..19f7e48 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
@@ -335,6 +335,8 @@ enum wmi_tlv_event_id {
  WMI_TLV_IFACE_LINK_STATS_EVENTID,
  WMI_TLV_PEER_LINK_STATS_EVENTID,
  WMI_TLV_RADIO_LINK_STATS_EVENTID,
+ WMI_TLV_RSVD1_STATS_EVENTID,
+ WMI_TLV_RSVD2_STATS_EVENTID,
  WMI_TLV_NLO_MATCH_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_NLO_OFL),
  WMI_TLV_NLO_SCAN_COMPLETE_EVENTID,
  WMI_TLV_APFIND_EVENTID,

---

*Marcin*

On 21 April 2017 at 21:53, Adrian Chadd <adrian@freebsd.org> wrote:
> can we get a definition of the feature so we can just implement it? It
> looks like something simpleish?
>
>
> -a
>
>
> On 21 April 2017 at 12:00, Ryan Hsu <ryanhsu@qti.qualcomm.com> wrote:
>> On 04/19/2017 11:34 PM, Kalle Valo wrote:
>>
>>> "Mohammed Shafi Shajakhan (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
>>> writes:
>>>
>>>> my quick analysis suggests this belongs to
>>>> 'WMI_TLV_GRP_STATS'
>>>>
>>>> WMI_TLV_STATS_EXT_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_STATS), equals to 90112 (0x16000)
>>>>         WMI_TLV_IFACE_LINK_STATS_EVENTID, 90113
>>>>         WMI_TLV_PEER_LINK_STATS_EVENTID, 90114
>>>>         WMI_TLV_RADIO_LINK_STATS_EVENTID, 90015
>>>>              .... ?
>>>>         WMI_TLV_NLO_MATCH_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_NLO_OFL),
>>>
>>> I checked and I think this is a some kind of RSSI stats event. I assume
>>> that's a new feature coming from RM.4.4 branch. (Michael said on IRC he
>>> is not seeing that with RM.2.0 branch.)
>>>
>>>> but this should be a harmless warning message indicating the host had not implemented
>>>> any action for this particular event.
>>>>
>>>> For example in 10.2 wmi.c
>>>>
>>>>
>>>>    case WMI_10_2_GPIO_INPUT_EVENTID:
>>>>         case WMI_10_2_PEER_RATECODE_LIST_EVENTID:
>>>>         case WMI_10_2_GENERIC_BUFFER_EVENTID:
>>>>         case WMI_10_2_MCAST_BUF_RELEASE_EVENTID:
>>>>         case WMI_10_2_MCAST_LIST_AGEOUT_EVENTID:
>>>>         case WMI_10_2_WDS_PEER_EVENTID:
>>>>                 ath10k_dbg(ar, ATH10K_DBG_WMI,
>>>>                            "received event id %d not implemented\n", id);
>>>>                 break;
>>> Yes, it's harmless but ath10k should not print that warning to not
>>> distract the users. Can someone make a patch to silent the warning that
>>> similarly like with WMI_10_2_WDS_PEER_EVENTID above?
>>>
>>
>> It doesn't harm anything, just a new firmware feature that is not implemented in ath10k.
>> I'll make the message silent instead of warn to avoid confusion. And will also see if we could also disable it
>>
>> Ryan
>> _______________________________________________
>> ath10k mailing list
>> ath10k@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/ath10k
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k