All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mustafa Kuscu <mustafakuscu@gmail.com>
To: linux-input@vger.kernel.org
Cc: trivial@kernel.org
Subject: [PATCH] asus rog laptops GL55x keyboard backlight fix
Date: Mon, 16 Oct 2017 12:46:08 +0300	[thread overview]
Message-ID: <CAMz_NCpaW7T_zUT5e8er9FRQWPd3nQLh0x5huwvcjaJkEL-JXA@mail.gmail.com> (raw)

Dear all,

Some ASUS ROG laptops have a backlit keyboard which is detected fine
but Fn + F3/F4 does not work in setting up backlight level.

It appears that after making the one liner change below, the backlight
level can be controlled by the Fn keys.

It is intended only to the following device: 0x0b05 1854,
P:  Vendor=0b05 ProdID=1854 Rev=03.02
S:  Manufacturer=ITE Tech. Inc.
S:  Product=ITE Device(8910)

which is already captured as
HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2),

However, the QUIRK is only present for ROG KEYBOARD2.

   { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
        USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) },
    { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
        USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT },

It appears that the device is only used by hid-asus.c.

Hope this helps to other people having the same issue.

Mustafa



--- hid-asus.c.orig    2017-10-16 12:20:14.631341280 +0300
+++ hid-asus.c    2017-10-16 12:20:24.814674504 +0300
@@ -593,7 +593,7 @@ static const struct hid_device_id asus_d
     { HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK,
         USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPAD), I2C_TOUCHPAD_QUIRKS },
     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
-        USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) },
+        USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1), QUIRK_USE_KBD_BACKLIGHT },
     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
         USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT },
     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,

                 reply	other threads:[~2017-10-16  9:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMz_NCpaW7T_zUT5e8er9FRQWPd3nQLh0x5huwvcjaJkEL-JXA@mail.gmail.com \
    --to=mustafakuscu@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.