Re: [PATCH 1/1] [SUNRPC] make sure to clone timeout values

[Olga Kornievskaia <aglo@umich.edu>]

On Tue, May 22, 2018 at 3:03 PM, Trond Myklebust
<trondmy@hammerspace.com> wrote:
> On Tue, 2018-05-22 at 14:40 -0400, Olga Kornievskaia wrote:
>> From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
>>
>> For pNFS, the operations to DS currently timeout in 10s. According
>> to the spec, the client must not be re-trying an NFSv4.1 operation
>> unless the connection was broken.
>>
>> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
>> ---
>>  net/sunrpc/clnt.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
>> index 6e432ec..97517eb 100644
>> --- a/net/sunrpc/clnt.c
>> +++ b/net/sunrpc/clnt.c
>> @@ -668,6 +668,7 @@ struct rpc_clnt *
>>               .prognumber     = clnt->cl_prog,
>>               .version        = clnt->cl_vers,
>>               .authflavor     = flavor,
>> +             .timeout        = clnt->cl_timeout,
>>       };
>>       return __rpc_clone_client(&args, clnt);
>>  }
>
> What does this patch have to do with pNFS? That's the generic RPC
> client cloning API you are changing.
>
> The pNFS/files timeouts are intended to be set using the
> dataserver_retrans and dataserver_timeo module parameters described at
> the bottom of fs/nfs/filelayout/filelayoutdev.c

Ok so perhaps the code needs to re-written so that it allows for the
DS to get an rpc client with its timeouts set. Which currently doesn't
happen.