All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Marshall <hubcap@omnibond.com>
To: Linus Torvalds <linus971@gmail.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Mike Marshall <hubcap@omnibond.com>
Subject: [GIT PULL] orangefs: posix open
Date: Fri, 6 Dec 2019 14:43:53 -0500	[thread overview]
Message-ID: <CAOg9mSS6daFQWvxUeFpGzC6U9D5ddH-iazskoOgGLML781p5xg@mail.gmail.com> (raw)

The following changes since commit a99d8080aaf358d5d23581244e5da23b35e340b9:

  Linux 5.4-rc6 (2019-11-03 14:07:26 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux.git
tags/for-linus-5.5-ofs1

for you to fetch changes up to f9bbb68233aa5bd5ef238bd3532fddf92fa1b53c:

  orangefs: posix open permission checking... (2019-12-04 08:52:55 -0500)

----------------------------------------------------------------
orangefs: posix open permission checking...

Orangefs has no open, and orangefs checks file permissions
on each file access. Posix requires that file permissions
be checked on open and nowhere else. Orangefs-through-the-kernel
needs to seem posix compliant.

The VFS opens files, even if the filesystem provides no
method. We can see if a file was successfully opened for
read and or for write by looking at file->f_mode.

When writes are flowing from the page cache, file is no
longer available. We can trust the VFS to have checked
file->f_mode before writing to the page cache.

The mode of a file might change between when it is opened
and IO commences, or it might be created with an arbitrary mode.

We'll make sure we don't hit EACCES during the IO stage by
using UID 0.

----------------------------------------------------------------
Mike Marshall (1):
      orangefs: posix open permission checking...

 fs/orangefs/file.c            | 39 +++++++++++++++++++++++++++++++++++++--
 fs/orangefs/inode.c           |  8 ++++----
 fs/orangefs/orangefs-kernel.h |  3 ++-
 3 files changed, 43 insertions(+), 7 deletions(-)

                 reply	other threads:[~2019-12-06 19:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOg9mSS6daFQWvxUeFpGzC6U9D5ddH-iazskoOgGLML781p5xg@mail.gmail.com \
    --to=hubcap@omnibond.com \
    --cc=linus971@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.