From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>
Cc: Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Kajol Jain <kjain@linux.ibm.com>,
"Paul A . Clarke" <pc@us.ibm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Riccardo Mancini <rickyman7@gmail.com>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Vineet Singh <vineet.singh@intel.com>,
James Clark <james.clark@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
zhengjun.xing@intel.com, eranian@google.com
Subject: Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu.
Date: Mon, 10 Jan 2022 09:36:49 -0800 [thread overview]
Message-ID: <CAP-5=fWT_19OfZTTjvLUcChV4nDwqc5Zq4VE93Gak6OO4NORsA@mail.gmail.com> (raw)
In-Reply-To: <57ab982e-ecc1-3f49-c580-0a251e29698b@huawei.com>
On Mon, Jan 10, 2022 at 9:10 AM John Garry <john.garry@huawei.com> wrote:
>
> On 05/01/2022 06:13, Ian Rogers wrote:
> >
> > +struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx,
> > + void *data)
> > +{
> > + if (idx < 0 || idx > map->nr)
> > + return cpu_map__empty_aggr_cpu_id();
> > +
> > + return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data);
> > +}
> > +
>
>
> This is later deleted in the series. Can the series be reworked so that
> we don't add stuff and then later delete it? One reason for that
> approach is that we don't spend time reviewing something which will be
> deleted, especially in such a big series...
Hi John,
I think you are asking to squash:
https://lore.kernel.org/lkml/20220105061351.120843-8-irogers@google.com/
into this change. There are other similar related changes that may
also be squashed. The changes are trying to introduce a new API and
then add changes to switch over to using it. This is with a view to
making bisection easier, have each change only do 1 thing and so on. I
believe the format of the patches is house style, but it is fine to
squash changes together too. Having sent patches to Arnaldo and having
had them split I'm reluctant to do a v5 with them squashed without him
expressing a preference.
Thanks,
Ian
> If it really makes sense to do it this way then fine.
>
> Thanks,
> John
WARNING: multiple messages have this Message-ID (diff)
From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>
Cc: Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Kajol Jain <kjain@linux.ibm.com>,
"Paul A . Clarke" <pc@us.ibm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Riccardo Mancini <rickyman7@gmail.com>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Vineet Singh <vineet.singh@intel.com>,
James Clark <james.clark@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com,
eranian@google.com
Subject: Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu.
Date: Mon, 10 Jan 2022 09:36:49 -0800 [thread overview]
Message-ID: <CAP-5=fWT_19OfZTTjvLUcChV4nDwqc5Zq4VE93Gak6OO4NORsA@mail.gmail.com> (raw)
In-Reply-To: <57ab982e-ecc1-3f49-c580-0a251e29698b@huawei.com>
On Mon, Jan 10, 2022 at 9:10 AM John Garry <john.garry@huawei.com> wrote:
>
> On 05/01/2022 06:13, Ian Rogers wrote:
> >
> > +struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx,
> > + void *data)
> > +{
> > + if (idx < 0 || idx > map->nr)
> > + return cpu_map__empty_aggr_cpu_id();
> > +
> > + return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data);
> > +}
> > +
>
>
> This is later deleted in the series. Can the series be reworked so that
> we don't add stuff and then later delete it? One reason for that
> approach is that we don't spend time reviewing something which will be
> deleted, especially in such a big series...
Hi John,
I think you are asking to squash:
https://lore.kernel.org/lkml/20220105061351.120843-8-irogers@google.com/
into this change. There are other similar related changes that may
also be squashed. The changes are trying to introduce a new API and
then add changes to switch over to using it. This is with a view to
making bisection easier, have each change only do 1 thing and so on. I
believe the format of the patches is house style, but it is fine to
squash changes together too. Having sent patches to Arnaldo and having
had them split I'm reluctant to do a v5 with them squashed without him
expressing a preference.
Thanks,
Ian
> If it really makes sense to do it this way then fine.
>
> Thanks,
> John
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-10 17:37 UTC|newest]
Thread overview: 170+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 6:13 [PATCH v4 00/48] Refactor perf cpumap Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 01/48] libperf: Add comments to perf_cpu_map Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 17:00 ` John Garry
2022-01-10 17:00 ` John Garry
2022-01-12 5:35 ` kajoljain
2022-01-12 5:35 ` kajoljain
2022-01-05 6:13 ` [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 17:10 ` John Garry
2022-01-10 17:10 ` John Garry
2022-01-10 17:36 ` Ian Rogers [this message]
2022-01-10 17:36 ` Ian Rogers
2022-01-10 17:51 ` John Garry
2022-01-10 17:51 ` John Garry
2022-01-10 18:52 ` Arnaldo Carvalho de Melo
2022-01-10 18:52 ` Arnaldo Carvalho de Melo
2022-01-10 18:53 ` Arnaldo Carvalho de Melo
2022-01-10 18:53 ` Arnaldo Carvalho de Melo
2022-01-10 18:56 ` Arnaldo Carvalho de Melo
2022-01-10 18:56 ` Arnaldo Carvalho de Melo
2022-01-10 19:17 ` John Garry
2022-01-10 19:17 ` John Garry
2022-01-11 19:33 ` Arnaldo Carvalho de Melo
2022-01-11 19:33 ` Arnaldo Carvalho de Melo
2022-01-11 19:36 ` Ian Rogers
2022-01-11 19:36 ` Ian Rogers
2022-01-11 19:56 ` Arnaldo Carvalho de Melo
2022-01-11 19:56 ` Arnaldo Carvalho de Melo
2022-01-11 19:49 ` Arnaldo Carvalho de Melo
2022-01-11 19:49 ` Arnaldo Carvalho de Melo
2022-01-05 6:13 ` [PATCH v4 03/48] perf stat: Correct aggregation CPU map Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 18:43 ` John Garry
2022-01-10 18:43 ` John Garry
2022-01-05 6:13 ` [PATCH v4 04/48] perf stat: Switch aggregation to use for_each loop Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 18:50 ` John Garry
2022-01-10 18:50 ` John Garry
2022-01-10 22:22 ` Ian Rogers
2022-01-10 22:22 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 05/48] perf stat: Switch to cpu version of cpu_map__get Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 19:04 ` John Garry
2022-01-10 19:04 ` John Garry
2022-01-11 18:46 ` Ian Rogers
2022-01-11 18:46 ` Ian Rogers
2022-01-11 18:50 ` Arnaldo Carvalho de Melo
2022-01-11 18:50 ` Arnaldo Carvalho de Melo
2022-01-05 6:13 ` [PATCH v4 06/48] perf cpumap: Switch cpu_map__build_map to cpu function Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 07/48] perf cpumap: Remove map+index get_socket Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 08/48] perf cpumap: Remove map+index get_die Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 09/48] perf cpumap: Remove map+index get_core Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 10/48] perf cpumap: Remove map+index get_node Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 11/48] perf cpumap: Add comments to aggr_cpu_id Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 12/48] perf cpumap: Remove unused cpu_map__socket Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 13/48] perf cpumap: Simplify equal function name Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 14/48] perf cpumap: Rename empty functions Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 15/48] perf cpumap: Document cpu__get_node and remove redundant function Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 16/48] perf cpumap: Remove map from function names that don't use a map Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 17/48] perf cpumap: Remove cpu_map__cpu, use libperf function Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 19:02 ` Arnaldo Carvalho de Melo
2022-01-10 19:02 ` Arnaldo Carvalho de Melo
2022-01-10 19:04 ` Arnaldo Carvalho de Melo
2022-01-10 19:04 ` Arnaldo Carvalho de Melo
2022-01-10 19:06 ` Arnaldo Carvalho de Melo
2022-01-10 19:06 ` Arnaldo Carvalho de Melo
2022-01-05 6:13 ` [PATCH v4 18/48] perf cpumap: Refactor cpu_map__build_map Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 19/48] perf cpumap: Rename cpu_map__get_X_aggr_by_cpu functions Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 20/48] perf cpumap: Move 'has' function to libperf Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 21/48] perf cpumap: Add some comments to cpu_aggr_map Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 22/48] perf cpumap: Trim the cpu_aggr_map Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 23/48] perf stat: Fix memory leak in check_per_pkg Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 24/48] perf cpumap: Add CPU to aggr_cpu_id Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 25/48] perf stat-display: Avoid use of core for CPU Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 26/48] perf evsel: Derive CPUs and threads in alloc_counts Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-09 18:30 ` Jiri Olsa
2022-01-09 18:30 ` Jiri Olsa
2022-01-10 5:49 ` Ian Rogers
2022-01-10 5:49 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 27/48] libperf: Switch cpu to more accurate cpu_map_idx Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 28/48] libperf: Use cpu not index for evsel mmap Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 29/48] perf counts: Switch name cpu to cpu_map_idx Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 30/48] perf stat: Rename aggr_data cpu to imply it's an index Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 31/48] perf stat: Use perf_cpu_map__for_each_cpu Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 32/48] perf script: Use for each cpu to aid readability Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 33/48] libperf: Allow NULL in perf_cpu_map__idx Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 34/48] perf evlist: Refactor evlist__for_each_cpu Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 35/48] perf evsel: Pass cpu not cpu map index to synthesize Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 36/48] perf stat: Correct variable name for read counter Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 37/48] perf evsel: Rename CPU around get_group_fd Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 38/48] perf evsel: Reduce scope of evsel__ignore_missing_thread Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 39/48] perf evsel: Rename variable cpu to index Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 40/48] perf test: Use perf_cpu_map__for_each_cpu Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 41/48] perf stat: Correct check_per_pkg cpu Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 42/48] perf stat: Swap variable name cpu to index Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 43/48] libperf: Sync evsel documentation Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 44/48] perf bpf: Rename cpu to cpu_map_idx Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-10 19:10 ` Arnaldo Carvalho de Melo
2022-01-10 19:10 ` Arnaldo Carvalho de Melo
2022-01-10 19:26 ` Arnaldo Carvalho de Melo
2022-01-10 19:26 ` Arnaldo Carvalho de Melo
2022-01-05 6:13 ` [PATCH v4 45/48] perf c2c: Use more intention revealing iterator Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 46/48] perf script: Fix flipped index and cpu Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 47/48] perf stat: Correct first_shadow_cpu to return index Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-05 6:13 ` [PATCH v4 48/48] perf cpumap: Give CPUs their own type Ian Rogers
2022-01-05 6:13 ` Ian Rogers
2022-01-09 18:30 ` Jiri Olsa
2022-01-09 18:30 ` Jiri Olsa
2022-01-10 5:45 ` Ian Rogers
2022-01-10 5:45 ` Ian Rogers
2022-01-10 19:50 ` Arnaldo Carvalho de Melo
2022-01-10 19:50 ` Arnaldo Carvalho de Melo
2022-01-11 19:16 ` Ian Rogers
2022-01-11 19:16 ` Ian Rogers
2022-01-11 20:01 ` Arnaldo Carvalho de Melo
2022-01-11 20:01 ` Arnaldo Carvalho de Melo
2022-01-11 20:47 ` Arnaldo Carvalho de Melo
2022-01-11 20:47 ` Arnaldo Carvalho de Melo
2022-01-12 17:39 ` Arnaldo Carvalho de Melo
2022-01-12 18:02 ` Ian Rogers
2022-01-10 20:17 ` [PATCH v4 00/48] Refactor perf cpumap Arnaldo Carvalho de Melo
2022-01-10 20:17 ` Arnaldo Carvalho de Melo
2022-01-10 20:40 ` Arnaldo Carvalho de Melo
2022-01-10 20:40 ` Arnaldo Carvalho de Melo
2022-01-10 20:42 ` Arnaldo Carvalho de Melo
2022-01-10 20:42 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fWT_19OfZTTjvLUcChV4nDwqc5Zq4VE93Gak6OO4NORsA@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=eranian@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=suzuki.poulose@arm.com \
--cc=vineet.singh@intel.com \
--cc=zhengjun.xing@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.