From: Dave Stevenson <dave.stevenson@raspberrypi.com> To: Douglas Anderson <dianders@chromium.org> Cc: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno@lists.freedesktop.org, Jernej Skrabec <jernej.skrabec@gmail.com>, Jonas Karlman <jonas@kwiboo.se>, linux-arm-msm@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Stephen Boyd <swboyd@chromium.org>, Vinod Koul <vkoul@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Sean Paul <sean@poorly.run>, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first Date: Wed, 1 Feb 2023 09:51:06 +0000 [thread overview] Message-ID: <CAPY8ntAUhVB6UtQTeHAcxNW950Ou+NcEoGwk3JnVWLay89_0Nw@mail.gmail.com> (raw) In-Reply-To: <20230131141756.RFT.v2.1.I723a3761d57ea60c5dd754c144aed6c3b2ea6f5a@changeid> On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: > > Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > order"). This should allow us to revert commit ec7981e6c614 > ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > time"). I see no reference in the TC358762 datasheet to requiring the DSI interface to be in any particular state. However, setting this flag does mean that the DSI host doesn't need to power up and down for each host_transfer request from tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/tc358762.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > index 0b6a28436885..77f7f7f54757 100644 > --- a/drivers/gpu/drm/bridge/tc358762.c > +++ b/drivers/gpu/drm/bridge/tc358762.c > @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > ctx->bridge.funcs = &tc358762_bridge_funcs; > ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; > ctx->bridge.of_node = dev->of_node; > + ctx->bridge.pre_enable_prev_first = true; > > drm_bridge_add(&ctx->bridge); > > -- > 2.39.1.456.gfc5497dd1b-goog >
WARNING: multiple messages have this Message-ID (diff)
From: Dave Stevenson <dave.stevenson@raspberrypi.com> To: Douglas Anderson <dianders@chromium.org> Cc: Sean Paul <sean@poorly.run>, Neil Armstrong <neil.armstrong@linaro.org>, linux-kernel@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>, linux-arm-msm@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Stephen Boyd <swboyd@chromium.org>, Vinod Koul <vkoul@kernel.org>, dri-devel@lists.freedesktop.org, Andrzej Hajda <andrzej.hajda@intel.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno@lists.freedesktop.org, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Subject: Re: [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first Date: Wed, 1 Feb 2023 09:51:06 +0000 [thread overview] Message-ID: <CAPY8ntAUhVB6UtQTeHAcxNW950Ou+NcEoGwk3JnVWLay89_0Nw@mail.gmail.com> (raw) In-Reply-To: <20230131141756.RFT.v2.1.I723a3761d57ea60c5dd754c144aed6c3b2ea6f5a@changeid> On Tue, 31 Jan 2023 at 22:22, Douglas Anderson <dianders@chromium.org> wrote: > > Set the "pre_enable_prev_first" as provided by commit 4fb912e5e190 > ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init > order"). This should allow us to revert commit ec7981e6c614 > ("drm/msm/dsi: don't powerup at modeset time for parade-ps8640") and > commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > time"). I see no reference in the TC358762 datasheet to requiring the DSI interface to be in any particular state. However, setting this flag does mean that the DSI host doesn't need to power up and down for each host_transfer request from tc358762_pre_enable/tc358762_init, so on that basis I'm good with it. Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/tc358762.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > index 0b6a28436885..77f7f7f54757 100644 > --- a/drivers/gpu/drm/bridge/tc358762.c > +++ b/drivers/gpu/drm/bridge/tc358762.c > @@ -229,6 +229,7 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > ctx->bridge.funcs = &tc358762_bridge_funcs; > ctx->bridge.type = DRM_MODE_CONNECTOR_DPI; > ctx->bridge.of_node = dev->of_node; > + ctx->bridge.pre_enable_prev_first = true; > > drm_bridge_add(&ctx->bridge); > > -- > 2.39.1.456.gfc5497dd1b-goog >
next prev parent reply other threads:[~2023-02-01 9:51 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-31 22:18 [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first Douglas Anderson 2023-01-31 22:18 ` Douglas Anderson 2023-01-31 22:18 ` [RFT PATCH v2 2/3] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset Douglas Anderson 2023-01-31 22:18 ` Douglas Anderson 2023-01-31 23:32 ` Abhinav Kumar 2023-01-31 23:32 ` Abhinav Kumar 2023-02-01 14:33 ` Doug Anderson 2023-02-01 14:33 ` Doug Anderson 2023-02-02 20:10 ` Abhinav Kumar 2023-02-02 20:10 ` Abhinav Kumar 2023-02-28 1:25 ` Dmitry Baryshkov 2023-02-28 1:25 ` Dmitry Baryshkov 2023-01-31 22:18 ` [RFT PATCH v2 3/3] drm/msm/dsi: More properly handle errors in regards to dsi_mgr_bridge_power_on() Douglas Anderson 2023-01-31 22:18 ` Douglas Anderson 2023-02-02 22:36 ` [Freedreno] " Abhinav Kumar 2023-02-02 22:36 ` Abhinav Kumar 2023-02-02 22:46 ` Doug Anderson 2023-02-02 22:46 ` Doug Anderson 2023-02-14 2:02 ` Abhinav Kumar 2023-02-14 2:02 ` Abhinav Kumar 2023-02-14 15:24 ` Doug Anderson 2023-02-14 15:24 ` Doug Anderson 2023-02-28 1:25 ` Dmitry Baryshkov 2023-02-28 1:25 ` Dmitry Baryshkov 2023-02-01 9:51 ` Dave Stevenson [this message] 2023-02-01 9:51 ` [RFT PATCH v2 1/3] drm/bridge: tc358762: Set pre_enable_prev_first Dave Stevenson 2023-02-28 0:26 ` Doug Anderson 2023-02-28 0:26 ` Doug Anderson 2023-02-28 1:24 ` Dmitry Baryshkov 2023-02-28 1:24 ` Dmitry Baryshkov 2023-03-02 17:25 ` Doug Anderson 2023-03-02 17:25 ` Doug Anderson 2023-03-02 18:19 ` Dmitry Baryshkov 2023-03-02 18:19 ` Dmitry Baryshkov 2023-02-28 1:25 ` Dmitry Baryshkov 2023-02-28 1:25 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPY8ntAUhVB6UtQTeHAcxNW950Ou+NcEoGwk3JnVWLay89_0Nw@mail.gmail.com \ --to=dave.stevenson@raspberrypi.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=andrzej.hajda@intel.com \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robert.foss@linaro.org \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.