From: Jeremy Faith <jeremy.faith@jci.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: bug:git-check-ignore exit status is wrong for negative patterns when -v option used
Date: Tue, 27 Apr 2021 16:30:13 +0000 [thread overview]
Message-ID: <CY4P132MB00885C970ACF5A277F06E40385419@CY4P132MB0088.NAMP132.PROD.OUTLOOK.COM> (raw)
Hi,
git version 2.31.1.362.g311531c9de
git-check-ignore
When a negative pattern is the last .gitignore match the -v option causes the exit status to be 0 rather than the expected 1.
e.g say .gitignore contains one line: !hello
git check-ignore hello #outputs nothing
echo $? #shows correct exit status=1 i.e None of the provided paths are ignored.
but
git check-ignore -v hello #output is next line
.gitignore:4:!hello hello
echo $? #shows wrong exit status=0 i.e. One or more of the provided paths is ignored
Following change seems to fix it for me
--- a/builtin/check-ignore.c
+++ b/builtin/check-ignore.c
@@ -114,7 +114,7 @@ static int check_ignore(struct dir_struct *dir,
}
if (!quiet && (pattern || show_non_matching))
output_pattern(pathspec.items[i].original, pattern);
- if (pattern)
+ if (pattern && !(pattern->flags & PATTERN_FLAG_NEGATIVE))
num_ignored++;
}
free(seen);
Regards,
Jeremy Faith
next reply other threads:[~2021-04-27 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 16:30 Jeremy Faith [this message]
2021-04-28 6:15 ` bug:git-check-ignore exit status is wrong for negative patterns when -v option used Bagas Sanjaya
2021-04-29 14:26 ` Jeremy Faith
2021-04-28 7:13 ` Junio C Hamano
2021-04-29 14:10 ` Jeremy Faith
2021-04-30 0:22 ` Junio C Hamano
2021-04-30 9:56 ` Jeremy Faith
2021-04-30 20:51 ` Elijah Newren
2021-05-03 3:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4P132MB00885C970ACF5A277F06E40385419@CY4P132MB0088.NAMP132.PROD.OUTLOOK.COM \
--to=jeremy.faith@jci.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.