All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Blanc <guillaume.blanc@parrot.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Bad header guard in alsa-lib
Date: Fri, 6 Jul 2018 13:54:07 +0000	[thread overview]
Message-ID: <DB5PR10MB0293F65AACE42CF971B1AE2094470@DB5PR10MB0293.EURPRD10.PROD.OUTLOOK.COM> (raw)

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]


Hello,
While building alsa-lib, I got a redefinition error caused by a bad header guard in pcm_plugin.h.
I assume this is a mistake and not a weird include trick, attached is a patch to fix this.
Best regards,
Guillaume Blanc

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-header-guard-in-pcm_plugin.h.patch --]
[-- Type: text/x-patch; name="0001-Fix-header-guard-in-pcm_plugin.h.patch", Size: 566 bytes --]

From 8e643b7e007074807b83f27d88d02ea367d2c3b7 Mon Sep 17 00:00:00 2001
From: Guillaume Blanc <guillaume.blanc@parrot.com>
Date: Fri, 6 Jul 2018 15:22:06 +0200
Subject: [PATCH - alsa-lib 1/1] Fix header guard in pcm_plugin.h

Signed-off-by: Guillaume Blanc <guillaume.blanc@parrot.com>

diff --git a/include/pcm_plugin.h b/include/pcm_plugin.h
index ad14e7b..3061205 100644
--- a/include/pcm_plugin.h
+++ b/include/pcm_plugin.h
@@ -30,6 +30,7 @@
  */
 
 #ifndef __ALSA_PCM_PLUGIN_H
+#define __ALSA_PCM_PLUGIN_H
 
 /**
  * \defgroup PCM_Plugins PCM Plugins
-- 
1.9.1


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2018-07-06 13:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 13:54 Guillaume Blanc [this message]
2018-07-06 15:09 ` Bad header guard in alsa-lib Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR10MB0293F65AACE42CF971B1AE2094470@DB5PR10MB0293.EURPRD10.PROD.OUTLOOK.COM \
    --to=guillaume.blanc@parrot.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.