All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@arm.linux.org.uk>
To: alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-sh@vger.kernel.org
Cc: Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH 03/10] clk: versatile: convert Integrator IM/PD-1 to use clkdev_add_table()
Date: Mon, 02 Mar 2015 17:06:16 +0000	[thread overview]
Message-ID: <E1YSTnM-0001Jc-LU@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20150302170538.GQ8656@n2100.arm.linux.org.uk>

We have always had an efficient way of registering a table of clock
lookups - it's called clkdev_add_table().  However, some people seem
to really love writing inefficient and unnecessary code.

Convert Integrator IM-PD/1 to use the correct interface.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/clk/versatile/clk-impd1.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c
index 1cc1330dc570..13e912e132d2 100644
--- a/drivers/clk/versatile/clk-impd1.c
+++ b/drivers/clk/versatile/clk-impd1.c
@@ -89,7 +89,6 @@ void integrator_impd1_clk_init(void __iomem *base, unsigned int id)
 	struct impd1_clk *imc;
 	struct clk *clk;
 	struct clk *pclk;
-	int i;
 
 	if (id > 3) {
 		pr_crit("no more than 4 LMs can be attached\n");
@@ -150,8 +149,7 @@ void integrator_impd1_clk_init(void __iomem *base, unsigned int id)
 	imc->clks[13] = clkdev_alloc(pclk, "apb_pclk", "lm%x:00600", id);
 	imc->clks[14] = clkdev_alloc(clk, NULL, "lm%x:00600", id);
 
-	for (i = 0; i < ARRAY_SIZE(imc->clks); i++)
-		clkdev_add(imc->clks[i]);
+	clkdev_add_table(imc->clks, ARRAY_SIZE(imc->clks));
 }
 EXPORT_SYMBOL_GPL(integrator_impd1_clk_init);
 
-- 
1.8.3.1


WARNING: multiple messages have this Message-ID (diff)
From: rmk+kernel@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] clk: versatile: convert Integrator IM/PD-1 to use clkdev_add_table()
Date: Mon, 02 Mar 2015 17:06:16 +0000	[thread overview]
Message-ID: <E1YSTnM-0001Jc-LU@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20150302170538.GQ8656@n2100.arm.linux.org.uk>

We have always had an efficient way of registering a table of clock
lookups - it's called clkdev_add_table().  However, some people seem
to really love writing inefficient and unnecessary code.

Convert Integrator IM-PD/1 to use the correct interface.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/clk/versatile/clk-impd1.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c
index 1cc1330dc570..13e912e132d2 100644
--- a/drivers/clk/versatile/clk-impd1.c
+++ b/drivers/clk/versatile/clk-impd1.c
@@ -89,7 +89,6 @@ void integrator_impd1_clk_init(void __iomem *base, unsigned int id)
 	struct impd1_clk *imc;
 	struct clk *clk;
 	struct clk *pclk;
-	int i;
 
 	if (id > 3) {
 		pr_crit("no more than 4 LMs can be attached\n");
@@ -150,8 +149,7 @@ void integrator_impd1_clk_init(void __iomem *base, unsigned int id)
 	imc->clks[13] = clkdev_alloc(pclk, "apb_pclk", "lm%x:00600", id);
 	imc->clks[14] = clkdev_alloc(clk, NULL, "lm%x:00600", id);
 
-	for (i = 0; i < ARRAY_SIZE(imc->clks); i++)
-		clkdev_add(imc->clks[i]);
+	clkdev_add_table(imc->clks, ARRAY_SIZE(imc->clks));
 }
 EXPORT_SYMBOL_GPL(integrator_impd1_clk_init);
 
-- 
1.8.3.1

  parent reply	other threads:[~2015-03-02 17:06 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 17:05 [PATCH 00/10] initial clkdev cleanups Russell King - ARM Linux
2015-03-02 17:05 ` Russell King - ARM Linux
2015-03-02 17:05 ` Russell King - ARM Linux
2015-03-02 17:06 ` [PATCH 01/10] media: omap3isp: remove unused clkdev Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 22:33   ` Laurent Pinchart
2015-03-02 22:33     ` Laurent Pinchart
2015-03-02 22:33     ` Laurent Pinchart
2015-03-02 22:53     ` Sakari Ailus
2015-03-02 22:53       ` Sakari Ailus
2015-03-02 22:53       ` Sakari Ailus
2015-03-02 23:54       ` Russell King - ARM Linux
2015-03-02 23:54         ` Russell King - ARM Linux
2015-03-02 23:54         ` Russell King - ARM Linux
2015-03-03  0:39         ` Laurent Pinchart
2015-03-03  0:39           ` Laurent Pinchart
2015-03-03  0:39           ` Laurent Pinchart
2015-03-03 22:09           ` Sakari Ailus
2015-03-03 22:09             ` Sakari Ailus
2015-03-03 22:09             ` Sakari Ailus
2015-03-03 23:09         ` Sakari Ailus
2015-03-03 23:09           ` Sakari Ailus
2015-03-03 23:09           ` Sakari Ailus
2015-03-02 17:06 ` [PATCH 02/10] SH: use clkdev_add_table() Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:18   ` Geert Uytterhoeven
2015-03-02 17:18     ` Geert Uytterhoeven
2015-03-02 17:18     ` Geert Uytterhoeven
2015-03-02 17:06 ` Russell King [this message]
2015-03-02 17:06   ` [PATCH 03/10] clk: versatile: convert Integrator IM/PD-1 to " Russell King
2015-03-02 17:06 ` [PATCH 04/10] ARM: lpc32xx: convert " Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:06 ` [PATCH 05/10] clkdev: add clkdev_create() helper Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:22   ` Geert Uytterhoeven
2015-03-02 17:22     ` Geert Uytterhoeven
2015-03-02 17:22     ` Geert Uytterhoeven
2015-03-02 17:46     ` Russell King - ARM Linux
2015-03-02 17:46       ` Russell King - ARM Linux
2015-03-02 17:46       ` Russell King - ARM Linux
2015-03-02 20:36       ` Geert Uytterhoeven
2015-03-02 20:36         ` Geert Uytterhoeven
2015-03-02 20:36         ` Geert Uytterhoeven
2015-03-02 19:07   ` Stephen Boyd
2015-03-02 19:07     ` Stephen Boyd
2015-03-02 19:07     ` Stephen Boyd
2015-03-02 21:01     ` Russell King - ARM Linux
2015-03-02 21:01       ` Russell King - ARM Linux
2015-03-02 21:01       ` Russell King - ARM Linux
2015-03-02 21:54       ` Stephen Boyd
2015-03-02 21:54         ` Stephen Boyd
2015-03-02 21:54         ` Stephen Boyd
2015-03-02 17:06 ` [PATCH 06/10] ASOC: migor: use clkdev_create() Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:29   ` Mark Brown
2015-03-02 17:29     ` Mark Brown
2015-03-02 17:29     ` Mark Brown
2015-03-02 17:06 ` [PATCH 07/10] clk: s2mps11: " Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:06 ` [PATCH 08/10] ARM: orion: " Russell King
2015-03-02 17:06   ` Russell King
2015-03-03 10:25   ` Thomas Petazzoni
2015-03-03 10:25     ` Thomas Petazzoni
2015-03-03 10:25     ` Thomas Petazzoni
2015-03-02 17:06 ` [PATCH 09/10] ARM: omap2: " Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:06 ` [PATCH 10/10] ARM: omap2: use clkdev_add_alias() Russell King
2015-03-02 17:06   ` Russell King
2015-03-02 17:06   ` Russell King
2015-03-03  0:13   ` Tony Lindgren
2015-03-03  0:13     ` Tony Lindgren
2015-03-03  0:13     ` Tony Lindgren
2015-03-03  0:13     ` Tony Lindgren
2015-03-02 21:50 ` [PATCH 00/10] initial clkdev cleanups Stephen Boyd
2015-03-02 21:50   ` Stephen Boyd
2015-03-02 21:50   ` Stephen Boyd
2015-03-03 15:56   ` Andy Shevchenko
2015-03-03 15:56     ` Andy Shevchenko
2015-03-03 15:56     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1YSTnM-0001Jc-LU@rmk-PC.arm.linux.org.uk \
    --to=rmk+kernel@arm.linux.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.