All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: John Keeping <john@metanate.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Applied "ASoC: rockchip: i2s: remove unused variables" to the asoc tree
Date: Wed, 09 Dec 2015 20:44:00 +0000	[thread overview]
Message-ID: <E1a6lai-00045b-Rj@debutante> (raw)
In-Reply-To: <1449657147-26959-2-git-send-email-john@metanate.com>

The patch

   ASoC: rockchip: i2s: remove unused variables

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 5938448b99275cba95167c3f9d39ca9225fdad38 Mon Sep 17 00:00:00 2001
From: John Keeping <john@metanate.com>
Date: Wed, 9 Dec 2015 10:32:27 +0000
Subject: [PATCH] ASoC: rockchip: i2s: remove unused variables

The previous commit removed the only use of these variables.

Signed-off-by: John Keeping <john@metanate.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/rockchip/rockchip_i2s.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index acc6225d8d9d..8b0a588ed622 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -34,13 +34,6 @@ struct rk_i2s_dev {
 
 	struct regmap *regmap;
 
-/*
- * Used to indicate the tx/rx status.
- * I2S controller hopes to start the tx and rx together,
- * also to stop them when they are both try to stop.
-*/
-	bool tx_start;
-	bool rx_start;
 	bool is_master_mode;
 };
 
@@ -84,11 +77,7 @@ static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on)
 		regmap_update_bits(i2s->regmap, I2S_XFER,
 				   I2S_XFER_TXS_START,
 				   I2S_XFER_TXS_START);
-
-		i2s->tx_start = true;
 	} else {
-		i2s->tx_start = false;
-
 		regmap_update_bits(i2s->regmap, I2S_DMACR,
 				   I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_DISABLE);
 
@@ -126,11 +115,7 @@ static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on)
 		regmap_update_bits(i2s->regmap, I2S_XFER,
 				   I2S_XFER_RXS_START,
 				   I2S_XFER_RXS_START);
-
-		i2s->rx_start = true;
 	} else {
-		i2s->rx_start = false;
-
 		regmap_update_bits(i2s->regmap, I2S_DMACR,
 				   I2S_DMACR_RDE_ENABLE, I2S_DMACR_RDE_DISABLE);
 
-- 
2.6.2

  reply	other threads:[~2015-12-09 20:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 10:32 [PATCH 1/2] ASoC: rockchip: i2s: separate capture and playback John Keeping
2015-12-09 10:32 ` John Keeping
2015-12-09 10:32 ` [PATCH 2/2] ASoC: rockchip: i2s: remove unused variables John Keeping
2015-12-09 10:32   ` John Keeping
2015-12-09 10:32   ` John Keeping
2015-12-09 20:44   ` Mark Brown [this message]
2015-12-09 20:44 ` Applied "ASoC: rockchip: i2s: separate capture and playback" to the asoc tree Mark Brown
2016-04-29 14:55 ` [PATCH 1/2] ASoC: rockchip: i2s: separate capture and playback Enric Balletbo Serra
2016-04-29 14:59 ` Enric Balletbo Serra
2016-04-29 14:59   ` Enric Balletbo Serra
2016-04-29 14:59   ` Enric Balletbo Serra
2016-04-30  7:00   ` John Keeping
2016-04-30  7:00     ` John Keeping
2016-04-30  7:00     ` John Keeping
2016-05-02  9:13     ` Enric Balletbo Serra
2016-05-02  9:13       ` Enric Balletbo Serra
2016-05-02  9:13       ` Enric Balletbo Serra
2016-05-03  4:12     ` sugar
2016-05-03  4:12       ` sugar
2016-05-03  4:12       ` sugar
2016-05-03  9:16       ` [alsa-devel] " Enric Balletbo Serra
2016-05-03  9:16         ` Enric Balletbo Serra
2016-05-03  9:16         ` Enric Balletbo Serra
2016-05-03  9:43         ` [alsa-devel] " John Keeping
2016-05-03  9:43           ` John Keeping
2016-05-03  9:43           ` John Keeping
2016-05-03 10:21           ` Enric Balletbo Serra
2016-05-03 10:21             ` Enric Balletbo Serra
2016-05-03 10:21             ` Enric Balletbo Serra
2016-05-03 10:32             ` John Keeping
2016-05-03 10:32               ` John Keeping
2016-05-03 10:32               ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1a6lai-00045b-Rj@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=john@metanate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.