All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: alsa-devel@alsa-project.org, Xiubo Li <Xiubo.Lee@gmail.com>,
	Timur Tabi <timur@tabi.org>, Liam Girdwood <lgirdwood@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>
Subject: Applied "ASoC: fsl_spdif: use flat regmap cache" to the asoc tree
Date: Wed, 21 Sep 2016 13:56:02 +0100	[thread overview]
Message-ID: <E1bmh4E-0001Xr-1h@debutante> (raw)
In-Reply-To: <20160919193029.8119-3-marex@denx.de>

The patch

   ASoC: fsl_spdif: use flat regmap cache

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 35ddb15757cd1c817e424c6252d2f11f268cfebf Mon Sep 17 00:00:00 2001
From: Marek Vasut <marex@denx.de>
Date: Mon, 19 Sep 2016 21:30:27 +0200
Subject: [PATCH] ASoC: fsl_spdif: use flat regmap cache

Same as commit ce492b3b8f99cf9d2f807ec22d8805c996a09503
Subject: drm/fsl-dcu: use flat regmap cache

Using flat regmap cache instead of RB-tree to avoid the following
lockdep warning on driver load:
WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2871 lockdep_trace_alloc+0x104/0x128
DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))

The RB-tree regmap cache needs to allocate new space on first
writes. However, allocations in an atomic context (e.g. when a
spinlock is held) are not allowed. The function regmap_write
calls map->lock, which acquires a spinlock in the fast_io case.
Since the driver uses MMIO, the regmap bus of type regmap_mmio
is being used which has fast_io set to true.

Signed-off-by: Marek Vasut <marex@denx.de>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/fsl/fsl_spdif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index beec7934a265..1ff467c9598a 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1103,7 +1103,7 @@ static const struct regmap_config fsl_spdif_regmap_config = {
 	.readable_reg = fsl_spdif_readable_reg,
 	.volatile_reg = fsl_spdif_volatile_reg,
 	.writeable_reg = fsl_spdif_writeable_reg,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_FLAT,
 };
 
 static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv *spdif_priv,
-- 
2.8.1

  reply	other threads:[~2016-09-21 12:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 19:30 [PATCH 1/5] ASoC: fsl_asrc: use flat regmap cache Marek Vasut
2016-09-19 19:30 ` [PATCH 2/5] ASoC: fsl_esai: " Marek Vasut
2016-09-21 12:56   ` Applied "ASoC: fsl_esai: use flat regmap cache" to the asoc tree Mark Brown
2016-09-19 19:30 ` [PATCH 3/5] ASoC: fsl_spdif: use flat regmap cache Marek Vasut
2016-09-21 12:56   ` Mark Brown [this message]
2016-09-19 19:30 ` [PATCH 4/5] ASoC: fsl_ssi: " Marek Vasut
2016-09-21 12:55   ` Applied "ASoC: fsl_ssi: use flat regmap cache" to the asoc tree Mark Brown
2016-09-21 16:28   ` [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache Maciej S. Szmigiero
2016-09-21 19:32     ` Marek Vasut
2016-09-21 22:18       ` Maciej S. Szmigiero
2016-09-21 22:45         ` Marek Vasut
2016-09-21 23:33           ` Maciej S. Szmigiero
2016-09-22 10:45             ` Mark Brown
2016-09-22 14:37               ` Maciej S. Szmigiero
2016-09-22 15:27                 ` Marek Vasut
2016-09-22 23:38                   ` Maciej S. Szmigiero
2016-09-26 19:13                   ` Mark Brown
2016-09-26 19:25                     ` Marek Vasut
2016-09-26 21:03                       ` Mark Brown
2016-09-27 23:23                       ` Maciej S. Szmigiero
2016-09-27 23:29                         ` Marek Vasut
2016-09-28  0:04                           ` Maciej S. Szmigiero
2016-09-28 19:09                             ` Marek Vasut
2016-09-22 15:23             ` Marek Vasut
2016-09-19 19:30 ` [PATCH 5/5] ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config Marek Vasut
2016-09-20 17:56   ` Mark Brown
2016-09-20 18:23     ` Marek Vasut
2016-09-21 12:55   ` Applied "ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config" to the asoc tree Mark Brown
2016-09-20  6:50 ` [PATCH 1/5] ASoC: fsl_asrc: use flat regmap cache Nicolin Chen
2016-09-20 18:07 ` Fabio Estevam
2016-09-21 12:56 ` Applied "ASoC: fsl_asrc: use flat regmap cache" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1bmh4E-0001Xr-1h@debutante \
    --to=broonie@kernel.org \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=fabio.estevam@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=marex@denx.de \
    --cc=nicoleotsuka@gmail.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.