All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
	broonie@kernel.org
Subject: Applied "ASoC: max98090: remove superflous check for 'micbias'" to the asoc tree
Date: Thu, 15 Dec 2016 12:21:40 +0000	[thread overview]
Message-ID: <E1cHV2a-0000tL-S6@debutante> (raw)
In-Reply-To: <1481218297-17568-7-git-send-email-vinod.koul@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]

The patch

   ASoC: max98090: remove superflous check for 'micbias'

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 1c445a42c48754bb5f821478517ef1b9f861217a Mon Sep 17 00:00:00 2001
From: Vinod Koul <vinod.koul@intel.com>
Date: Thu, 8 Dec 2016 23:01:29 +0530
Subject: [PATCH] ASoC: max98090: remove superflous check for 'micbias'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In max98090_probe(), code checks for micbias being out of range. The
'micbias' variable in unsigned and checked against M98090_MBVSEL_2V2 which
is zero, so remove this check.

sound/soc/codecs/max98090.c: In function ‘max98090_probe’:
sound/soc/codecs/max98090.c:2459:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  } else if (micbias < M98090_MBVSEL_2V2 || micbias > M98090_MBVSEL_2V8) {

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/max98090.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index 584aab83e478..66828480d484 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -2456,7 +2456,7 @@ static int max98090_probe(struct snd_soc_codec *codec)
 	if (err) {
 		micbias = M98090_MBVSEL_2V8;
 		dev_info(codec->dev, "use default 2.8v micbias\n");
-	} else if (micbias < M98090_MBVSEL_2V2 || micbias > M98090_MBVSEL_2V8) {
+	} else if (micbias > M98090_MBVSEL_2V8) {
 		dev_err(codec->dev, "micbias out of range 0x%x\n", micbias);
 		micbias = M98090_MBVSEL_2V8;
 	}
-- 
2.11.0


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2016-12-15 12:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 17:31 [PATCH 00/14] ASoC: Compile fixes with W=1 Vinod Koul
2016-12-08 17:31 ` [PATCH 01/14] ASoC: Intel: Skylake: remove unused 'ret' Vinod Koul
2016-12-15 12:21   ` Applied "ASoC: Intel: Skylake: remove unused 'ret'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 02/14] ASoC: Intel: sst: remove unused 'msg_high' Vinod Koul
2016-12-15 12:21   ` Applied "ASoC: Intel: sst: remove unused 'msg_high'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 03/14] ASoC: Intel: sst: remove unused 'ops' Vinod Koul
2016-12-15 12:21   ` Applied "ASoC: Intel: sst: remove unused 'ops'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 04/14] ASoC: topology: remove unused 'err' Vinod Koul
2016-12-15 12:21   ` Applied "ASoC: topology: remove unused 'err'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 05/14] ASoC: hdac_hdmi: remove unused 'dai_map' Vinod Koul
2016-12-15 12:21   ` Applied "ASoC: hdac_hdmi: remove unused 'dai_map'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 06/14] ASoC: max98090: remove superflous check for 'micbias' Vinod Koul
2016-12-15 12:21   ` Mark Brown [this message]
2016-12-08 17:31 ` [PATCH 07/14] ASoC: AMD: remove unused ‘dma_buffer’ Vinod Koul
2016-12-08 17:31 ` [PATCH 08/14] ASoC: adau17x1: remove unused ‘ret’ Vinod Koul
2016-12-08 17:31 ` [PATCH 09/14] ASoC: max9867: " Vinod Koul
2016-12-08 22:48   ` Fabio Estevam
2016-12-09  6:56     ` Vinod Koul
2016-12-15 11:22       ` Mark Brown
2016-12-08 17:31 ` [PATCH 10/14] ASoC: pcm3168a: remove unused ‘format’ Vinod Koul
2016-12-08 17:31 ` [PATCH 11/14] ASoC: img: " Vinod Koul
2016-12-08 17:31 ` [PATCH 12/14] ASoC: Intel: sst: remove unused ‘ret_val’ Vinod Koul
2016-12-08 17:31 ` [PATCH 13/14] ASoC: samsung: smdk_wm8580: remove unused ‘bfs’ Vinod Koul
2016-12-08 17:31 ` [PATCH 14/14] ASoC: zx296702-i2s: remove unused ‘format’ Vinod Koul
2016-12-09  2:47   ` Jun Nie
2016-12-15 11:36     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1cHV2a-0000tL-S6@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.