All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
Cc: Harsha Priya <harshapriya.n@intel.com>,
	tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org,
	vinod.koul@intel.com
Subject: Applied "ASoC: Intel: Use MCLK instead of BLCK as the sysclock for RT5514 codec on kabylake platform" to the asoc tree
Date: Fri, 28 Jul 2017 13:43:49 +0100	[thread overview]
Message-ID: <E1db4cP-0005hc-CX@finisterre> (raw)
In-Reply-To: <1501102065-11083-3-git-send-email-harshapriya.n@intel.com>

The patch

   ASoC: Intel: Use MCLK instead of BLCK as the sysclock for RT5514 codec on kabylake platform

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 6512dd4dcf640412637ece8a412e83c3a0046d2f Mon Sep 17 00:00:00 2001
From: Harsha Priya N <harshapriya.n@intel.com>
Date: Thu, 27 Jul 2017 17:41:26 -0700
Subject: [PATCH] ASoC: Intel: Use MCLK instead of BLCK as the sysclock for
 RT5514 codec on kabylake platform

This patch fixes the pop noise in dmic recording using rt5514 on kabylake platform.
This patch enables the rt5514 to use MCLK instead of BLCK as the sysclock which fixes
the pop noise.

Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
index cfde894d250f..cfd89ca6a18d 100644
--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
@@ -351,19 +351,10 @@ static int kabylake_ssp0_hw_params(struct snd_pcm_substream *substream,
 				return ret;
 			}
 
-			ret = snd_soc_dai_set_pll(codec_dai, 0,
-				RT5514_PLL1_S_BCLK, RT5514_AIF1_BCLK_FREQ,
-						RT5514_AIF1_SYSCLK_FREQ);
-			if (ret < 0) {
-				dev_err(rtd->dev, "set bclk err: %d\n", ret);
-				return ret;
-			}
-
 			ret = snd_soc_dai_set_sysclk(codec_dai,
-				RT5514_SCLK_S_PLL1, RT5514_AIF1_SYSCLK_FREQ,
-							SND_SOC_CLOCK_IN);
+				RT5514_SCLK_S_MCLK, 24576000, SND_SOC_CLOCK_IN);
 			if (ret < 0) {
-				dev_err(rtd->dev, "set sclk err: %d\n", ret);
+				dev_err(rtd->dev, "set sysclk err: %d\n", ret);
 				return ret;
 			}
 		}
-- 
2.13.2

  parent reply	other threads:[~2017-07-28 12:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 20:47 [v2 0/3] ASoC: Intel: Fixes in Kabylake machine driver for clear playback and recording Harsha Priya
2017-07-26 20:47 ` [v2 1/3] ASoC: Intel: Fix cracking noise in rt5663 headphones for kabylake platform Harsha Priya
2017-07-27  2:40   ` Vinod Koul
2017-07-28  0:42     ` N, Harshapriya
2017-07-28 12:43   ` Applied "ASoC: Intel: Enabling ASRC for RT5663 codec on kabylake platform" to the asoc tree Mark Brown
2017-07-26 20:47 ` [v2 2/3] ASoC: Intel: Fix pop noise of dmic recording in kabylake platform using rt5514 Harsha Priya
2017-07-27  2:42   ` Vinod Koul
2017-07-28 12:43   ` Mark Brown [this message]
2017-07-26 20:47 ` [v2 3/3] ASoC: Intel: Enabling 4 slot IV feedback for max98927 on Kabylake platform Harsha Priya
2017-07-28 12:43   ` Applied "ASoC: Intel: Enabling 4 slot IV feedback for max98927 on Kabylake platform" to the asoc tree Mark Brown
2017-07-27  2:38 ` [v2 0/3] ASoC: Intel: Fixes in Kabylake machine driver for clear playback and recording Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1db4cP-0005hc-CX@finisterre \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=harshapriya.n@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.