From: Mark Brown <broonie@kernel.org> To: Nicolin Chen <nicoleotsuka@gmail.com> Cc: alsa-devel@alsa-project.org, arnaud.mouiche@invoxia.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, mail@maciej.szmigiero.name, caleb@crome.org, timur@tabi.org, broonie@kernel.org, kernel@pengutronix.de, lukma@denx.de, fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org Subject: Applied "ASoC: fsl_ssi: Rename scr_val to scr" to the asoc tree Date: Tue, 19 Dec 2017 10:59:45 +0000 [thread overview] Message-ID: <E1eRFcf-0000tY-5V@debutante> (raw) In-Reply-To: <1513207108-30430-9-git-send-email-nicoleotsuka@gmail.com> The patch ASoC: fsl_ssi: Rename scr_val to scr has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ff4adb090066c1636a43b88a497c34d2bd2312ec Mon Sep 17 00:00:00 2001 From: Nicolin Chen <nicoleotsuka@gmail.com> Date: Sun, 17 Dec 2017 18:52:07 -0800 Subject: [PATCH] ASoC: fsl_ssi: Rename scr_val to scr Simplify the variable name. This reduces one over-80-character line. Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Acked-by: Timur Tabi <timur@tabi.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 237302fb9279..af3ba718d4bb 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -451,12 +451,12 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, struct regmap *regs = ssi->regs; struct fsl_ssi_reg_val *avals; int nr_active_streams; - u32 scr_val; + u32 scr; int keep_active; - regmap_read(regs, REG_SSI_SCR, &scr_val); + regmap_read(regs, REG_SSI_SCR, &scr); - nr_active_streams = !!(scr_val & SSI_SCR_TE) + !!(scr_val & SSI_SCR_RE); + nr_active_streams = !!(scr & SSI_SCR_TE) + !!(scr & SSI_SCR_RE); if (nr_active_streams - 1 > 0) keep_active = 1; @@ -810,11 +810,11 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream, unsigned int sample_size = params_width(hw_params); u32 wl = SSI_SxCCR_WL(sample_size); int ret; - u32 scr_val; + u32 scr; int enabled; - regmap_read(regs, REG_SSI_SCR, &scr_val); - enabled = scr_val & SSI_SCR_SSIEN; + regmap_read(regs, REG_SSI_SCR, &scr); + enabled = scr & SSI_SCR_SSIEN; /* * SSI is properly configured if it is enabled and running in -- 2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Nicolin Chen <nicoleotsuka@gmail.com> Cc: Maciej S. Szmigiero <mail@maciej.szmigiero.name>, Timur Tabi <timur@tabi.org>, Mark Brown <broonie@kernel.org>, broonie@kernel.org, mail@maciej.szmigiero.name, timur@tabi.org, kernel@pengutronix.de, lgirdwood@gmail.com, alsa-devel@alsa-project.org, caleb@crome.org, linux-kernel@vger.kernel.org, arnaud.mouiche@invoxia.com, lukma@denx.de, fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: fsl_ssi: Rename scr_val to scr" to the asoc tree Date: Tue, 19 Dec 2017 10:59:45 +0000 [thread overview] Message-ID: <E1eRFcf-0000tY-5V@debutante> (raw) In-Reply-To: <1513207108-30430-9-git-send-email-nicoleotsuka@gmail.com> The patch ASoC: fsl_ssi: Rename scr_val to scr has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ff4adb090066c1636a43b88a497c34d2bd2312ec Mon Sep 17 00:00:00 2001 From: Nicolin Chen <nicoleotsuka@gmail.com> Date: Sun, 17 Dec 2017 18:52:07 -0800 Subject: [PATCH] ASoC: fsl_ssi: Rename scr_val to scr Simplify the variable name. This reduces one over-80-character line. Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Reviewed-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Acked-by: Timur Tabi <timur@tabi.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/fsl/fsl_ssi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 237302fb9279..af3ba718d4bb 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -451,12 +451,12 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, struct regmap *regs = ssi->regs; struct fsl_ssi_reg_val *avals; int nr_active_streams; - u32 scr_val; + u32 scr; int keep_active; - regmap_read(regs, REG_SSI_SCR, &scr_val); + regmap_read(regs, REG_SSI_SCR, &scr); - nr_active_streams = !!(scr_val & SSI_SCR_TE) + !!(scr_val & SSI_SCR_RE); + nr_active_streams = !!(scr & SSI_SCR_TE) + !!(scr & SSI_SCR_RE); if (nr_active_streams - 1 > 0) keep_active = 1; @@ -810,11 +810,11 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream, unsigned int sample_size = params_width(hw_params); u32 wl = SSI_SxCCR_WL(sample_size); int ret; - u32 scr_val; + u32 scr; int enabled; - regmap_read(regs, REG_SSI_SCR, &scr_val); - enabled = scr_val & SSI_SCR_SSIEN; + regmap_read(regs, REG_SSI_SCR, &scr); + enabled = scr & SSI_SCR_SSIEN; /* * SSI is properly configured if it is enabled and running in -- 2.15.1
next prev parent reply other threads:[~2017-12-19 10:59 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-13 23:18 [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen 2017-12-13 23:18 ` Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen 2017-12-13 23:18 ` Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen 2017-12-13 23:18 ` Nicolin Chen 2017-12-16 4:43 ` Timur Tabi 2017-12-16 4:43 ` Timur Tabi [not found] ` <CAGoOwPSqf4oKB=gZdD8=W=q9y=CcpjYyUuWkmfm7dQc+P6QDmw@mail.gmail.com> 2017-12-16 6:10 ` Nicolin Chen 2017-12-16 6:10 ` Nicolin Chen 2017-12-16 16:27 ` Timur Tabi 2017-12-16 17:34 ` Nicolin Chen 2017-12-16 17:15 ` Timur Tabi 2017-12-16 17:30 ` Caleb Crome 2017-12-16 17:30 ` Caleb Crome 2017-12-16 17:47 ` Timur Tabi 2017-12-16 17:49 ` Nicolin Chen 2017-12-16 17:49 ` Nicolin Chen 2017-12-16 18:31 ` Timur Tabi 2017-12-16 18:31 ` Timur Tabi 2017-12-16 19:19 ` Nicolin Chen 2017-12-16 19:19 ` Nicolin Chen 2017-12-16 19:17 ` Nicolin Chen 2017-12-16 19:17 ` Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen 2017-12-13 23:18 ` Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen 2017-12-13 23:18 ` Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen 2017-12-13 23:18 ` Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 08/11] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen 2017-12-19 10:59 ` Mark Brown [this message] 2017-12-19 10:59 ` Applied "ASoC: fsl_ssi: Rename scr_val to scr" to the asoc tree Mark Brown 2017-12-13 23:18 ` [PATCH v3 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen 2017-12-13 23:18 ` [PATCH v3 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen 2017-12-16 4:53 ` [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level Timur Tabi 2017-12-16 6:56 ` Nicolin Chen 2017-12-16 6:56 ` Nicolin Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E1eRFcf-0000tY-5V@debutante \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=arnaud.mouiche@invoxia.com \ --cc=caleb@crome.org \ --cc=fabio.estevam@nxp.com \ --cc=kernel@pengutronix.de \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lukma@denx.de \ --cc=mail@maciej.szmigiero.name \ --cc=nicoleotsuka@gmail.com \ --cc=timur@tabi.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.