All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	lgirdwood@gmail.com, stuarth@opensource.cirrus.com,
	rf@opensource.cirrus.com, broonie@kernel.org
Subject: Applied "ASoC: wm_adsp: Take prefix into account in control name length" to the asoc tree
Date: Thu, 19 Jul 2018 17:57:45 +0100	[thread overview]
Message-ID: <E1fgCFN-0005WS-7s@debutante> (raw)
In-Reply-To: <20180719105039.28312-2-ckeepax@opensource.cirrus.com>

The patch

   ASoC: wm_adsp: Take prefix into account in control name length

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b7ede5af62ab6bfad0980fad58e82d3fb56866df Mon Sep 17 00:00:00 2001
From: Charles Keepax <ckeepax@opensource.cirrus.com>
Date: Thu, 19 Jul 2018 11:50:36 +0100
Subject: [PATCH] ASoC: wm_adsp: Take prefix into account in control name
 length

Currently when creating ALSA control names for the DSP the length of any
prefix applied to the CODEC is not taken into account. Whilst this is
mostly harmless it does result in ALSA doing the truncation of the
control names and printing a warning. It is better to have the driver do
the truncation so it can truncate from the start of parameter name
itself to give a greater chance of the result maintain a unique name.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/wm_adsp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 99108d18de8d..eec73c98a141 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1343,6 +1343,9 @@ static int wm_adsp_create_control(struct wm_adsp *dsp,
 			int avail = SNDRV_CTL_ELEM_ID_NAME_MAXLEN - ret - 2;
 			int skip = 0;
 
+			if (dsp->component->name_prefix)
+				avail -= strlen(dsp->component->name_prefix) + 1;
+
 			if (subname_len > avail)
 				skip = subname_len - avail;
 
-- 
2.18.0

  reply	other threads:[~2018-07-19 16:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 10:50 [PATCH 1/5] ASoC: wm_adsp: Correct algorithm list allocation size Charles Keepax
2018-07-19 10:50 ` [PATCH 2/5] ASoC: wm_adsp: Take prefix into account in control name length Charles Keepax
2018-07-19 16:57   ` Mark Brown [this message]
2018-07-19 10:50 ` [PATCH 3/5] ASoC: wm_adsp: Ensure DSP boot work complete before preloader_put return Charles Keepax
2018-07-19 16:58   ` Applied "ASoC: wm_adsp: Ensure DSP boot work complete before preloader_put return" to the asoc tree Mark Brown
2018-07-19 10:50 ` [PATCH 4/5] ASoC: wm_adsp: Allow up to 8 channels for voice control Charles Keepax
2018-07-19 16:57   ` Applied "ASoC: wm_adsp: Allow up to 8 channels for voice control" to the asoc tree Mark Brown
2018-07-19 10:50 ` [PATCH 5/5] ASoC: wm_adsp: Parse HOST_BUFFER controls Charles Keepax
2018-07-19 16:57   ` Applied "ASoC: wm_adsp: Parse HOST_BUFFER controls" to the asoc tree Mark Brown
2018-07-19 16:57 ` Applied "ASoC: wm_adsp: Correct algorithm list allocation size" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1fgCFN-0005WS-7s@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    --cc=stuarth@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.