All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@armlinux.org.uk>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH 05/12] fs/adfs: use %pV for error messages
Date: Tue, 04 Jun 2019 14:49:47 +0100	[thread overview]
Message-ID: <E1hY9ox-00084j-5S@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20190604111943.GA15281@rmk-PC.armlinux.org.uk>

Rather than using vsnprintf() with a temporary buffer on the stack, use
%pV to print error messages.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 fs/adfs/super.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/adfs/super.c b/fs/adfs/super.c
index 26b4b66df2c7..f35db5d64c17 100644
--- a/fs/adfs/super.c
+++ b/fs/adfs/super.c
@@ -24,16 +24,18 @@
 
 void __adfs_error(struct super_block *sb, const char *function, const char *fmt, ...)
 {
-	char error_buf[128];
+	struct va_format vaf;
 	va_list args;
 
 	va_start(args, fmt);
-	vsnprintf(error_buf, sizeof(error_buf), fmt, args);
-	va_end(args);
+	vaf.fmt = fmt;
+	vaf.va = &args;
 
-	printk(KERN_CRIT "ADFS-fs error (device %s)%s%s: %s\n",
+	printk(KERN_CRIT "ADFS-fs error (device %s)%s%s: %pV\n",
 		sb->s_id, function ? ": " : "",
-		function ? function : "", error_buf);
+		function ? function : "", &vaf);
+
+	va_end(args);
 }
 
 static int adfs_checkdiscrecord(struct adfs_discrecord *dr)
-- 
2.7.4


  parent reply	other threads:[~2019-06-04 13:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190604111943.GA15281@rmk-PC.armlinux.org.uk>
2019-06-04 13:49 ` [PATCH 01/12] fs/adfs: correct disc record structure Russell King
2019-06-04 13:49 ` [PATCH 02/12] fs/adfs: add helper to get discrecord from map Russell King
2019-06-04 13:49 ` [PATCH 03/12] fs/adfs: add helper to get filesystem size Russell King
2019-06-04 13:49 ` [PATCH 04/12] fs/adfs: use format_version from disc_record Russell King
2019-06-04 13:49 ` Russell King [this message]
2019-06-04 13:49 ` [PATCH 06/12] fs/adfs: clean up error message printing Russell King
2019-06-04 13:49 ` [PATCH 07/12] fs/adfs: clean up indirect disc addresses and fragment IDs Russell King
2019-06-04 13:50 ` [PATCH 08/12] fs/adfs: super: correct superblock flags Russell King
2019-06-04 13:50 ` [PATCH 09/12] fs/adfs: super: safely update options on remount Russell King
2019-06-04 13:50 ` [PATCH 10/12] fs/adfs: super: fix use-after-free bug Russell King
2019-06-04 13:50 ` [PATCH 11/12] fs/adfs: super: limit idlen according to directory type Russell King
2019-06-04 13:50 ` [PATCH 12/12] fs/adfs: add time stamp and file type helpers Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1hY9ox-00084j-5S@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.