From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH RFC net-next v2 01/10] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
Date: Wed, 23 Feb 2022 11:34:17 +0000 [thread overview]
Message-ID: <E1nMpuT-00AJoW-Dq@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YhYbpNsFROcSe4z+@shell.armlinux.org.uk>
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index f74f25f479ed..69abca77ea1a 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH RFC net-next v2 01/10] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
Date: Wed, 23 Feb 2022 11:34:17 +0000 [thread overview]
Message-ID: <E1nMpuT-00AJoW-Dq@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YhYbpNsFROcSe4z+@shell.armlinux.org.uk>
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index f74f25f479ed..69abca77ea1a 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);
--
2.30.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH RFC net-next v2 01/10] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
Date: Wed, 23 Feb 2022 11:34:17 +0000 [thread overview]
Message-ID: <E1nMpuT-00AJoW-Dq@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YhYbpNsFROcSe4z+@shell.armlinux.org.uk>
Discussing one of the tests in mt753x_phylink_validate() with Landen
Chao confirms that the "||" should be "&&". Fix this.
Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index f74f25f479ed..69abca77ea1a 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-23 11:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 11:33 [PATCH RFC net-next v2 0/7] net: dsa: mt7530: updates for phylink changes Russell King (Oracle)
2022-02-23 11:33 ` Russell King (Oracle)
2022-02-23 11:33 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle) [this message]
2022-02-23 11:34 ` [PATCH RFC net-next v2 01/10] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate() Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 13:12 ` Vladimir Oltean
2022-02-23 13:12 ` Vladimir Oltean
2022-02-23 13:12 ` Vladimir Oltean
2022-02-23 13:21 ` Russell King (Oracle)
2022-02-23 13:21 ` Russell King (Oracle)
2022-02-23 13:21 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 02/10] net: dsa: mt7530: 1G can also support 1000BASE-X link mode Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 03/10] net: dsa: mt7530: populate supported_interfaces and mac_capabilities Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 04/10] net: dsa: mt7530: remove interface checks Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 05/10] net: dsa: mt7530: drop use of phylink_helper_basex_speed() Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 06/10] net: dsa: mt7530: only indicate linkmodes that can be supported Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 07/10] net: dsa: mt7530: switch to use phylink_get_linkmodes() Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 08/10] net: dsa: mt7530: partially convert to phylink_pcs Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` [PATCH RFC net-next v2 09/10] net: dsa: mt7530: move autoneg handling to PCS validation Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:34 ` Russell King (Oracle)
2022-02-23 11:35 ` [PATCH RFC net-next v2 10/10] net: dsa: mt7530: mark as non-legacy Russell King (Oracle)
2022-02-23 11:35 ` Russell King (Oracle)
2022-02-23 11:35 ` Russell King (Oracle)
2022-03-03 9:21 ` [PATCH RFC net-next v2 0/7] net: dsa: mt7530: updates for phylink changes Russell King (Oracle)
2022-03-03 9:21 ` Russell King (Oracle)
2022-03-03 9:21 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nMpuT-00AJoW-Dq@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.