From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>, bcm-kernel-feedback-list@broadcom.com, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Byungho An <bh74.an@samsung.com>, Clark Wang <xiaoning.wang@nxp.com>, "David S. Miller" <davem@davemloft.net>, Doug Berger <opendmb@gmail.com>, Eric Dumazet <edumazet@google.com>, Florian Fainelli <florian.fainelli@broadcom.com>, Jakub Kicinski <kuba@kernel.org>, Jose Abreu <joabreu@synopsys.com>, Justin Chen <justin.chen@broadcom.com>, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>, Paolo Abeni <pabeni@redhat.com>, Shenwei Wang <shenwei.wang@nxp.com>, Vladimir Oltean <olteanv@gmail.com>, Wei Fang <wei.fang@nxp.com> Subject: [PATCH net-next 3/6] net: fec: remove eee_enabled/eee_active in fec_enet_get_eee() Date: Fri, 02 Feb 2024 09:33:54 +0000 [thread overview] Message-ID: <E1rVpvm-002Pe0-TV@rmk-PC.armlinux.org.uk> (raw) In-Reply-To: <Zby24IKSgzpvRDNF@shell.armlinux.org.uk> fec_enet_get_eee() sets edata->eee_active and edata->eee_enabled from its own copy, and then calls phy_ethtool_get_eee() which in turn will call genphy_c45_ethtool_get_eee(). genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active with its own interpretation from the PHYs settings and negotiation result. Therefore, setting these members in fec_enet_get_eee() is redundant. Remove this, and remove the setting of fep->eee.eee_active member which becomes a write-only variable. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/freescale/fec_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 63707e065141..38dcf0989e3f 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3140,7 +3140,6 @@ static int fec_enet_eee_mode_set(struct net_device *ndev, bool enable) p->tx_lpi_enabled = enable; p->eee_enabled = enable; - p->eee_active = enable; writel(sleep_cycle, fep->hwp + FEC_LPI_SLEEP); writel(wake_cycle, fep->hwp + FEC_LPI_WAKE); @@ -3160,8 +3159,6 @@ fec_enet_get_eee(struct net_device *ndev, struct ethtool_keee *edata) if (!netif_running(ndev)) return -ENETDOWN; - edata->eee_enabled = p->eee_enabled; - edata->eee_active = p->eee_active; edata->tx_lpi_timer = p->tx_lpi_timer; edata->tx_lpi_enabled = p->tx_lpi_enabled; -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>, bcm-kernel-feedback-list@broadcom.com, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Byungho An <bh74.an@samsung.com>, Clark Wang <xiaoning.wang@nxp.com>, "David S. Miller" <davem@davemloft.net>, Doug Berger <opendmb@gmail.com>, Eric Dumazet <edumazet@google.com>, Florian Fainelli <florian.fainelli@broadcom.com>, Jakub Kicinski <kuba@kernel.org>, Jose Abreu <joabreu@synopsys.com>, Justin Chen <justin.chen@broadcom.com>, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>, Paolo Abeni <pabeni@redhat.com>, Shenwei Wang <shenwei.wang@nxp.com>, Vladimir Oltean <olteanv@gmail.com>, Wei Fang <wei.fang@nxp.com> Subject: [PATCH net-next 3/6] net: fec: remove eee_enabled/eee_active in fec_enet_get_eee() Date: Fri, 02 Feb 2024 09:33:54 +0000 [thread overview] Message-ID: <E1rVpvm-002Pe0-TV@rmk-PC.armlinux.org.uk> (raw) In-Reply-To: <Zby24IKSgzpvRDNF@shell.armlinux.org.uk> fec_enet_get_eee() sets edata->eee_active and edata->eee_enabled from its own copy, and then calls phy_ethtool_get_eee() which in turn will call genphy_c45_ethtool_get_eee(). genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active with its own interpretation from the PHYs settings and negotiation result. Therefore, setting these members in fec_enet_get_eee() is redundant. Remove this, and remove the setting of fep->eee.eee_active member which becomes a write-only variable. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/freescale/fec_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 63707e065141..38dcf0989e3f 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3140,7 +3140,6 @@ static int fec_enet_eee_mode_set(struct net_device *ndev, bool enable) p->tx_lpi_enabled = enable; p->eee_enabled = enable; - p->eee_active = enable; writel(sleep_cycle, fep->hwp + FEC_LPI_SLEEP); writel(wake_cycle, fep->hwp + FEC_LPI_WAKE); @@ -3160,8 +3159,6 @@ fec_enet_get_eee(struct net_device *ndev, struct ethtool_keee *edata) if (!netif_running(ndev)) return -ENETDOWN; - edata->eee_enabled = p->eee_enabled; - edata->eee_active = p->eee_active; edata->tx_lpi_timer = p->tx_lpi_timer; edata->tx_lpi_enabled = p->tx_lpi_enabled; -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-02 9:34 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-02 9:33 [PATCH net-next 0/6] net: eee network driver cleanups Russell King (Oracle) 2024-02-02 9:33 ` Russell King (Oracle) 2024-02-02 9:33 ` [PATCH net-next 1/6] net: stmmac: remove eee_enabled/eee_active in stmmac_ethtool_op_get_eee() Russell King (Oracle) 2024-02-02 9:33 ` Russell King (Oracle) 2024-02-02 13:15 ` Andrew Lunn 2024-02-02 13:15 ` Andrew Lunn 2024-02-03 1:22 ` Florian Fainelli 2024-02-03 1:22 ` Florian Fainelli 2024-02-02 9:33 ` [PATCH net-next 2/6] net: sxgbe: remove eee_enabled/eee_active in sxgbe_get_eee() Russell King (Oracle) 2024-02-02 9:33 ` Russell King (Oracle) 2024-02-02 13:18 ` Andrew Lunn 2024-02-02 13:18 ` Andrew Lunn 2024-02-02 9:33 ` Russell King (Oracle) [this message] 2024-02-02 9:33 ` [PATCH net-next 3/6] net: fec: remove eee_enabled/eee_active in fec_enet_get_eee() Russell King (Oracle) 2024-02-02 13:22 ` Andrew Lunn 2024-02-02 13:22 ` Andrew Lunn 2024-02-02 13:45 ` Russell King (Oracle) 2024-02-02 13:45 ` Russell King (Oracle) 2024-02-02 9:34 ` [PATCH net-next 4/6] net: bcmgenet: remove eee_enabled/eee_active in bcmgenet_get_eee() Russell King (Oracle) 2024-02-02 9:34 ` Russell King (Oracle) 2024-02-02 13:25 ` Andrew Lunn 2024-02-02 13:25 ` Andrew Lunn 2024-02-03 1:17 ` Florian Fainelli 2024-02-03 1:17 ` Florian Fainelli 2024-02-03 1:21 ` Florian Fainelli 2024-02-03 1:21 ` Florian Fainelli 2024-02-04 12:02 ` Russell King (Oracle) 2024-02-04 12:02 ` Russell King (Oracle) 2024-02-02 9:34 ` [PATCH net-next 5/6] net: bcmasp: remove eee_enabled/eee_active in bcmasp_get_eee() Russell King (Oracle) 2024-02-02 9:34 ` Russell King (Oracle) 2024-02-02 13:26 ` Andrew Lunn 2024-02-02 13:26 ` Andrew Lunn 2024-02-03 1:18 ` Florian Fainelli 2024-02-03 1:18 ` Florian Fainelli 2024-02-02 9:34 ` [PATCH net-next 6/6] net: dsa: b53: remove eee_enabled/eee_active in b53_get_mac_eee() Russell King (Oracle) 2024-02-02 9:34 ` Russell King (Oracle) 2024-02-02 13:27 ` Andrew Lunn 2024-02-02 13:27 ` Andrew Lunn 2024-02-03 1:22 ` Florian Fainelli 2024-02-03 1:22 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E1rVpvm-002Pe0-TV@rmk-PC.armlinux.org.uk \ --to=rmk+kernel@armlinux.org.uk \ --cc=alexandre.torgue@foss.st.com \ --cc=andrew@lunn.ch \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bh74.an@samsung.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=florian.fainelli@broadcom.com \ --cc=hkallweit1@gmail.com \ --cc=joabreu@synopsys.com \ --cc=justin.chen@broadcom.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=opendmb@gmail.com \ --cc=pabeni@redhat.com \ --cc=shenwei.wang@nxp.com \ --cc=wei.fang@nxp.com \ --cc=xiaoning.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.