All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: kernel test robot <yujie.liu@intel.com>
Cc: "oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: drivers/misc/vmw_balloon.c:200: warning: Function parameter or member '5' not described in 'vmballoon_batch_entry'
Date: Mon, 6 Nov 2023 11:10:03 +0000	[thread overview]
Message-ID: <E58106B6-95BC-4FCB-AD93-773E198ED3BD@vmware.com> (raw)
In-Reply-To: <202311061016.YX1N3JbG-lkp@intel.com>

[ -Xavier ]

> On Nov 6, 2023, at 8:18 AM, kernel test robot <yujie.liu@intel.com> wrote:
>
> !! External Email
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   77fa2fbe87fc605c4bfa87dff87be9bfded0e9a3
> commit: 6c94875799eaf99bfdbb0efce21d75e1c56e96d5 vmw_balloon: simplifying batch access
> date:   5 years ago

Isn’t is slightly strange for the bot to check 5 year old patches?

> All warnings (new ones prefixed by >>):
>
>   In file included from drivers/misc/vmw_balloon.c:28:
>   include/linux/vmw_vmci_defs.h:159:33: warning: 'VMCI_ANON_SRC_HANDLE' defined but not used [-Wunused-const-variable=]
>     159 | static const struct vmci_handle VMCI_ANON_SRC_HANDLE = {
>         |                                 ^~~~~~~~~~~~~~~~~~~~
>>> drivers/misc/vmw_balloon.c:200: warning: Function parameter or member '5' not described in 'vmballoon_batch_entry'
>   drivers/misc/vmw_balloon.o: warning: objtool: vmballoon_deflate()+0x1ca: sibling call from callable instruction with modified stack frame
>   drivers/misc/vmw_balloon.o: warning: objtool: vmballoon_debug_show()+0x73: sibling call from callable instruction with modified stack frame
>   drivers/misc/vmw_balloon.o: warning: objtool: vmballoon_inflate()+0xa1: sibling call from callable instruction with modified stack frame
>   drivers/misc/vmw_balloon.o: warning: objtool: vmballoon_work()+0x84: sibling call from callable instruction with modified stack frame
>
>
> vim +200 drivers/misc/vmw_balloon.c
>
> 365bd7ef7ec8eb Philip P. Moltmann 2015-08-06  188
> 6c94875799eaf9 Nadav Amit         2018-09-20  189  /**
> 6c94875799eaf9 Nadav Amit         2018-09-20  190   * struct vmballoon_batch_entry - a batch entry for lock or unlock.
> 6c94875799eaf9 Nadav Amit         2018-09-20  191   *
> 6c94875799eaf9 Nadav Amit         2018-09-20  192   * @status: the status of the operation, which is written by the hypervisor.
> 6c94875799eaf9 Nadav Amit         2018-09-20  193   * @reserved: reserved for future use. Must be set to zero.
> 6c94875799eaf9 Nadav Amit         2018-09-20  194   * @pfn: the physical frame number of the page to be locked or unlocked.
> 6c94875799eaf9 Nadav Amit         2018-09-20  195   */
> 6c94875799eaf9 Nadav Amit         2018-09-20  196  struct vmballoon_batch_entry {
> 6c94875799eaf9 Nadav Amit         2018-09-20  197       u64 status : 5;
> 6c94875799eaf9 Nadav Amit         2018-09-20  198       u64 reserved : PAGE_SHIFT - 5;
> 6c94875799eaf9 Nadav Amit         2018-09-20  199       u64 pfn : 52;
> 6c94875799eaf9 Nadav Amit         2018-09-20 @200  } __packed;

And the error seems non-sensical to me: it appears the number of bits was mistakenly
considered as the name of the field by the test.


      reply	other threads:[~2023-11-06 11:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06  2:26 drivers/misc/vmw_balloon.c:200: warning: Function parameter or member '5' not described in 'vmballoon_batch_entry' kernel test robot
2023-11-06  6:18 ` kernel test robot
2023-11-06 11:10 ` Nadav Amit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E58106B6-95BC-4FCB-AD93-773E198ED3BD@vmware.com \
    --to=namit@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=yujie.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.