All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yen ChunChao <nothingstopsme@hotmail.com>
To: "davem@davemloft.net" <davem@davemloft.net>
Cc: "pabeni@redhat.com" <pabeni@redhat.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: [PATCH 3/3 RFC] net: usb: ax88179_178a: Allow live update of devices' mac address
Date: Tue, 28 Feb 2023 09:44:58 +0000	[thread overview]
Message-ID: <ME3P282MB28272C76B95D78090B3876FFD1AC9@ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <ME3P282MB2827F9C56A588D9794DC0750D15F9@ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM>

Problem Description:
Live update of devices' mac address is currently blocked by this driver, as
it requires the evaluation of netif_running() given the corresponding
device being false. While appearing a harmless check, it can be disruptive
in some networking configurations, such as "Link Aggregation" operated in
active-backup mode with fail_over_mac=follow, where the mac address of a
device will be updated dynamically even when it is already up and running.

Solution:
Remove the check of netif_running() in ax88179_set_mac_addr(), so that the
update procedure can proceed irrespective of the boolean status returned by
netif_running().

Verification:
Only tested with this device:
0b95:1790 ASIX Electronics Corp. AX88179 Gigabit Ethernet

Signed-off-by: Chun-Chao Yen <nothingstopsme@hotmail.com>
---
This is the same patch as https://rb.gy/nxendp sent in Oct. 2022.
I just would like to know the current state of this patch.
Has it been rejected or still under review?

Thanks

 drivers/net/usb/ax88179_178a.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 96ede3a131d4..84016e0567d4 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -958,8 +958,6 @@ static int ax88179_set_mac_addr(struct net_device *net, void *p)
         struct sockaddr *addr = p;
         int ret;
 
-       if (netif_running(net))
-               return -EBUSY;
         if (!is_valid_ether_addr(addr->sa_data))
                 return -EADDRNOTAVAIL;
 
-- 
2.32.0

      reply	other threads:[~2023-02-28  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221007142038.2814378-1-nothingstopsme@hotmail.com>
2022-10-07 14:20 ` [PATCH 2/3] net: usb: ax88179_178a: Enable AX_RX_CTL_IPE only when NET_IP_ALIGN != 0 Chun-Chao Yen
2023-02-28  9:44   ` [PATCH 2/3 RFC] " Yen ChunChao
2022-10-07 14:20 ` [PATCH 3/3] net: usb: ax88179_178a: Allow live update of devices' mac address Chun-Chao Yen
2023-02-28  9:44   ` Yen ChunChao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ME3P282MB28272C76B95D78090B3876FFD1AC9@ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM \
    --to=nothingstopsme@hotmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.