All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH 4/4] block: cleanup the flush plug helpers
Date: Fri, 22 Oct 2021 13:09:10 -0700	[thread overview]
Message-ID: <YXMaZoQJiR5WFZTw@archlinux-ax161> (raw)
In-Reply-To: <20211020144119.142582-5-hch@lst.de>

On Wed, Oct 20, 2021 at 04:41:19PM +0200, Christoph Hellwig wrote:
> Consolidate the various helpers into a single blk_flush_plug helper that
> takes a plk_plug and the from_scheduler bool and switch all callsites to
> call it directly.  Checks that the plug is non-NULL must be performed by
> the caller, something that most already do anyway.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

This patch as commit 008f75a20e70 ("block: cleanup the flush plug
helpers") in -next causes the following errors with CONFIG_BLOCK=n
(tinyconfig):

kernel/sched/core.c: In function ‘sched_submit_work’:
kernel/sched/core.c:6346:35: error: ‘struct task_struct’ has no member named ‘plug’
 6346 |                 blk_flush_plug(tsk->plug, true);
      |                                   ^~
kernel/sched/core.c: In function ‘io_schedule_prepare’:
kernel/sched/core.c:8357:20: error: ‘struct task_struct’ has no member named ‘plug’
 8357 |         if (current->plug)
      |                    ^~
kernel/sched/core.c:8358:39: error: ‘struct task_struct’ has no member named ‘plug’
 8358 |                 blk_flush_plug(current->plug, true);
      |                                       ^~

I tested the latest block tree and did not see it fixed nor did I see it
reported or fixed elsewhere.

Cheers,
Nathan

  reply	other threads:[~2021-10-22 20:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 14:41 cleanup and optimize block plug handling Christoph Hellwig
2021-10-20 14:41 ` [PATCH 1/4] blk-mq: only flush requests from the plug in blk_mq_submit_bio Christoph Hellwig
2021-10-20 14:41 ` [PATCH 2/4] blk-mq: move blk_mq_flush_plug_list to block/blk-mq.h Christoph Hellwig
2021-10-20 14:41 ` [PATCH 3/4] block: optimise blk_flush_plug_list Christoph Hellwig
2021-10-20 14:41 ` [PATCH 4/4] block: cleanup the flush plug helpers Christoph Hellwig
2021-10-22 20:09   ` Nathan Chancellor [this message]
2021-10-23  1:38     ` Jens Axboe
2021-10-20 16:10 ` cleanup and optimize block plug handling Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXMaZoQJiR5WFZTw@archlinux-ax161 \
    --to=nathan@kernel.org \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.