All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Stephan Gerhold <stephan@gerhold.net>,
	Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
	Baptiste Mansuy <bmansuy@invensense.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Albrieux <jonathan.albrieux@gmail.com>,
	llvm@lists.linux.dev
Subject: Re: [PATCH 00/12] IIO: clang W=1 warning cleanup.
Date: Mon, 6 Dec 2021 11:18:12 -0700	[thread overview]
Message-ID: <Ya5T5CMHn5hzzJy5@archlinux-ax161> (raw)
In-Reply-To: <20211128172445.2616166-1-jic23@kernel.org>

On Sun, Nov 28, 2021 at 05:24:33PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Hi All,
> 
> In the interests of noise reduction in warnings during build tests of
> new code, this series suppresses a bunch of warnings seen with
> LLVM=1 W=1.
> 
> Note I am seeing two others I haven't fixed here.  One is tied up in
> the existing CONFIG_PM* cleanup patch set and will be dealt with as
> part of that.  The other in tsl2772 looks like it might be a bug that
> needs further analysis. If anyone is curious:
> 
> drivers/iio/light/tsl2772.c:576:24: warning: variable 'prox_diode_mask' set but not used [-Wunused-but-set-variable]
>         int i, ret, num_leds, prox_diode_mask;     
> 
> As is common with series like this, some of the drivers are old
> and as such I haven't cc'd original authors etc and would appreciate
> a sanity check from anyone who has the time.
> 
> Mauro and Arnd are cc'd on a bunch of them because a media patch that
> I happened to see had similar fixes + discussion of type to use in the
> casting. For some others I've just picked on people who touched
> the driver in last year or so.
> 
> Nothing in this series should have any functional affect.
> 
> Jonathan

I build tested drivers/iio/ for arm, arm64, s390, and x86_64
allmodconfig and did not see any warnings other than the ones mentioned
in the commit message.

All the fixes look reasonable for the warnings.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Cc: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
> Cc: Baptiste Mansuy <bmansuy@invensense.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Jonathan Albrieux <jonathan.albrieux@gmail.com>
> 
> Jonathan Cameron (12):
>   iio:accel:bma180: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:dc:ina2xx-adc: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:adc:rcar: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:adc:ti-ads1015: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:amplifiers:hmc425a: Suppress clang W=1 warning about pointer to
>     enum conversion.
>   iio:dac:mcp4725: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:imu:inv_icm42600: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:imu:inv_mpu6050: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:magn:ak8975: Suppress clang W=1 warning about pointer to enum
>     conversion.
>   iio:dummy: Drop set but unused variable len.
>   iio:accel:bmc150: Mark structure __maybe_unused as only needed with
>     for pm ops.
>   iio:accel:kxcjk-1013: Mark struct __maybe_unused to avoid warning.
> 
>  drivers/iio/accel/bma180.c                      | 2 +-
>  drivers/iio/accel/bmc150-accel-core.c           | 2 +-
>  drivers/iio/accel/kxcjk-1013.c                  | 2 +-
>  drivers/iio/adc/ina2xx-adc.c                    | 2 +-
>  drivers/iio/adc/rcar-gyroadc.c                  | 3 +--
>  drivers/iio/adc/ti-ads1015.c                    | 2 +-
>  drivers/iio/amplifiers/hmc425a.c                | 2 +-
>  drivers/iio/dac/mcp4725.c                       | 2 +-
>  drivers/iio/dummy/iio_simple_dummy_buffer.c     | 2 --
>  drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c | 2 +-
>  drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c | 2 +-
>  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c       | 2 +-
>  drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c       | 2 +-
>  drivers/iio/magnetometer/ak8975.c               | 2 +-
>  14 files changed, 13 insertions(+), 16 deletions(-)
> 
> -- 
> 2.34.1
> 
> 

  parent reply	other threads:[~2021-12-06 18:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28 17:24 [PATCH 00/12] IIO: clang W=1 warning cleanup Jonathan Cameron
2021-11-28 17:24 ` [PATCH 01/12] iio:accel:bma180: Suppress clang W=1 warning about pointer to enum conversion Jonathan Cameron
2021-11-28 17:24 ` [PATCH 02/12] iio:dc:ina2xx-adc: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 03/12] iio:adc:rcar: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 04/12] iio:adc:ti-ads1015: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 05/12] iio:amplifiers:hmc425a: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 06/12] iio:dac:mcp4725: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 07/12] iio:imu:inv_icm42600: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 08/12] iio:imu:inv_mpu6050: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 09/12] iio:magn:ak8975: " Jonathan Cameron
2021-11-28 17:24 ` [PATCH 10/12] iio:dummy: Drop set but unused variable len Jonathan Cameron
2021-11-28 17:24 ` [PATCH 11/12] iio:accel:bmc150: Mark structure __maybe_unused as only needed with for pm ops Jonathan Cameron
2021-11-28 17:24 ` [PATCH 12/12] iio:accel:kxcjk-1013: Mark struct __maybe_unused to avoid warning Jonathan Cameron
2021-12-06 18:18 ` Nathan Chancellor [this message]
2021-12-16 18:03   ` [PATCH 00/12] IIO: clang W=1 warning cleanup Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ya5T5CMHn5hzzJy5@archlinux-ax161 \
    --to=nathan@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=arnd@arndb.de \
    --cc=bmansuy@invensense.com \
    --cc=jic23@kernel.org \
    --cc=jmaneyrol@invensense.com \
    --cc=jonathan.albrieux@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mchehab+huawei@kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.