From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mmc@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs
Date: Tue, 30 Nov 2021 08:49:56 +0100 [thread overview]
Message-ID: <YaXXpEAwVGTLjp1e@kroah.com> (raw)
In-Reply-To: <YaXTRJO9Wbsh8n05@sol.localdomain>
On Mon, Nov 29, 2021 at 11:31:16PM -0800, Eric Biggers wrote:
> On Tue, Nov 30, 2021 at 08:13:37AM +0100, Greg Kroah-Hartman wrote:
> > > Documentation/block/queue-sysfs.rst | 30 +++++
> >
> > Same objection as before. Please add these to Documentation/ABI/
>
> As I said before, this is where all the blk-sysfs stuff is documented currently.
> If you consider this a hard requirement, then I'll get started on a patch that
> moves all of queue-sysfs.rst into Documentation/ABI/, as it's silly to change it
> for just this one and not the 23 other blk-sysfs attributes with exactly the
> same issue.
If I don't complain about it, nothing will ever change :)
> > otherwise when running 'scripts/get_abi undefined' will show these new
> > sysfs files you are adding as having no documentation :(
>
> Perhaps this should be part of checkpatch?
It's hard as that requires the code that the patch is checking to be
running on the system you run checkpatch on.
thanks,
greg k-h
prev parent reply other threads:[~2021-11-30 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 4:03 [PATCH v2 0/3] block: show crypto capabilities in sysfs Eric Biggers
2021-11-30 4:03 ` [PATCH v2 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-11-30 6:44 ` Hannes Reinecke
2021-11-30 4:03 ` [PATCH v2 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-11-30 6:45 ` Hannes Reinecke
2021-11-30 7:09 ` Greg Kroah-Hartman
2021-11-30 4:03 ` [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-11-30 6:49 ` Hannes Reinecke
2021-11-30 7:40 ` Eric Biggers
2021-12-01 6:45 ` Hannes Reinecke
2021-11-30 7:13 ` Greg Kroah-Hartman
2021-11-30 7:31 ` Eric Biggers
2021-11-30 7:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaXXpEAwVGTLjp1e@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bvanassche@acm.org \
--cc=ebiggers@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.