All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>, Michael Lee <igvtee@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: [PATCH v9 1/3] net: mdio: add helpers to extract clause 45 regad and devad fields
Date: Fri, 31 Dec 2021 20:57:43 +0000	[thread overview]
Message-ID: <Yc9uphz7RGb63kzM@makrotopia.org> (raw)
In-Reply-To: <Ycr5Cna76eg2B0An@shell.armlinux.org.uk>

From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>

Add a couple of helpers and definitions to extract the clause 45 regad
and devad fields from the regnum passed into MDIO drivers.

Tested-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
v9: unchanged
v8: First inclusing upon comment on mailing list

 include/linux/mdio.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 9f3587a61e145..ecac96d52e010 100644
--- a/include/linux/mdio.h
+++ b/include/linux/mdio.h
@@ -7,6 +7,7 @@
 #define __LINUX_MDIO_H__
 
 #include <uapi/linux/mdio.h>
+#include <linux/bitfield.h>
 #include <linux/mod_devicetable.h>
 
 /* Or MII_ADDR_C45 into regnum for read/write on mii_bus to enable the 21 bit
@@ -14,6 +15,7 @@
  */
 #define MII_ADDR_C45		(1<<30)
 #define MII_DEVADDR_C45_SHIFT	16
+#define MII_DEVADDR_C45_MASK	GENMASK(20, 16)
 #define MII_REGADDR_C45_MASK	GENMASK(15, 0)
 
 struct gpio_desc;
@@ -381,6 +383,16 @@ static inline u32 mdiobus_c45_addr(int devad, u16 regnum)
 	return MII_ADDR_C45 | devad << MII_DEVADDR_C45_SHIFT | regnum;
 }
 
+static inline u16 mdiobus_c45_regad(u32 regnum)
+{
+	return FIELD_GET(MII_REGADDR_C45_MASK, regnum);
+}
+
+static inline u16 mdiobus_c45_devad(u32 regnum)
+{
+	return FIELD_GET(MII_DEVADDR_C45_MASK, regnum);
+}
+
 static inline int __mdiobus_c45_read(struct mii_bus *bus, int prtad, int devad,
 				     u16 regnum)
 {
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>, Michael Lee <igvtee@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: [PATCH v9 1/3] net: mdio: add helpers to extract clause 45 regad and devad fields
Date: Fri, 31 Dec 2021 20:57:43 +0000	[thread overview]
Message-ID: <Yc9uphz7RGb63kzM@makrotopia.org> (raw)
In-Reply-To: <Ycr5Cna76eg2B0An@shell.armlinux.org.uk>

From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>

Add a couple of helpers and definitions to extract the clause 45 regad
and devad fields from the regnum passed into MDIO drivers.

Tested-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
v9: unchanged
v8: First inclusing upon comment on mailing list

 include/linux/mdio.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 9f3587a61e145..ecac96d52e010 100644
--- a/include/linux/mdio.h
+++ b/include/linux/mdio.h
@@ -7,6 +7,7 @@
 #define __LINUX_MDIO_H__
 
 #include <uapi/linux/mdio.h>
+#include <linux/bitfield.h>
 #include <linux/mod_devicetable.h>
 
 /* Or MII_ADDR_C45 into regnum for read/write on mii_bus to enable the 21 bit
@@ -14,6 +15,7 @@
  */
 #define MII_ADDR_C45		(1<<30)
 #define MII_DEVADDR_C45_SHIFT	16
+#define MII_DEVADDR_C45_MASK	GENMASK(20, 16)
 #define MII_REGADDR_C45_MASK	GENMASK(15, 0)
 
 struct gpio_desc;
@@ -381,6 +383,16 @@ static inline u32 mdiobus_c45_addr(int devad, u16 regnum)
 	return MII_ADDR_C45 | devad << MII_DEVADDR_C45_SHIFT | regnum;
 }
 
+static inline u16 mdiobus_c45_regad(u32 regnum)
+{
+	return FIELD_GET(MII_REGADDR_C45_MASK, regnum);
+}
+
+static inline u16 mdiobus_c45_devad(u32 regnum)
+{
+	return FIELD_GET(MII_DEVADDR_C45_MASK, regnum);
+}
+
 static inline int __mdiobus_c45_read(struct mii_bus *bus, int prtad, int devad,
 				     u16 regnum)
 {
-- 
2.34.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>, Michael Lee <igvtee@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: [PATCH v9 1/3] net: mdio: add helpers to extract clause 45 regad and devad fields
Date: Fri, 31 Dec 2021 20:57:43 +0000	[thread overview]
Message-ID: <Yc9uphz7RGb63kzM@makrotopia.org> (raw)
In-Reply-To: <Ycr5Cna76eg2B0An@shell.armlinux.org.uk>

From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>

Add a couple of helpers and definitions to extract the clause 45 regad
and devad fields from the regnum passed into MDIO drivers.

Tested-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
v9: unchanged
v8: First inclusing upon comment on mailing list

 include/linux/mdio.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 9f3587a61e145..ecac96d52e010 100644
--- a/include/linux/mdio.h
+++ b/include/linux/mdio.h
@@ -7,6 +7,7 @@
 #define __LINUX_MDIO_H__
 
 #include <uapi/linux/mdio.h>
+#include <linux/bitfield.h>
 #include <linux/mod_devicetable.h>
 
 /* Or MII_ADDR_C45 into regnum for read/write on mii_bus to enable the 21 bit
@@ -14,6 +15,7 @@
  */
 #define MII_ADDR_C45		(1<<30)
 #define MII_DEVADDR_C45_SHIFT	16
+#define MII_DEVADDR_C45_MASK	GENMASK(20, 16)
 #define MII_REGADDR_C45_MASK	GENMASK(15, 0)
 
 struct gpio_desc;
@@ -381,6 +383,16 @@ static inline u32 mdiobus_c45_addr(int devad, u16 regnum)
 	return MII_ADDR_C45 | devad << MII_DEVADDR_C45_SHIFT | regnum;
 }
 
+static inline u16 mdiobus_c45_regad(u32 regnum)
+{
+	return FIELD_GET(MII_REGADDR_C45_MASK, regnum);
+}
+
+static inline u16 mdiobus_c45_devad(u32 regnum)
+{
+	return FIELD_GET(MII_DEVADDR_C45_MASK, regnum);
+}
+
 static inline int __mdiobus_c45_read(struct mii_bus *bus, int prtad, int devad,
 				     u16 regnum)
 {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-31 20:58 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26 21:29 [PATCH] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-26 21:29 ` Daniel Golle
2021-12-26 21:29 ` Daniel Golle
2021-12-26 21:51 ` Andrew Lunn
2021-12-26 21:51   ` Andrew Lunn
2021-12-26 21:51   ` Andrew Lunn
2021-12-26 21:57   ` Russell King (Oracle)
2021-12-26 21:57     ` Russell King (Oracle)
2021-12-26 21:57     ` Russell King (Oracle)
2021-12-26 22:26     ` Andrew Lunn
2021-12-26 22:26       ` Andrew Lunn
2021-12-26 22:26       ` Andrew Lunn
2021-12-26 23:23 ` [PATCH v2] " Daniel Golle
2021-12-26 23:23   ` Daniel Golle
2021-12-26 23:23   ` Daniel Golle
2021-12-27 16:09 ` [PATCH v3] " Daniel Golle
2021-12-27 16:09   ` Daniel Golle
2021-12-27 16:09   ` Daniel Golle
2021-12-27 16:21   ` Russell King (Oracle)
2021-12-27 16:21     ` Russell King (Oracle)
2021-12-27 16:21     ` Russell King (Oracle)
2021-12-27 17:51   ` [PATCH v4 0/2] net: mtk_soc_eth: " Daniel Golle
2021-12-27 17:51     ` Daniel Golle
2021-12-27 17:51     ` Daniel Golle
2021-12-27 17:51   ` [PATCH v4 1/2] net: mtk_eth_soc: fix return value of MDIO operations Daniel Golle
2021-12-27 17:51     ` Daniel Golle
2021-12-27 17:51     ` Daniel Golle
2021-12-27 17:52   ` [PATCH v4 2/2] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-27 17:52     ` Daniel Golle
2021-12-27 17:52     ` Daniel Golle
2021-12-27 18:30   ` [PATCH v5 0/2] " Daniel Golle
2021-12-27 18:30     ` Daniel Golle
2021-12-27 18:30     ` Daniel Golle
2021-12-27 18:31   ` [PATCH v5 1/2] net: ethernet: mtk_eth_soc: fix return value of MDIO ops Daniel Golle
2021-12-27 18:31     ` Daniel Golle
2021-12-27 18:31     ` Daniel Golle
2021-12-27 18:31   ` [PATCH v5 2/2] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-27 18:31     ` Daniel Golle
2021-12-27 18:31     ` Daniel Golle
2021-12-28  0:07   ` [PATCH v6 0/2] " Daniel Golle
2021-12-28  0:07     ` Daniel Golle
2021-12-28  0:07     ` Daniel Golle
2021-12-28  0:08   ` [PATCH v6 1/2] net: ethernet: mtk_eth_soc: fix return value of MDIO ops Daniel Golle
2021-12-28  0:08     ` Daniel Golle
2021-12-28  0:08     ` Daniel Golle
2021-12-28  0:09   ` [PATCH v6 2/2] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-28  0:09     ` Daniel Golle
2021-12-28  0:09     ` Daniel Golle
2021-12-28  1:10     ` [PATCH v7 0/2] net: ethernet: mtk_soc_eth: " Daniel Golle
2021-12-28  1:10       ` Daniel Golle
2021-12-28  1:10       ` Daniel Golle
2021-12-28  1:43       ` Jakub Kicinski
2021-12-28  1:43         ` Jakub Kicinski
2021-12-28  1:43         ` Jakub Kicinski
2021-12-28  1:10     ` [PATCH v7 1/2] net: ethernet: mtk_eth_soc: fix return value of MDIO ops Daniel Golle
2021-12-28  1:10       ` Daniel Golle
2021-12-28  1:10       ` Daniel Golle
2021-12-28  1:11     ` [PATCH v7 2/2] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-28  1:11       ` Daniel Golle
2021-12-28  1:11       ` Daniel Golle
2021-12-28 11:46       ` Russell King (Oracle)
2021-12-28 11:46         ` Russell King (Oracle)
2021-12-28 11:46         ` Russell King (Oracle)
2021-12-28 21:03         ` [PATCH v8 0/3] net: ethernet: mtk_eth_soc: refactoring and Clause 45 Daniel Golle
2021-12-28 21:03           ` Daniel Golle
2021-12-28 21:03           ` Daniel Golle
2021-12-28 21:05         ` [PATCH v8 1/3] net: mdio: add helpers to extract clause 45 regad and devad fields Daniel Golle
2021-12-28 21:05           ` Daniel Golle
2021-12-28 21:05           ` Daniel Golle
2021-12-28 21:05         ` [PATCH v8 2/3] net: ethernet: mtk_eth_soc: fix return value and refactor MDIO ops Daniel Golle
2021-12-28 21:05           ` Daniel Golle
2021-12-28 21:05           ` Daniel Golle
2021-12-28 21:05         ` [PATCH v8 3/3] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-28 21:05           ` Daniel Golle
2021-12-28 21:05           ` Daniel Golle
2021-12-31 20:52         ` [PATCH v9 0/3] net: ethernet: mtk_eth_soc: refactoring and Clause 45 Daniel Golle
2021-12-31 20:52           ` Daniel Golle
2021-12-31 20:52           ` Daniel Golle
2021-12-31 20:54         ` [PATCH v9 2/3] net: ethernet: mtk_eth_soc: fix return value and refactor MDIO ops Daniel Golle
2021-12-31 20:54           ` Daniel Golle
2021-12-31 20:54           ` Daniel Golle
2021-12-31 20:54         ` [PATCH v9 3/3] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2021-12-31 20:54           ` Daniel Golle
2021-12-31 20:54           ` Daniel Golle
2021-12-31 20:57         ` Daniel Golle [this message]
2021-12-31 20:57           ` [PATCH v9 1/3] net: mdio: add helpers to extract clause 45 regad and devad fields Daniel Golle
2021-12-31 20:57           ` Daniel Golle
2022-01-01 17:20           ` Andrew Lunn
2022-01-01 17:20             ` Andrew Lunn
2022-01-01 17:20             ` Andrew Lunn
2022-01-02 15:47             ` [PATCH v10 0/3] net: ethernet: mtk_eth_soc: refactoring and Clause 45 Daniel Golle
2022-01-02 15:47               ` Daniel Golle
2022-01-02 15:47               ` Daniel Golle
2022-01-02 15:51               ` Russell King (Oracle)
2022-01-02 15:51                 ` Russell King (Oracle)
2022-01-02 15:51                 ` Russell King (Oracle)
2022-01-02 15:48             ` [PATCH v10 1/3] net: ethernet: mtk_eth_soc: fix return value and refactor MDIO ops Daniel Golle
2022-01-02 15:48               ` Daniel Golle
2022-01-02 15:48               ` Daniel Golle
2022-01-02 16:43               ` Andrew Lunn
2022-01-02 16:43                 ` Andrew Lunn
2022-01-02 16:43                 ` Andrew Lunn
2022-01-02 15:48             ` [PATCH v10 2/3] net: mdio: add helpers to extract clause 45 regad and devad fields Daniel Golle
2022-01-02 15:48               ` Daniel Golle
2022-01-02 15:48               ` Daniel Golle
2022-01-02 16:44               ` Andrew Lunn
2022-01-02 16:44                 ` Andrew Lunn
2022-01-02 16:44                 ` Andrew Lunn
2022-01-02 15:49             ` [PATCH v10 3/3] net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access Daniel Golle
2022-01-02 15:49               ` Daniel Golle
2022-01-02 15:49               ` Daniel Golle
     [not found]         ` <Yc9tk6IZ0ldqHx4Y@makrotopia.org>
2022-01-01 17:18           ` [PATCH v9 1/3] net: mdio: add helpers to extract clause 45 regad and devad fields Andrew Lunn
2022-01-01 17:18             ` Andrew Lunn
2022-01-01 17:18             ` Andrew Lunn
2022-01-01 17:41             ` Daniel Golle
2022-01-01 17:41               ` Daniel Golle
2022-01-01 17:41               ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yc9uphz7RGb63kzM@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=igvtee@gmail.com \
    --cc=john@phrozen.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.