From: John David Anglin <dave.anglin@bell.net>
To: linux-parisc <linux-parisc@vger.kernel.org>
Cc: Helge Deller <deller@gmx.de>, Deller <deller@kernel.org>,
James.Bottomley@hansenpartnership.com
Subject: [PATCH] parisc: Fix lpa and lpa_user defines
Date: Wed, 22 Dec 2021 16:01:31 +0000 [thread overview]
Message-ID: <YcNL29hOucQ4gavI@mx3210.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]
While working on the rewrite to the light-weight syscall and futex code,
I experimented with using a hash index based on the user physical address
of atomic variable. This exposed two problems with the lpa and lpa_user
defines.
Because of the copy instruction, the pa argument needs to be an early
clobber argument. This prevents gcc from allocating the va and pa
arguments to the same register.
Secondly, the lpa instruction can cause a page fault so we need to
catch exceptions.
Signed-off-by: John David Anglin <dave.anglin@bell.net>
---
diff --git a/arch/parisc/include/asm/special_insns.h b/arch/parisc/include/asm/special_insns.h
index a303ae9a77f4..0493cbf70012 100644
--- a/arch/parisc/include/asm/special_insns.h
+++ b/arch/parisc/include/asm/special_insns.h
@@ -2,26 +2,30 @@
#ifndef __PARISC_SPECIAL_INSNS_H
#define __PARISC_SPECIAL_INSNS_H
-#define lpa(va) ({ \
- unsigned long pa; \
- __asm__ __volatile__( \
- "copy %%r0,%0\n\t" \
- "lpa %%r0(%1),%0" \
- : "=r" (pa) \
- : "r" (va) \
- : "memory" \
- ); \
- pa; \
+#define lpa(va) ({ \
+ unsigned long pa; \
+ __asm__ __volatile__( \
+ "copy %%r0,%0\n" \
+ "9998:\tlpa %%r0(%1),%0\n" \
+ "9999:\n" \
+ ASM_EXCEPTIONTABLE_ENTRY(9998b, 9999b) \
+ : "=&r" (pa) \
+ : "r" (va) \
+ : "memory" \
+ ); \
+ pa; \
})
-#define lpa_user(va) ({ \
- unsigned long pa; \
- __asm__ __volatile__( \
- "copy %%r0,%0\n\t" \
- "lpa %%r0(%%sr3,%1),%0" \
- : "=r" (pa) \
- : "r" (va) \
- : "memory" \
+#define lpa_user(va) ({ \
+ unsigned long pa; \
+ __asm__ __volatile__( \
+ "copy %%r0,%0\n" \
+ "9998:\tlpa %%r0(%%sr3,%1),%0\n" \
+ "9999:\n" \
+ ASM_EXCEPTIONTABLE_ENTRY(9998b, 9999b) \
+ : "=&r" (pa) \
+ : "r" (va) \
+ : "memory" \
); \
pa; \
})
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
reply other threads:[~2021-12-22 16:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcNL29hOucQ4gavI@mx3210.localdomain \
--to=dave.anglin@bell.net \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=deller@kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.