From: Nathan Chancellor <nathan@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fortify: Update compile-time tests for Clang 14
Date: Sun, 30 Jan 2022 12:55:44 -0700 [thread overview]
Message-ID: <YfbtQKtpyAM1hHiC@dev-arch.archlinux-ax161> (raw)
In-Reply-To: <20220130181616.420092-1-keescook@chromium.org>
On Sun, Jan 30, 2022 at 10:16:16AM -0800, Kees Cook wrote:
> Clang 14 introduces support for compiletime_assert(). Update the
> compile-time warning regex to catch Clang's variant of the warning text
> in preparation for Clang supporting CONFIG_FORTIFY_SOURCE.
>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: linux-hardening@vger.kernel.org
> Cc: llvm@lists.linux.dev
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> I'm splitting this patch out of the main Clang FORTIFY enabling patch.
> ---
> scripts/test_fortify.sh | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/test_fortify.sh b/scripts/test_fortify.sh
> index a4da365508f0..c2688ab8281d 100644
> --- a/scripts/test_fortify.sh
> +++ b/scripts/test_fortify.sh
> @@ -46,8 +46,12 @@ if "$@" -Werror -c "$IN" -o "$OUT".o 2> "$TMP" ; then
> status="warning: unsafe ${FUNC}() usage lacked '$WANT' symbol in $IN"
> fi
> else
> - # If the build failed, check for the warning in the stderr (gcc).
> - if ! grep -q -m1 "error: call to .\b${WANT}\b." "$TMP" ; then
> + # If the build failed, check for the warning in the stderr.
> + # GCC:
> + # ./include/linux/fortify-string.h:316:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
> + # Clang 14:
> + # ./include/linux/fortify-string.h:316:4: error: call to __write_overflow_field declared with 'warning' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror,-Wattribute-warning]
> + if ! grep -Eq -m1 "error: call to .?\b${WANT}\b.?" "$TMP" ; then
> status="warning: unsafe ${FUNC}() usage lacked '$WANT' warning in $IN"
> fi
> fi
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-01-30 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 18:16 [PATCH] fortify: Update compile-time tests for Clang 14 Kees Cook
2022-01-30 19:55 ` Nathan Chancellor [this message]
2022-01-31 19:09 ` Nick Desaulniers
2022-01-31 21:09 ` Kees Cook
2022-01-31 21:34 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfbtQKtpyAM1hHiC@dev-arch.archlinux-ax161 \
--to=nathan@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.