From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com> Cc: Daniel Machon <daniel.machon@microchip.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Florian Fainelli <f.fainelli@gmail.com>, Horatiu Vultur <horatiu.vultur@microchip.com>, Ioana Ciornei <ioana.ciornei@nxp.com>, Jakub Kicinski <kuba@kernel.org>, Lars Povlsen <lars.povlsen@microchip.com>, linux-arm-kernel@lists.infradead.org, Madalin Bucur <madalin.bucur@nxp.com>, Marcin Wojtas <mw@semihalf.com>, Michal Simek <michal.simek@amd.com>, netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>, Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>, Sean Anderson <sean.anderson@seco.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, Taras Chornyi <taras.chornyi@plvision.eu>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com> Subject: [PATCH RFC 0/9] Add and use helper for PCS negotiation modes Date: Tue, 23 May 2023 16:54:37 +0100 [thread overview] Message-ID: <ZGzhvePzPjJ0v2En@shell.armlinux.org.uk> (raw) Hi, Earlier this month, I proposed a helper for deciding whether a PCS should use inband negotiation modes or not. There was some discussion around this topic, and I believe there was no disagreement about providing the helper. The discussion can be found at: https://lore.kernel.org/r/ZGIkGmyL8yL1q1zp@shell.armlinux.org.uk This series adds that helper, and modifies most code to use it. I have a couple of further patches that hoist this function out of every PCS driver and into phylink's new phylink_pcs_config() function that I've posted separately, and drop the "mode" argument to the pcs_config() method, instead passing the result of phylink_pcs_neg_mode(). I haven't included those because this series doesn't update everything in net-next, but for RFC purposes, I think this is good enough to get a few whether people are generally happy or not. Note that this helper is only about modes that affect the PCS such as the SGMII family and 802.3z types, not amount negotiation that happens in order to select a PCS (e.g. for backplanes.) drivers/net/dsa/qca/qca8k-8xxx.c | 13 ++-- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 7 +- drivers/net/ethernet/marvell/mvneta.c | 5 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 +- .../net/ethernet/marvell/prestera/prestera_main.c | 10 ++- .../ethernet/microchip/lan966x/lan966x_phylink.c | 8 ++- .../net/ethernet/microchip/sparx5/sparx5_phylink.c | 8 ++- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 5 +- drivers/net/pcs/pcs-lynx.c | 18 +++-- drivers/net/phy/phylink.c | 14 ++-- include/linux/phylink.h | 81 +++++++++++++++++++++- 11 files changed, 136 insertions(+), 37 deletions(-) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com> Cc: Daniel Machon <daniel.machon@microchip.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Florian Fainelli <f.fainelli@gmail.com>, Horatiu Vultur <horatiu.vultur@microchip.com>, Ioana Ciornei <ioana.ciornei@nxp.com>, Jakub Kicinski <kuba@kernel.org>, Lars Povlsen <lars.povlsen@microchip.com>, linux-arm-kernel@lists.infradead.org, Madalin Bucur <madalin.bucur@nxp.com>, Marcin Wojtas <mw@semihalf.com>, Michal Simek <michal.simek@amd.com>, netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>, Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>, Sean Anderson <sean.anderson@seco.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, Taras Chornyi <taras.chornyi@plvision.eu>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com> Subject: [PATCH RFC 0/9] Add and use helper for PCS negotiation modes Date: Tue, 23 May 2023 16:54:37 +0100 [thread overview] Message-ID: <ZGzhvePzPjJ0v2En@shell.armlinux.org.uk> (raw) Hi, Earlier this month, I proposed a helper for deciding whether a PCS should use inband negotiation modes or not. There was some discussion around this topic, and I believe there was no disagreement about providing the helper. The discussion can be found at: https://lore.kernel.org/r/ZGIkGmyL8yL1q1zp@shell.armlinux.org.uk This series adds that helper, and modifies most code to use it. I have a couple of further patches that hoist this function out of every PCS driver and into phylink's new phylink_pcs_config() function that I've posted separately, and drop the "mode" argument to the pcs_config() method, instead passing the result of phylink_pcs_neg_mode(). I haven't included those because this series doesn't update everything in net-next, but for RFC purposes, I think this is good enough to get a few whether people are generally happy or not. Note that this helper is only about modes that affect the PCS such as the SGMII family and 802.3z types, not amount negotiation that happens in order to select a PCS (e.g. for backplanes.) drivers/net/dsa/qca/qca8k-8xxx.c | 13 ++-- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 7 +- drivers/net/ethernet/marvell/mvneta.c | 5 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 +- .../net/ethernet/marvell/prestera/prestera_main.c | 10 ++- .../ethernet/microchip/lan966x/lan966x_phylink.c | 8 ++- .../net/ethernet/microchip/sparx5/sparx5_phylink.c | 8 ++- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 5 +- drivers/net/pcs/pcs-lynx.c | 18 +++-- drivers/net/phy/phylink.c | 14 ++-- include/linux/phylink.h | 81 +++++++++++++++++++++- 11 files changed, 136 insertions(+), 37 deletions(-) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2023-05-23 15:55 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-23 15:54 Russell King (Oracle) [this message] 2023-05-23 15:54 ` [PATCH RFC 0/9] Add and use helper for PCS negotiation modes Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 1/9] net: phylink: add phylink_pcs_neg_mode() Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 2/9] net: phylink: use phylink_pcs_neg_mode() Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 3/9] net: phylink: pass aneg_mode into phylink_mii_c22_pcs_config() Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 4/9] net: qca8k: switch PCS driver to use phylink_pcs_neg_mode() Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 5/9] net: mvneta: " Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 6/9] net: mvpp2: " Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 7/9] net: prestera: " Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-24 11:38 ` [EXT] " Elad Nachman 2023-05-24 11:38 ` Elad Nachman 2023-05-23 15:55 ` [PATCH RFC net-next 8/9] net: lan966x: " Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-23 15:55 ` [PATCH RFC net-next 9/9] net: sparx5: " Russell King (Oracle) 2023-05-23 15:55 ` Russell King (Oracle) 2023-05-30 12:49 ` Daniel Machon 2023-05-30 12:49 ` Daniel Machon 2023-05-24 7:26 ` [PATCH RFC 0/9] Add and use helper for PCS negotiation modes Horatiu Vultur 2023-05-24 7:26 ` Horatiu Vultur 2023-05-24 8:10 ` Russell King (Oracle) 2023-05-24 8:10 ` Russell King (Oracle) 2023-05-25 8:15 ` Russell King (Oracle) 2023-05-25 8:15 ` Russell King (Oracle)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZGzhvePzPjJ0v2En@shell.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=Steen.Hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=andrew@lunn.ch \ --cc=daniel.machon@microchip.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=horatiu.vultur@microchip.com \ --cc=ioana.ciornei@nxp.com \ --cc=kuba@kernel.org \ --cc=lars.povlsen@microchip.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=madalin.bucur@nxp.com \ --cc=michal.simek@amd.com \ --cc=mw@semihalf.com \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=pabeni@redhat.com \ --cc=radhey.shyam.pandey@xilinx.com \ --cc=sean.anderson@seco.com \ --cc=taras.chornyi@plvision.eu \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.