From: Herbert Xu <herbert@gondor.apana.org.au>
To: kernel test robot <lkp@intel.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Cc: Danny Tsen <dtsen@linux.ibm.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>
Subject: crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX
Date: Mon, 28 Aug 2023 17:07:42 +0800 [thread overview]
Message-ID: <ZOxj3rFGVcRUzgwb@gondor.apana.org.au> (raw)
In-Reply-To: <202308251906.SYawej6g-lkp@intel.com>
On Fri, Aug 25, 2023 at 07:44:32PM +0800, kernel test robot wrote:
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/powerpc/crypto/poly1305-p10-glue.c:19:
...
> ae3a197e3d0bfe3 David Howells 2012-03-28 75
> ae3a197e3d0bfe3 David Howells 2012-03-28 76 #ifdef CONFIG_VSX
> d1e1cf2e38def30 Anton Blanchard 2015-10-29 77 extern void enable_kernel_vsx(void);
> ae3a197e3d0bfe3 David Howells 2012-03-28 78 extern void flush_vsx_to_thread(struct task_struct *);
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 79 static inline void disable_kernel_vsx(void)
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 80 {
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 81 msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX);
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 82 }
> bd73758803c2eed Christophe Leroy 2021-03-09 83 #else
> bd73758803c2eed Christophe Leroy 2021-03-09 84 static inline void enable_kernel_vsx(void)
> bd73758803c2eed Christophe Leroy 2021-03-09 85 {
> bd73758803c2eed Christophe Leroy 2021-03-09 @86 BUILD_BUG();
> bd73758803c2eed Christophe Leroy 2021-03-09 87 }
> bd73758803c2eed Christophe Leroy 2021-03-09 88
---8<---
Add dependency on VSX as otherwise the build will fail without
it.
Fixes: 161fca7e3e90 ("crypto: powerpc - Add chacha20/poly1305-p10 to Kconfig and Makefile")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308251906.SYawej6g-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index f25024afdda5..7a66d7c0e6a2 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -113,7 +113,7 @@ config CRYPTO_AES_GCM_P10
config CRYPTO_CHACHA20_P10
tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
- depends on PPC64 && CPU_LITTLE_ENDIAN
+ depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
select CRYPTO_SKCIPHER
select CRYPTO_LIB_CHACHA_GENERIC
select CRYPTO_ARCH_HAVE_LIB_CHACHA
@@ -127,7 +127,7 @@ config CRYPTO_CHACHA20_P10
config CRYPTO_POLY1305_P10
tristate "Hash functions: Poly1305 (P10 or later)"
- depends on PPC64 && CPU_LITTLE_ENDIAN
+ depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
select CRYPTO_HASH
select CRYPTO_LIB_POLY1305_GENERIC
help
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: kernel test robot <lkp@intel.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Cc: Linux Memory Management List <linux-mm@kvack.org>,
llvm@lists.linux.dev, Danny Tsen <dtsen@linux.ibm.com>,
oe-kbuild-all@lists.linux.dev
Subject: crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX
Date: Mon, 28 Aug 2023 17:07:42 +0800 [thread overview]
Message-ID: <ZOxj3rFGVcRUzgwb@gondor.apana.org.au> (raw)
In-Reply-To: <202308251906.SYawej6g-lkp@intel.com>
On Fri, Aug 25, 2023 at 07:44:32PM +0800, kernel test robot wrote:
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/powerpc/crypto/poly1305-p10-glue.c:19:
...
> ae3a197e3d0bfe3 David Howells 2012-03-28 75
> ae3a197e3d0bfe3 David Howells 2012-03-28 76 #ifdef CONFIG_VSX
> d1e1cf2e38def30 Anton Blanchard 2015-10-29 77 extern void enable_kernel_vsx(void);
> ae3a197e3d0bfe3 David Howells 2012-03-28 78 extern void flush_vsx_to_thread(struct task_struct *);
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 79 static inline void disable_kernel_vsx(void)
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 80 {
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 81 msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX);
> 3eb5d5888dc68c9 Anton Blanchard 2015-10-29 82 }
> bd73758803c2eed Christophe Leroy 2021-03-09 83 #else
> bd73758803c2eed Christophe Leroy 2021-03-09 84 static inline void enable_kernel_vsx(void)
> bd73758803c2eed Christophe Leroy 2021-03-09 85 {
> bd73758803c2eed Christophe Leroy 2021-03-09 @86 BUILD_BUG();
> bd73758803c2eed Christophe Leroy 2021-03-09 87 }
> bd73758803c2eed Christophe Leroy 2021-03-09 88
---8<---
Add dependency on VSX as otherwise the build will fail without
it.
Fixes: 161fca7e3e90 ("crypto: powerpc - Add chacha20/poly1305-p10 to Kconfig and Makefile")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308251906.SYawej6g-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index f25024afdda5..7a66d7c0e6a2 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -113,7 +113,7 @@ config CRYPTO_AES_GCM_P10
config CRYPTO_CHACHA20_P10
tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
- depends on PPC64 && CPU_LITTLE_ENDIAN
+ depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
select CRYPTO_SKCIPHER
select CRYPTO_LIB_CHACHA_GENERIC
select CRYPTO_ARCH_HAVE_LIB_CHACHA
@@ -127,7 +127,7 @@ config CRYPTO_CHACHA20_P10
config CRYPTO_POLY1305_P10
tristate "Hash functions: Poly1305 (P10 or later)"
- depends on PPC64 && CPU_LITTLE_ENDIAN
+ depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
select CRYPTO_HASH
select CRYPTO_LIB_POLY1305_GENERIC
help
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-08-28 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 11:44 [linux-next:master 1647/12910] arch/powerpc/include/asm/switch_to.h:86:2: error: call to __compiletime_assert_261 declared with 'error' attribute: BUILD_BUG failed kernel test robot
2023-08-28 9:07 ` Herbert Xu [this message]
2023-08-28 9:07 ` crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX Herbert Xu
2023-08-29 11:48 ` Michael Ellerman
2023-08-29 11:48 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOxj3rFGVcRUzgwb@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dtsen@linux.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.