From: Jules Irenge <jbi.octave@gmail.com>
To: jgg@ziepe.ca
Cc: leon@kernel.org, wenglianfa@huawei.com, gustavoars@kernel.org,
lishifeng@sangfor.com.cn, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] RDMA/core: Remove NULL check before dev_{put, hold}
Date: Sun, 28 Apr 2024 14:34:56 +0100 [thread overview]
Message-ID: <Zi5QgLIt9sblrfYs@octinomon.home> (raw)
Coccinelle reports a warning
WARNING: NULL check before dev_{put, hold} functions is not needed
The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL
There is no need to check before using dev_{put, hold}
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/infiniband/core/device.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 07cb6c5ffda0..84be4bb9b625 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -2235,8 +2235,7 @@ struct net_device *ib_device_get_netdev(struct ib_device *ib_dev,
spin_lock(&pdata->netdev_lock);
res = rcu_dereference_protected(
pdata->netdev, lockdep_is_held(&pdata->netdev_lock));
- if (res)
- dev_hold(res);
+ dev_hold(res);
spin_unlock(&pdata->netdev_lock);
}
--
2.43.2
next reply other threads:[~2024-04-28 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 13:34 Jules Irenge [this message]
2024-04-30 13:21 ` [PATCH] RDMA/core: Remove NULL check before dev_{put, hold} Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi5QgLIt9sblrfYs@octinomon.home \
--to=jbi.octave@gmail.com \
--cc=gustavoars@kernel.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lishifeng@sangfor.com.cn \
--cc=wenglianfa@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.