From: John Youn <johnyoun@synopsys.com>
To: John Youn <johnyoun@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-usb@vger.kernel.org
To: linux-kernel@vger.kernel.org
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Remi Pommarel <repk@triplefau.lt>
Cc: Caesar Wang <caesar.upstream@gmail.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: Tao Huang <huangtao@rock-chips.com>
Cc: Michael Niewoehner <linux@mniewoehner.de>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>
Subject: [PATCH v5 1/3] usb: dwc2: gadget: Only initialize device if in device mode
Date: Wed, 07 Sep 2016 19:39:37 -0700 [thread overview]
Message-ID: <a27f7de13d9b1e1ba83fcfb4ec978596bc96f8ca.1473302184.git.johnyoun@synopsys.com> (raw)
In-Reply-To: <cover.1473302184.git.johnyoun@synopsys.com>
In dwc2_hsotg_udc_start(), don't initialize the controller for device
mode unless we are actually in device mode.
Tested-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: John Youn <johnyoun@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 94bd19a..4cd6403 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3466,8 +3466,11 @@ static int dwc2_hsotg_udc_start(struct usb_gadget *gadget,
otg_set_peripheral(hsotg->uphy->otg, &hsotg->gadget);
spin_lock_irqsave(&hsotg->lock, flags);
- dwc2_hsotg_init(hsotg);
- dwc2_hsotg_core_init_disconnected(hsotg, false);
+ if (dwc2_hw_is_device(hsotg)) {
+ dwc2_hsotg_init(hsotg);
+ dwc2_hsotg_core_init_disconnected(hsotg, false);
+ }
+
hsotg->enabled = 0;
spin_unlock_irqrestore(&hsotg->lock, flags);
--
2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: johnyoun@synopsys.com (John Youn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] usb: dwc2: gadget: Only initialize device if in device mode
Date: Wed, 07 Sep 2016 19:39:37 -0700 [thread overview]
Message-ID: <a27f7de13d9b1e1ba83fcfb4ec978596bc96f8ca.1473302184.git.johnyoun@synopsys.com> (raw)
In-Reply-To: <cover.1473302184.git.johnyoun@synopsys.com>
In dwc2_hsotg_udc_start(), don't initialize the controller for device
mode unless we are actually in device mode.
Tested-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: John Youn <johnyoun@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 94bd19a..4cd6403 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3466,8 +3466,11 @@ static int dwc2_hsotg_udc_start(struct usb_gadget *gadget,
otg_set_peripheral(hsotg->uphy->otg, &hsotg->gadget);
spin_lock_irqsave(&hsotg->lock, flags);
- dwc2_hsotg_init(hsotg);
- dwc2_hsotg_core_init_disconnected(hsotg, false);
+ if (dwc2_hw_is_device(hsotg)) {
+ dwc2_hsotg_init(hsotg);
+ dwc2_hsotg_core_init_disconnected(hsotg, false);
+ }
+
hsotg->enabled = 0;
spin_unlock_irqrestore(&hsotg->lock, flags);
--
2.9.0
next prev parent reply other threads:[~2016-09-08 2:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 2:39 [PATCH v5 0/3] usb: dwc2: Fix core reset and force mode delays John Youn
2016-09-08 2:39 ` John Youn
2016-09-08 2:39 ` John Youn [this message]
2016-09-08 2:39 ` [PATCH v5 1/3] usb: dwc2: gadget: Only initialize device if in device mode John Youn
2016-09-08 2:39 ` [PATCH v5 2/3] usb: dwc2: Add delay to core soft reset John Youn
2016-09-08 2:39 ` John Youn
2016-09-08 2:39 ` [PATCH v5 3/3] usb: dwc2: Properly account for the force mode delays John Youn
2016-09-08 2:39 ` John Youn
[not found] ` <b4aac4b197241b8199c5300656d245692eb45856.1473302184.git.johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-09-11 21:19 ` Heiko Stuebner
2016-09-12 5:20 ` Stefan Wahren
[not found] ` <1336050364.27663.591ba3c4-a2b5-418f-9999-6b3cd631f440.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-09-12 11:05 ` Heiko Stuebner
2016-09-13 18:07 ` Stefan Wahren
[not found] ` <19473401.122600.97acfbc9-df96-4427-b533-911010ce5c3f.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-09-13 18:39 ` Heiko Stübner
2016-09-13 19:04 ` John Youn
[not found] ` <97a3539d-7176-086f-71f9-371d8d4b016c-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-09-14 14:05 ` Heiko Stübner
2016-09-14 21:10 ` John Youn
[not found] ` <6b0c9143-63b3-c5c3-7122-bbbb0c9f610b-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-09-15 7:08 ` Stefan Wahren
[not found] ` <ad02126f-6c0e-9216-f7ab-ec528eeda2e2-eS4NqCHxEME@public.gmane.org>
2016-09-15 19:39 ` John Youn
2016-09-16 2:16 ` John Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a27f7de13d9b1e1ba83fcfb4ec978596bc96f8ca.1473302184.git.johnyoun@synopsys.com \
--to=johnyoun@synopsys.com \
--cc=linux-rpi-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.