[PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Andrey Konovalov <andreyknvl@google.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will.deacon@arm.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Evgenii Stepanov <eugenis@google.com>,
	Branislav Rankov <Branislav.Rankov@arm.com>,
	Kevin Brodsky <kevin.brodsky@arm.com>,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL
Date: Tue,  5 Jan 2021 19:27:51 +0100	[thread overview]
Message-ID: <a37dab02f89ad93cc986a87866da74fb8be1850d.1609871239.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1609871239.git.andreyknvl@google.com>

It might not be obvious to the compiler that the expression must be
executed between writing and reading to fail_data. In this case, the
compiler might reorder or optimize away some of the accesses, and
the tests will fail.

Add compiler barriers around the expression in KUNIT_EXPECT_KASAN_FAIL.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Link: https://linux-review.googlesource.com/id/I046079f48641a1d36fe627fc8827a9249102fd50
---
 lib/test_kasan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index dd3d2f95c24e..b5077a47b95a 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -79,7 +79,9 @@ static void kasan_test_exit(struct kunit *test)
 				NULL,				\
 				&resource,			\
 				"kasan_data", &fail_data);	\
+	barrier();						\
 	expression;						\
+	barrier();						\
 	KUNIT_EXPECT_EQ(test,					\
 			fail_data.report_expected,		\
 			fail_data.report_found);		\
-- 
2.29.2.729.g45daf8777d-goog

WARNING: multiple messages have this Message-ID (diff)

From: Andrey Konovalov <andreyknvl@google.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	 Dmitry Vyukov <dvyukov@google.com>,
	Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>
Cc: Branislav Rankov <Branislav.Rankov@arm.com>,
	Andrey Konovalov <andreyknvl@google.com>,
	Kevin Brodsky <kevin.brodsky@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Evgenii Stepanov <eugenis@google.com>
Subject: [PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL
Date: Tue,  5 Jan 2021 19:27:51 +0100	[thread overview]
Message-ID: <a37dab02f89ad93cc986a87866da74fb8be1850d.1609871239.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1609871239.git.andreyknvl@google.com>

It might not be obvious to the compiler that the expression must be
executed between writing and reading to fail_data. In this case, the
compiler might reorder or optimize away some of the accesses, and
the tests will fail.

Add compiler barriers around the expression in KUNIT_EXPECT_KASAN_FAIL.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Link: https://linux-review.googlesource.com/id/I046079f48641a1d36fe627fc8827a9249102fd50
---
 lib/test_kasan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index dd3d2f95c24e..b5077a47b95a 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -79,7 +79,9 @@ static void kasan_test_exit(struct kunit *test)
 				NULL,				\
 				&resource,			\
 				"kasan_data", &fail_data);	\
+	barrier();						\
 	expression;						\
+	barrier();						\
 	KUNIT_EXPECT_EQ(test,					\
 			fail_data.report_expected,		\
 			fail_data.report_found);		\
-- 
2.29.2.729.g45daf8777d-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2021-01-05 18:29 UTC|newest]

Thread overview: 137+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 18:27 [PATCH 00/11] kasan: HW_TAGS tests support and fixes Andrey Konovalov
2021-01-05 18:27 ` Andrey Konovalov
2021-01-05 18:27 ` Andrey Konovalov
2021-01-05 18:27 ` [PATCH 01/11] kasan: prefix exported functions with kasan_ Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  7:38   ` Alexander Potapenko
2021-01-12  7:38     ` Alexander Potapenko
2021-01-12  7:38     ` Alexander Potapenko
2021-01-12 11:19   ` Marco Elver
2021-01-12 11:19     ` Marco Elver
2021-01-05 18:27 ` [PATCH 02/11] kasan: clarify HW_TAGS impact on TBI Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  7:40   ` Alexander Potapenko
2021-01-12  7:40     ` Alexander Potapenko
2021-01-12  7:40     ` Alexander Potapenko
2021-01-12 11:38   ` Marco Elver
2021-01-12 11:38     ` Marco Elver
2021-01-05 18:27 ` [PATCH 03/11] kasan: clean up comments in tests Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  7:53   ` Alexander Potapenko
2021-01-12  7:53     ` Alexander Potapenko
2021-01-12  7:53     ` Alexander Potapenko
2021-01-12 17:55     ` Andrey Konovalov
2021-01-12 17:55       ` Andrey Konovalov
2021-01-12 17:55       ` Andrey Konovalov
2021-01-12 13:07   ` Marco Elver
2021-01-12 13:07     ` Marco Elver
2021-01-05 18:27 ` [PATCH 04/11] kasan: add match-all tag tests Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  8:04   ` Alexander Potapenko
2021-01-12  8:04     ` Alexander Potapenko
2021-01-12  8:04     ` Alexander Potapenko
2021-01-12 18:10     ` Andrey Konovalov
2021-01-12 18:10       ` Andrey Konovalov
2021-01-12 18:10       ` Andrey Konovalov
2021-01-12 13:17   ` Marco Elver
2021-01-12 13:17     ` Marco Elver
2021-01-12 18:11     ` Andrey Konovalov
2021-01-12 18:11       ` Andrey Konovalov
2021-01-12 18:11       ` Andrey Konovalov
2021-01-05 18:27 ` [PATCH 05/11] kasan, arm64: allow using KUnit tests with HW_TAGS mode Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12 19:01   ` Catalin Marinas
2021-01-12 19:01     ` Catalin Marinas
2021-01-15 13:11     ` Andrey Konovalov
2021-01-15 13:11       ` Andrey Konovalov
2021-01-15 13:11       ` Andrey Konovalov
2021-01-15 15:04   ` Vincenzo Frascino
2021-01-15 15:04     ` Vincenzo Frascino
2021-01-05 18:27 ` [PATCH 06/11] kasan: rename CONFIG_TEST_KASAN_MODULE Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  8:09   ` Alexander Potapenko
2021-01-12  8:09     ` Alexander Potapenko
2021-01-12  8:09     ` Alexander Potapenko
2021-01-12 18:26     ` Andrey Konovalov
2021-01-12 18:26       ` Andrey Konovalov
2021-01-12 18:26       ` Andrey Konovalov
2021-01-12 13:33   ` Marco Elver
2021-01-12 13:33     ` Marco Elver
2021-01-12 18:28     ` Andrey Konovalov
2021-01-12 18:28       ` Andrey Konovalov
2021-01-12 18:28       ` Andrey Konovalov
2021-01-05 18:27 ` Andrey Konovalov [this message]
2021-01-05 18:27   ` [PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  8:18   ` Alexander Potapenko
2021-01-12  8:18     ` Alexander Potapenko
2021-01-12  8:18     ` Alexander Potapenko
2021-01-12 19:50     ` Andrey Konovalov
2021-01-12 19:50       ` Andrey Konovalov
2021-01-12 19:50       ` Andrey Konovalov
2021-01-12 19:57       ` Andrey Konovalov
2021-01-12 19:57         ` Andrey Konovalov
2021-01-12 19:57         ` Andrey Konovalov
2021-01-12 13:34   ` Marco Elver
2021-01-12 13:34     ` Marco Elver
2021-01-05 18:27 ` [PATCH 08/11] kasan: adopt kmalloc_uaf2 test to HW_TAGS mode Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  8:25   ` Alexander Potapenko
2021-01-12  8:25     ` Alexander Potapenko
2021-01-12  8:25     ` Alexander Potapenko
2021-01-12 20:04     ` Andrey Konovalov
2021-01-12 20:04       ` Andrey Konovalov
2021-01-12 20:04       ` Andrey Konovalov
2021-01-12 13:39   ` Marco Elver
2021-01-12 13:39     ` Marco Elver
2021-01-12 20:05     ` Andrey Konovalov
2021-01-12 20:05       ` Andrey Konovalov
2021-01-12 20:05       ` Andrey Konovalov
2021-01-05 18:27 ` [PATCH 09/11] kasan: fix memory corruption in kasan_bitops_tags test Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  8:30   ` Alexander Potapenko
2021-01-12  8:30     ` Alexander Potapenko
2021-01-12  8:30     ` Alexander Potapenko
2021-01-12 20:06     ` Andrey Konovalov
2021-01-12 20:06       ` Andrey Konovalov
2021-01-12 20:06       ` Andrey Konovalov
2021-01-13 12:30       ` Alexander Potapenko
2021-01-13 12:30         ` Alexander Potapenko
2021-01-13 12:30         ` Alexander Potapenko
2021-01-12 13:55   ` Marco Elver
2021-01-12 13:55     ` Marco Elver
2021-01-05 18:27 ` [PATCH 10/11] kasan: fix bug detection via ksize for HW_TAGS mode Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 21:04   ` kernel test robot
2021-01-05 21:04     ` kernel test robot
2021-01-06  0:09   ` kernel test robot
2021-01-06  0:09     ` kernel test robot
2021-01-07  0:02     ` Andrew Morton
2021-01-07  0:02       ` Andrew Morton
2021-01-07  1:59       ` Andrey Konovalov
2021-01-07  1:59         ` Andrey Konovalov
2021-01-12 14:32   ` Marco Elver
2021-01-12 14:32     ` Marco Elver
2021-01-12 21:16     ` Andrey Konovalov
2021-01-12 21:16       ` Andrey Konovalov
2021-01-12 21:16       ` Andrey Konovalov
2021-01-12 22:54       ` Marco Elver
2021-01-12 22:54         ` Marco Elver
2021-01-12 22:54         ` Marco Elver
2021-01-05 18:27 ` [PATCH 11/11] kasan: add proper page allocator tests Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-05 18:27   ` Andrey Konovalov
2021-01-12  8:57   ` Alexander Potapenko
2021-01-12  8:57     ` Alexander Potapenko
2021-01-12  8:57     ` Alexander Potapenko
2021-01-12 14:34   ` Marco Elver
2021-01-12 14:34     ` Marco Elver

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:dd3d2f95c24 dfblob:dd3d2f95c24 dfblob:b5077a47b95
dfblob:b5077a47b95
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a37dab02f89ad93cc986a87866da74fb8be1850d.1609871239.git.andreyknvl@google.com \
    --to=andreyknvl@google.com \
    --cc=Branislav.Rankov@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=eugenis@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.