All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>
Cc: linaro-toolchain@lists.linaro.org,
	clang-built-linux@googlegroups.com, arnd@linaro.org,
	Linus Walleij <linus.walleij@linaro.org>,
	ci_notify@linaro.org,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/llvm-release-arm-stable-allyesconfig - Build # 4 - Successful!
Date: Mon, 2 Aug 2021 10:28:02 -0700	[thread overview]
Message-ID: <a41ca429-9480-9ecf-242b-5e68fade3c10@kernel.org> (raw)
In-Reply-To: <1406720038.945.1627915387982@localhost>

On 8/2/2021 7:43 AM, ci_notify@linaro.org wrote:
> Successfully identified regression in *linux* in CI configuration tcwg_kernel/llvm-release-arm-stable-allyesconfig.  So far, this commit has regressed CI configurations:
>   - tcwg_kernel/llvm-release-arm-stable-allyesconfig
> 
> Culprit:
> <cut>
> commit 341db343768bc44f3512facc464021730d64071c
> Author: Linus Walleij <linus.walleij@linaro.org>
> Date:   Sun May 23 00:50:39 2021 +0200
> 
>      power: supply: ab8500: Move to componentized binding
>      
>      [ Upstream commit 1c1f13a006ed0d71bb5664c8b7e3e77a28da3beb ]
>      
>      The driver has problems with the different components of
>      the charging code racing with each other to probe().
>      
>      This results in all four subdrivers populating battery
>      information to ascertain that it is populated for their
>      own needs for example.
>      
>      Fix this by using component probing and thus expressing
>      to the kernel that these are dependent components.
>      The probes can happen in any order and will only acquire
>      resources such as state container, regulators and
>      interrupts and initialize the data structures, but no
>      execution happens until the .bind() callback is called.
>      
>      The charging driver is the main component and binds
>      first, then bind in order the three subcomponents:
>      ab8500-fg, ab8500-btemp and ab8500-chargalg.
>      
>      Do some housekeeping while we are moving the code around.
>      Like use devm_* for IRQs so as to cut down on some
>      boilerplate.
>      
>      Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>      Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>      Signed-off-by: Sasha Levin <sashal@kernel.org>
> </cut>
> 
> Results regressed to (for first_bad == 341db343768bc44f3512facc464021730d64071c)
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_llvm:
> -5
> # build_abe qemu:
> -2
> # linux_n_obj:
> 19634
> # First few build errors in logs:
> # 00:03:07 drivers/power/supply/ab8500_fg.c:3061:32: error: use of undeclared identifier 'np'
> # 00:03:08 make[3]: *** [drivers/power/supply/ab8500_fg.o] Error 1
> # 00:03:10 make[2]: *** [drivers/power/supply] Error 2
> # 00:03:10 make[1]: *** [drivers/power] Error 2
> # 00:04:05 make: *** [drivers] Error 2

Greg and Sasha,

Please cherry pick upstream commit 7e2bb83c617f ("power: supply: ab8500: 
Call battery population once") to resolve this build error on 5.13.

Cheers,
Nathan

       reply	other threads:[~2021-08-02 17:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1406720038.945.1627915387982@localhost>
2021-08-02 17:28 ` Nathan Chancellor [this message]
2021-08-02 19:23   ` [CI-NOTIFY]: TCWG Bisect tcwg_kernel/llvm-release-arm-stable-allyesconfig - Build # 4 - Successful! Sasha Levin
2021-08-02 21:44     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a41ca429-9480-9ecf-242b-5e68fade3c10@kernel.org \
    --to=nathan@kernel.org \
    --cc=arnd@linaro.org \
    --cc=ci_notify@linaro.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linaro-toolchain@lists.linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.