All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	jani.nikula@intel.com
Subject: [PATCH 18/22] drm/ttm: fix ttm_bo.h kernel-doc warnings
Date: Wed,  6 Mar 2024 20:31:23 +0200	[thread overview]
Message-ID: <a49f3dddc5a96fa2866ff6322c064f53edbfd93c.1709749576.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1709749576.git.jani.nikula@intel.com>

Some renames, some formatting fixes, add some as FIXME.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 include/drm/ttm/ttm_bo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
index 0223a41a64b2..8b1eb6828f0a 100644
--- a/include/drm/ttm/ttm_bo.h
+++ b/include/drm/ttm/ttm_bo.h
@@ -83,6 +83,9 @@ enum ttm_bo_type {
  * @resource: structure describing current placement.
  * @ttm: TTM structure holding system pages.
  * @deleted: True if the object is only a zombie and already deleted.
+ * @bulk_move: FIXME
+ * @priority: FIXME
+ * @pin_count: FIXME
  *
  * Base class for TTM buffer object, that deals with data placement and CPU
  * mappings. GPU mappings are really up to the driver, but for simpler GPUs
@@ -128,26 +131,28 @@ struct ttm_buffer_object {
 	struct work_struct delayed_delete;
 
 	/**
-	 * Special members that are protected by the reserve lock
-	 * and the bo::lock when written to. Can be read with
-	 * either of these locks held.
+	 * @sg: Special members that are protected by the reserve lock and the
+	 * bo::lock when written to. Can be read with either of these locks
+	 * held.
 	 */
 	struct sg_table *sg;
 };
 
+#define TTM_BO_MAP_IOMEM_MASK 0x80
+
 /**
  * struct ttm_bo_kmap_obj
  *
  * @virtual: The current kernel virtual address.
  * @page: The page when kmap'ing a single page.
  * @bo_kmap_type: Type of bo_kmap.
+ * @bo: FIXME
  *
  * Object describing a kernel mapping. Since a TTM bo may be located
  * in various memory types with various caching policies, the
  * mapping can either be an ioremap, a vmap, a kmap or part of a
  * premapped region.
  */
-#define TTM_BO_MAP_IOMEM_MASK 0x80
 struct ttm_bo_kmap_obj {
 	void *virtual;
 	struct page *page;
@@ -171,6 +176,7 @@ struct ttm_bo_kmap_obj {
  * @force_alloc: Don't check the memory account during suspend or CPU page
  * faults. Should only be used by TTM internally.
  * @resv: Reservation object to allow reserved evictions with.
+ * @bytes_moved: FIXME
  *
  * Context for TTM operations like changing buffer placement or general memory
  * allocation.
@@ -264,7 +270,7 @@ static inline int ttm_bo_reserve(struct ttm_buffer_object *bo,
  * ttm_bo_reserve_slowpath:
  * @bo: A pointer to a struct ttm_buffer_object.
  * @interruptible: Sleep interruptible if waiting.
- * @sequence: Set (@bo)->sequence to this value after lock
+ * @ticket: FIXME
  *
  * This is called after ttm_bo_reserve returns -EAGAIN and we backed off
  * from all our other reservations. Because there are no other reservations
@@ -303,7 +309,7 @@ static inline void ttm_bo_assign_mem(struct ttm_buffer_object *bo,
 }
 
 /**
- * ttm_bo_move_null = assign memory for a buffer object.
+ * ttm_bo_move_null - assign memory for a buffer object.
  * @bo: The bo to assign the memory to
  * @new_mem: The memory to be assigned.
  *
-- 
2.39.2


  parent reply	other threads:[~2024-03-06 18:33 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 18:31 [PATCH 00/22] drm: fix headers, add header test facility Jani Nikula
2024-03-06 18:31 ` [PATCH 01/22] drm/crtc: make drm_crtc_internal.h self-contained Jani Nikula
2024-03-07  8:34   ` [PATCH v2] " Jani Nikula
2024-03-06 18:31 ` [PATCH 02/22] drm: add missing header guards to drm_internal.h Jani Nikula
2024-03-06 18:31 ` [PATCH 03/22] drm/kunit: fix drm_kunit_helpers.h kernel-doc Jani Nikula
2024-03-06 18:31 ` [PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained Jani Nikula
2024-03-07 14:36   ` Alex Deucher
2024-03-07 15:02     ` Jani Nikula
2024-03-06 18:31 ` [PATCH 05/22] drm: bridge: samsung-dsim: make samsung-dsim.h self-contained Jani Nikula
2024-03-06 18:31 ` [PATCH 06/22] drm/dp_mst: fix drm_dp_mst_helper.h kernel-doc Jani Nikula
2024-03-06 18:31 ` [PATCH 07/22] drm/crc: make drm_debugfs_crc.h self-contained and fix kernel-doc Jani Nikula
2024-03-06 18:31 ` [PATCH 08/22] drm/encoder: silence drm_encoder_slave.h kernel-doc Jani Nikula
2024-03-06 18:31 ` [PATCH 09/22] drm: fix drm_format_helper.h kernel-doc warnings Jani Nikula
2024-03-06 18:31 ` [PATCH 10/22] drm/lease: make drm_lease.h self-contained Jani Nikula
2024-03-06 18:31 ` [PATCH 11/22] drm: fix drm_gem_vram_helper.h kernel-doc Jani Nikula
2024-03-06 18:31 ` [PATCH 12/22] drm/of: make drm_of.h self-contained Jani Nikula
2024-03-06 18:31 ` [PATCH 13/22] drm/i2c: silence ch7006.h and sil164.h kernel-doc warnings Jani Nikula
2024-03-06 18:31 ` [PATCH 14/22] drm/suballoc: fix drm_suballoc.h kernel-doc Jani Nikula
2024-03-06 18:31 ` [PATCH 15/22] drm/i915: fix i915_gsc_proxy_mei_interface.h kernel-doc Jani Nikula
2024-03-07 17:56   ` Lucas De Marchi
2024-03-06 18:31 ` [PATCH 16/22] drm/i915/hdcp: fix i915_hdcp_interface.h kernel-doc warnings Jani Nikula
2024-03-07 18:00   ` Lucas De Marchi
2024-03-06 18:31 ` [PATCH 17/22] drm/i915/pxp: fix i915_pxp_tee_interface.h " Jani Nikula
2024-03-07 18:02   ` Lucas De Marchi
2024-03-07 20:49     ` Jani Nikula
2024-03-06 18:31 ` Jani Nikula [this message]
2024-03-06 18:31 ` [PATCH 19/22] drm/ttm: make ttm_caching.h self-contained Jani Nikula
2024-03-06 18:31 ` [PATCH 20/22] drm/ttm: fix ttm_execbuf_util.h kernel-doc warnings Jani Nikula
2024-03-06 18:31 ` [PATCH 21/22] drm/ttm: fix ttm_kmap_iter.h " Jani Nikula
2024-03-06 18:31 ` [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc Jani Nikula
2024-03-07  5:06   ` kernel test robot
2024-03-07  5:28   ` kernel test robot
2024-03-07  8:44     ` Jani Nikula
2024-03-07  9:36       ` Geert Uytterhoeven
2024-03-07 15:43         ` Jani Nikula
2024-03-07 14:49   ` kernel test robot
2024-03-06 18:38 ` ✓ CI.Patch_applied: success for drm: fix headers, add header test facility Patchwork
2024-03-06 18:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-06 18:39 ` ✓ CI.KUnit: success " Patchwork
2024-03-06 18:50 ` ✓ CI.Build: " Patchwork
2024-03-06 18:51 ` ✗ CI.Hooks: failure " Patchwork
2024-03-06 18:52 ` ✗ CI.checksparse: warning " Patchwork
2024-03-06 19:26 ` ✓ CI.BAT: success " Patchwork
2024-03-07  0:47 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-03-07  0:47 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-07  1:06 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-07  8:35 ` [PATCH] drm: add missing header guards to drm_crtc_internal.h Jani Nikula
2024-03-07  8:39 ` ✓ CI.Patch_applied: success for drm: add missing header guards to drm_crtc_internal.h (rev2) Patchwork
2024-03-07  8:40 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-07  8:40 ` ✓ CI.KUnit: success " Patchwork
2024-03-07  8:54 ` ✓ CI.Build: " Patchwork
2024-03-07  8:55 ` ✗ CI.Hooks: failure " Patchwork
2024-03-07  8:55 ` [PATCH 00/22] drm: fix headers, add header test facility Thomas Zimmermann
2024-03-07  9:04   ` Jani Nikula
2024-03-07 15:23   ` Jani Nikula
2024-03-07  8:57 ` ✗ CI.checksparse: warning for drm: add missing header guards to drm_crtc_internal.h (rev2) Patchwork
2024-03-07  9:24 ` ✓ CI.BAT: success " Patchwork
2024-03-07  9:38 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-03-07  9:38 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-07  9:55 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-07 18:27 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a49f3dddc5a96fa2866ff6322c064f53edbfd93c.1709749576.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.