From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-input@vger.kernel.org
Subject: [PATCH] HID: Reorder fields in 'struct hid_field'
Date: Sun, 18 Jun 2023 10:08:07 +0200 [thread overview]
Message-ID: <a804f2e91bc32cc5e17e012ed90972415606db4e.1687075665.git.christophe.jaillet@wanadoo.fr> (raw)
Group some variables based on their sizes to reduce hole and avoid padding.
On x86_64, this shrinks the size of 'struct hid_field'
from 136 to 128 bytes.
It saves a few bytes of memory and is more cache-line friendly.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Using pahole
Before:
======
struct hid_field {
unsigned int physical; /* 0 4 */
unsigned int logical; /* 4 4 */
unsigned int application; /* 8 4 */
/* XXX 4 bytes hole, try to pack */
struct hid_usage * usage; /* 16 8 */
unsigned int maxusage; /* 24 4 */
unsigned int flags; /* 28 4 */
unsigned int report_offset; /* 32 4 */
unsigned int report_size; /* 36 4 */
unsigned int report_count; /* 40 4 */
unsigned int report_type; /* 44 4 */
__s32 * value; /* 48 8 */
__s32 * new_value; /* 56 8 */
/* --- cacheline 1 boundary (64 bytes) --- */
__s32 * usages_priorities; /* 64 8 */
__s32 logical_minimum; /* 72 4 */
__s32 logical_maximum; /* 76 4 */
__s32 physical_minimum; /* 80 4 */
__s32 physical_maximum; /* 84 4 */
__s32 unit_exponent; /* 88 4 */
unsigned int unit; /* 92 4 */
bool ignored; /* 96 1 */
/* XXX 7 bytes hole, try to pack */
struct hid_report * report; /* 104 8 */
unsigned int index; /* 112 4 */
/* XXX 4 bytes hole, try to pack */
struct hid_input * hidinput; /* 120 8 */
/* --- cacheline 2 boundary (128 bytes) --- */
__u16 dpad; /* 128 2 */
/* XXX 2 bytes hole, try to pack */
unsigned int slot_idx; /* 132 4 */
/* size: 136, cachelines: 3, members: 25 */
/* sum members: 119, holes: 4, sum holes: 17 */
/* last cacheline: 8 bytes */
};
After:
=====
struct hid_field {
unsigned int physical; /* 0 4 */
unsigned int logical; /* 4 4 */
unsigned int application; /* 8 4 */
/* XXX 4 bytes hole, try to pack */
struct hid_usage * usage; /* 16 8 */
unsigned int maxusage; /* 24 4 */
unsigned int flags; /* 28 4 */
unsigned int report_offset; /* 32 4 */
unsigned int report_size; /* 36 4 */
unsigned int report_count; /* 40 4 */
unsigned int report_type; /* 44 4 */
__s32 * value; /* 48 8 */
__s32 * new_value; /* 56 8 */
/* --- cacheline 1 boundary (64 bytes) --- */
__s32 * usages_priorities; /* 64 8 */
__s32 logical_minimum; /* 72 4 */
__s32 logical_maximum; /* 76 4 */
__s32 physical_minimum; /* 80 4 */
__s32 physical_maximum; /* 84 4 */
__s32 unit_exponent; /* 88 4 */
unsigned int unit; /* 92 4 */
struct hid_report * report; /* 96 8 */
unsigned int index; /* 104 4 */
bool ignored; /* 108 1 */
/* XXX 3 bytes hole, try to pack */
struct hid_input * hidinput; /* 112 8 */
__u16 dpad; /* 120 2 */
/* XXX 2 bytes hole, try to pack */
unsigned int slot_idx; /* 124 4 */
/* size: 128, cachelines: 2, members: 25 */
/* sum members: 119, holes: 3, sum holes: 9 */
};
---
include/linux/hid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 39e21e3815ad..5be5e671c263 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -480,9 +480,9 @@ struct hid_field {
__s32 physical_maximum;
__s32 unit_exponent;
unsigned unit;
- bool ignored; /* this field is ignored in this event */
struct hid_report *report; /* associated report */
unsigned index; /* index into report->field[] */
+ bool ignored; /* this field is ignored in this event */
/* hidinput data */
struct hid_input *hidinput; /* associated input structure */
__u16 dpad; /* dpad input code */
--
2.34.1
next reply other threads:[~2023-06-18 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 8:08 Christophe JAILLET [this message]
2023-06-19 5:18 ` [PATCH] HID: Reorder fields in 'struct hid_field' Dan Carpenter
2023-06-19 18:20 ` Christophe JAILLET
2023-06-20 5:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a804f2e91bc32cc5e17e012ed90972415606db4e.1687075665.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.