From: Randy Dunlap <rdunlap@infradead.org> To: LKML <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com> Subject: [PATCH] drm: ast: fix double __iomem sparse warning Date: Tue, 18 Aug 2020 13:28:11 -0700 [thread overview] Message-ID: <a8185578-a69a-16b0-6fdf-f4e46bc4f61f@infradead.org> (raw) From: Randy Dunlap <rdunlap@infradead.org> sparse complains about having 2 "__iomem" attributes on the same line where only one is needed since the first one applies to everything up to the ending ';'. However, to make it clear(er) that both of these pointers are "__iomem", use separate lines for them. ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: warning: duplicate [noderef] ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: error: multiple address space given: __iomem & __iomem Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Dave Airlie <airlied@redhat.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/ast/ast_cursor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- lnx-59-rc1.orig/drivers/gpu/drm/ast/ast_cursor.c +++ lnx-59-rc1/drivers/gpu/drm/ast/ast_cursor.c @@ -253,7 +253,8 @@ void ast_cursor_show(struct ast_private unsigned int offset_x, unsigned int offset_y) { u8 x_offset, y_offset; - u8 __iomem *dst, __iomem *sig; + u8 __iomem *dst; + u8 __iomem *sig; u8 jreg; dst = ast->cursor.vaddr[ast->cursor.next_index];
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: LKML <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com> Subject: [PATCH] drm: ast: fix double __iomem sparse warning Date: Tue, 18 Aug 2020 13:28:11 -0700 [thread overview] Message-ID: <a8185578-a69a-16b0-6fdf-f4e46bc4f61f@infradead.org> (raw) From: Randy Dunlap <rdunlap@infradead.org> sparse complains about having 2 "__iomem" attributes on the same line where only one is needed since the first one applies to everything up to the ending ';'. However, to make it clear(er) that both of these pointers are "__iomem", use separate lines for them. ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: warning: duplicate [noderef] ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: error: multiple address space given: __iomem & __iomem Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Dave Airlie <airlied@redhat.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/ast/ast_cursor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- lnx-59-rc1.orig/drivers/gpu/drm/ast/ast_cursor.c +++ lnx-59-rc1/drivers/gpu/drm/ast/ast_cursor.c @@ -253,7 +253,8 @@ void ast_cursor_show(struct ast_private unsigned int offset_x, unsigned int offset_y) { u8 x_offset, y_offset; - u8 __iomem *dst, __iomem *sig; + u8 __iomem *dst; + u8 __iomem *sig; u8 jreg; dst = ast->cursor.vaddr[ast->cursor.next_index]; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-08-18 20:28 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-18 20:28 Randy Dunlap [this message] 2020-08-18 20:28 ` [PATCH] drm: ast: fix double __iomem sparse warning Randy Dunlap 2020-08-18 23:37 ` kernel test robot 2020-08-18 23:37 ` kernel test robot 2020-08-18 23:37 ` kernel test robot 2020-08-19 7:17 ` Thomas Zimmermann 2020-08-19 7:17 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a8185578-a69a-16b0-6fdf-f4e46bc4f61f@infradead.org \ --to=rdunlap@infradead.org \ --cc=airlied@linux.ie \ --cc=airlied@redhat.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.