From: Viresh Kumar <viresh.kumar@linaro.org> To: Patrice Chotard <patrice.chotard@foss.st.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, Rafael Wysocki <rjw@rjwysocki.net>, Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/31] cpufreq: sti: Migrate to dev_pm_opp_set_config() Date: Thu, 26 May 2022 17:12:05 +0530 [thread overview] Message-ID: <a8de04432a90f35f7a6ee9aec8555f829e7ca9bd.1653564321.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1653564321.git.viresh.kumar@linaro.org> The OPP core now provides a unified API for setting all configuration types, i.e. dev_pm_opp_set_config(). Lets start using it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/sti-cpufreq.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c index fdb0a722d881..f4121a9d27e5 100644 --- a/drivers/cpufreq/sti-cpufreq.c +++ b/drivers/cpufreq/sti-cpufreq.c @@ -159,6 +159,11 @@ static int sti_cpufreq_set_opp_info(void) int ret; char name[MAX_PCODE_NAME_LEN]; struct opp_table *opp_table; + struct dev_pm_opp_config config = { + .supported_hw = version, + .supported_hw_count = ARRAY_SIZE(version), + .prop_name = name, + }; reg_fields = sti_cpufreq_match(); if (!reg_fields) { @@ -210,21 +215,14 @@ static int sti_cpufreq_set_opp_info(void) snprintf(name, MAX_PCODE_NAME_LEN, "pcode%d", pcode); - opp_table = dev_pm_opp_set_prop_name(dev, name); - if (IS_ERR(opp_table)) { - dev_err(dev, "Failed to set prop name\n"); - return PTR_ERR(opp_table); - } - version[0] = BIT(major); version[1] = BIT(minor); version[2] = BIT(substrate); - opp_table = dev_pm_opp_set_supported_hw(dev, version, VERSION_ELEMENTS); + opp_table = dev_pm_opp_set_config(dev, &config); if (IS_ERR(opp_table)) { - dev_err(dev, "Failed to set supported hardware\n"); - ret = PTR_ERR(opp_table); - goto err_put_prop_name; + dev_err(dev, "Failed to set OPP config\n"); + return PTR_ERR(opp_table); } dev_dbg(dev, "pcode: %d major: %d minor: %d substrate: %d\n", @@ -233,10 +231,6 @@ static int sti_cpufreq_set_opp_info(void) version[0], version[1], version[2]); return 0; - -err_put_prop_name: - dev_pm_opp_put_prop_name(opp_table); - return ret; } static int sti_cpufreq_fetch_syscon_registers(void) -- 2.31.1.272.g89b43f80a514
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: Patrice Chotard <patrice.chotard@foss.st.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, Rafael Wysocki <rjw@rjwysocki.net>, Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/31] cpufreq: sti: Migrate to dev_pm_opp_set_config() Date: Thu, 26 May 2022 17:12:05 +0530 [thread overview] Message-ID: <a8de04432a90f35f7a6ee9aec8555f829e7ca9bd.1653564321.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1653564321.git.viresh.kumar@linaro.org> The OPP core now provides a unified API for setting all configuration types, i.e. dev_pm_opp_set_config(). Lets start using it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/sti-cpufreq.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c index fdb0a722d881..f4121a9d27e5 100644 --- a/drivers/cpufreq/sti-cpufreq.c +++ b/drivers/cpufreq/sti-cpufreq.c @@ -159,6 +159,11 @@ static int sti_cpufreq_set_opp_info(void) int ret; char name[MAX_PCODE_NAME_LEN]; struct opp_table *opp_table; + struct dev_pm_opp_config config = { + .supported_hw = version, + .supported_hw_count = ARRAY_SIZE(version), + .prop_name = name, + }; reg_fields = sti_cpufreq_match(); if (!reg_fields) { @@ -210,21 +215,14 @@ static int sti_cpufreq_set_opp_info(void) snprintf(name, MAX_PCODE_NAME_LEN, "pcode%d", pcode); - opp_table = dev_pm_opp_set_prop_name(dev, name); - if (IS_ERR(opp_table)) { - dev_err(dev, "Failed to set prop name\n"); - return PTR_ERR(opp_table); - } - version[0] = BIT(major); version[1] = BIT(minor); version[2] = BIT(substrate); - opp_table = dev_pm_opp_set_supported_hw(dev, version, VERSION_ELEMENTS); + opp_table = dev_pm_opp_set_config(dev, &config); if (IS_ERR(opp_table)) { - dev_err(dev, "Failed to set supported hardware\n"); - ret = PTR_ERR(opp_table); - goto err_put_prop_name; + dev_err(dev, "Failed to set OPP config\n"); + return PTR_ERR(opp_table); } dev_dbg(dev, "pcode: %d major: %d minor: %d substrate: %d\n", @@ -233,10 +231,6 @@ static int sti_cpufreq_set_opp_info(void) version[0], version[1], version[2]); return 0; - -err_put_prop_name: - dev_pm_opp_put_prop_name(opp_table); - return ret; } static int sti_cpufreq_fetch_syscon_registers(void) -- 2.31.1.272.g89b43f80a514 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-26 11:44 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-26 11:41 [PATCH 00/31] OPP: Add new configuration interface: dev_pm_opp_set_config() Viresh Kumar 2022-05-26 11:41 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 01/31] OPP: Track if clock name is configured by platform Viresh Kumar 2022-05-26 11:42 ` [PATCH 02/31] OPP: Add dev_pm_opp_set_config() and friends Viresh Kumar 2022-06-21 15:09 ` Dmitry Osipenko 2022-06-21 15:34 ` Viresh Kumar 2022-06-22 6:13 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 03/31] cpufreq: dt: Migrate to dev_pm_opp_set_config() Viresh Kumar 2022-05-26 11:42 ` [PATCH 04/31] cpufreq: imx: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 05/31] cpufreq: qcom-nvmem: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar [this message] 2022-05-26 11:42 ` [PATCH 06/31] cpufreq: sti: " Viresh Kumar 2022-05-26 11:42 ` [PATCH 07/31] cpufreq: sun50i: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 08/31] cpufreq: tegra20: " Viresh Kumar 2022-05-29 16:19 ` Dmitry Osipenko 2022-05-29 16:59 ` Dmitry Osipenko 2022-05-30 7:52 ` Viresh Kumar 2022-06-07 8:43 ` Viresh Kumar 2022-06-17 12:09 ` Dmitry Osipenko 2022-06-24 5:38 ` Viresh Kumar 2022-06-24 9:41 ` Jon Hunter 2022-05-26 11:42 ` [PATCH 09/31] cpufreq: ti: " Viresh Kumar 2022-05-26 11:42 ` [PATCH 10/31] devfreq: exynos: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-30 9:45 ` Chanwoo Choi 2022-05-30 9:45 ` Chanwoo Choi 2022-05-31 4:12 ` Chanwoo Choi 2022-05-31 4:12 ` Chanwoo Choi 2022-05-31 4:15 ` Viresh Kumar 2022-05-31 4:15 ` Viresh Kumar 2022-05-31 4:38 ` Viresh Kumar 2022-05-31 4:38 ` Viresh Kumar 2022-05-31 5:05 ` Chanwoo Choi 2022-05-31 5:05 ` Chanwoo Choi 2022-05-31 5:12 ` Viresh Kumar 2022-05-31 5:12 ` Viresh Kumar 2022-05-31 5:03 ` Chanwoo Choi 2022-05-31 5:03 ` Chanwoo Choi 2022-05-26 11:42 ` [PATCH 11/31] devfreq: sun8i: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 12/31] devfreq: tegra30: " Viresh Kumar 2022-05-26 11:42 ` [PATCH 13/31] drm/lima: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 14/31] drm/msm: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 15/31] drm/panfrost: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 13:45 ` Steven Price 2022-05-26 13:45 ` Steven Price 2022-05-26 11:42 ` [PATCH 16/31] drm/tegra: " Viresh Kumar 2022-05-26 11:42 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 17/31] media: venus: " Viresh Kumar 2022-05-26 11:42 ` [PATCH 18/31] media: tegra: " Viresh Kumar 2022-05-26 12:57 ` Krzysztof Kozlowski 2022-05-27 2:43 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 19/31] mmc: sdhci-msm: " Viresh Kumar 2022-06-02 9:47 ` Ulf Hansson 2022-05-26 11:42 ` [PATCH 20/31] OPP: ti: " Viresh Kumar 2022-05-26 11:42 ` [PATCH 21/31] soc/tegra: Remove the call to devm_pm_opp_set_clkname() Viresh Kumar 2022-05-26 17:57 ` Dmitry Osipenko 2022-05-27 2:52 ` Viresh Kumar 2022-06-23 21:15 ` Jon Hunter 2022-06-24 0:28 ` Viresh Kumar 2022-06-24 0:59 ` Viresh Kumar 2022-06-24 10:32 ` Jon Hunter 2022-05-26 11:42 ` [PATCH 22/31] soc/tegra: Migrate to dev_pm_opp_set_config() Viresh Kumar 2022-06-24 0:48 ` Viresh Kumar 2022-06-24 0:57 ` Viresh Kumar 2022-06-26 22:14 ` Dmitry Osipenko 2022-06-27 6:45 ` Viresh Kumar 2022-06-27 7:14 ` Dmitry Osipenko 2022-06-27 7:21 ` Viresh Kumar 2022-06-28 7:09 ` Viresh Kumar 2022-06-28 10:08 ` Dmitry Osipenko 2022-06-28 10:11 ` Viresh Kumar 2022-06-28 10:16 ` Dmitry Osipenko 2022-06-28 11:00 ` Viresh Kumar 2022-06-29 17:03 ` Jon Hunter 2022-06-30 0:23 ` Viresh Kumar 2022-05-26 11:42 ` [PATCH 23/31] spi: qcom: " Viresh Kumar 2022-05-26 12:41 ` Mark Brown 2022-05-26 11:42 ` [PATCH 24/31] serial: " Viresh Kumar 2022-05-26 11:42 ` [PATCH 25/31] OPP: Remove dev_pm_opp_set_regulators() and friends Viresh Kumar 2022-05-26 11:42 ` [PATCH 26/31] OPP: Remove dev_pm_opp_set_supported_hw() " Viresh Kumar 2022-05-26 11:42 ` [PATCH 27/31] OPP: Remove dev_pm_opp_set_clkname() " Viresh Kumar 2022-05-26 11:42 ` [PATCH 28/31] OPP: Remove dev_pm_opp_register_set_opp_helper() " Viresh Kumar 2022-05-26 11:42 ` [PATCH 29/31] OPP: Remove dev_pm_opp_attach_genpd() " Viresh Kumar 2022-05-26 11:42 ` [PATCH 30/31] OPP: Remove dev_pm_opp_set_prop_name() " Viresh Kumar 2022-05-26 11:42 ` [PATCH 31/31] OPP: Rearrange dev_pm_opp_set_config() " Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a8de04432a90f35f7a6ee9aec8555f829e7ca9bd.1653564321.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nm@ti.com \ --cc=patrice.chotard@foss.st.com \ --cc=rafael@kernel.org \ --cc=rjw@rjwysocki.net \ --cc=sboyd@kernel.org \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.