From: "Guido Günther" <agx@sigxcpu.org> To: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Martin Kepplinger <martink@posteo.de>, Angus Ainslie <angus@akkea.ca>, Krzysztof Kozlowski <krzk@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Li Yang <leoyang.li@nxp.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Vinod Koul <vkoul@kernel.org>, Anson Huang <Anson.Huang@nxp.com>, Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators Date: Thu, 17 Dec 2020 16:13:13 +0100 [thread overview] Message-ID: <a930ccca2f9a5dc49f24c46c3f4280c4de960f9d.1608216796.git.agx@sigxcpu.org> (raw) In-Reply-To: <cover.1608216796.git.agx@sigxcpu.org> BUCK3 needs a regulator-enable-ramp-delay since otherwise the board freezes on etnaviv probe. With this pgc_gpu suspends and resumes as expected. This must have been always broken since gpcv2 support was enabled. We also enable all the regulators needed for Deep Sleep Mode (DSM) as always-on: - VDD_SOC supplied by BUCK1 - VDDA_1P8 supplied by BUCK7 - VDDA_0P9 supplied by LDO4 - VDDA_DRAM supplied by LDO3 - NVCC_DRAM supplied by BUCK8 - VDD_DRAM supplied by BUCK5 Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to turn these off (and I've tested that or LDO6 and mipi with USB disabled) it is of little practical use atm since USB doesn't runtime suspend so let's revisit this at a later point. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index af139b283daf..f35d6897fbf7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -298,6 +298,7 @@ buck1_reg: BUCK1 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; regulator-boot-on; + regulator-always-on; regulator-ramp-delay = <1250>; rohm,dvs-run-voltage = <900000>; rohm,dvs-idle-voltage = <850000>; @@ -319,6 +320,7 @@ buck3_reg: BUCK3 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; regulator-boot-on; + regulator-enable-ramp-delay = <200>; rohm,dvs-run-voltage = <900000>; }; @@ -334,6 +336,7 @@ buck5_reg: BUCK5 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1350000>; regulator-boot-on; + regulator-always-on; }; buck6_reg: BUCK6 { @@ -341,6 +344,7 @@ buck6_reg: BUCK6 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; buck7_reg: BUCK7 { @@ -348,6 +352,7 @@ buck7_reg: BUCK7 { regulator-min-microvolt = <1605000>; regulator-max-microvolt = <1995000>; regulator-boot-on; + regulator-always-on; }; buck8_reg: BUCK8 { @@ -355,6 +360,7 @@ buck8_reg: BUCK8 { regulator-min-microvolt = <800000>; regulator-max-microvolt = <1400000>; regulator-boot-on; + regulator-always-on; }; ldo1_reg: LDO1 { @@ -380,6 +386,7 @@ ldo3_reg: LDO3 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; ldo4_reg: LDO4 { @@ -387,12 +394,14 @@ ldo4_reg: LDO4 { regulator-min-microvolt = <900000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; ldo5_reg: LDO5 { regulator-name = "ldo5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; + regulator-always-on; }; ldo6_reg: LDO6 { @@ -400,6 +409,7 @@ ldo6_reg: LDO6 { regulator-min-microvolt = <900000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; ldo7_reg: LDO7 { @@ -407,6 +417,7 @@ ldo7_reg: LDO7 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; }; }; -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: "Guido Günther" <agx@sigxcpu.org> To: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Martin Kepplinger <martink@posteo.de>, Angus Ainslie <angus@akkea.ca>, Krzysztof Kozlowski <krzk@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Li Yang <leoyang.li@nxp.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Vinod Koul <vkoul@kernel.org>, Anson Huang <Anson.Huang@nxp.com>, Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators Date: Thu, 17 Dec 2020 16:13:13 +0100 [thread overview] Message-ID: <a930ccca2f9a5dc49f24c46c3f4280c4de960f9d.1608216796.git.agx@sigxcpu.org> (raw) In-Reply-To: <cover.1608216796.git.agx@sigxcpu.org> BUCK3 needs a regulator-enable-ramp-delay since otherwise the board freezes on etnaviv probe. With this pgc_gpu suspends and resumes as expected. This must have been always broken since gpcv2 support was enabled. We also enable all the regulators needed for Deep Sleep Mode (DSM) as always-on: - VDD_SOC supplied by BUCK1 - VDDA_1P8 supplied by BUCK7 - VDDA_0P9 supplied by LDO4 - VDDA_DRAM supplied by LDO3 - NVCC_DRAM supplied by BUCK8 - VDD_DRAM supplied by BUCK5 Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to turn these off (and I've tested that or LDO6 and mipi with USB disabled) it is of little practical use atm since USB doesn't runtime suspend so let's revisit this at a later point. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index af139b283daf..f35d6897fbf7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -298,6 +298,7 @@ buck1_reg: BUCK1 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; regulator-boot-on; + regulator-always-on; regulator-ramp-delay = <1250>; rohm,dvs-run-voltage = <900000>; rohm,dvs-idle-voltage = <850000>; @@ -319,6 +320,7 @@ buck3_reg: BUCK3 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; regulator-boot-on; + regulator-enable-ramp-delay = <200>; rohm,dvs-run-voltage = <900000>; }; @@ -334,6 +336,7 @@ buck5_reg: BUCK5 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1350000>; regulator-boot-on; + regulator-always-on; }; buck6_reg: BUCK6 { @@ -341,6 +344,7 @@ buck6_reg: BUCK6 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; buck7_reg: BUCK7 { @@ -348,6 +352,7 @@ buck7_reg: BUCK7 { regulator-min-microvolt = <1605000>; regulator-max-microvolt = <1995000>; regulator-boot-on; + regulator-always-on; }; buck8_reg: BUCK8 { @@ -355,6 +360,7 @@ buck8_reg: BUCK8 { regulator-min-microvolt = <800000>; regulator-max-microvolt = <1400000>; regulator-boot-on; + regulator-always-on; }; ldo1_reg: LDO1 { @@ -380,6 +386,7 @@ ldo3_reg: LDO3 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; ldo4_reg: LDO4 { @@ -387,12 +394,14 @@ ldo4_reg: LDO4 { regulator-min-microvolt = <900000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; ldo5_reg: LDO5 { regulator-name = "ldo5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; + regulator-always-on; }; ldo6_reg: LDO6 { @@ -400,6 +409,7 @@ ldo6_reg: LDO6 { regulator-min-microvolt = <900000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; ldo7_reg: LDO7 { @@ -407,6 +417,7 @@ ldo7_reg: LDO7 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; }; }; -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-17 15:14 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-17 15:13 [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit Guido Günther 2020-12-17 15:13 ` Guido Günther 2020-12-17 15:13 ` [PATCH v2 1/4] arm64: defconfig: Enable Librem 5 devkit components Guido Günther 2020-12-17 15:13 ` Guido Günther 2020-12-19 12:23 ` Krzysztof Kozlowski 2020-12-19 12:23 ` Krzysztof Kozlowski 2020-12-17 15:13 ` Guido Günther [this message] 2020-12-17 15:13 ` [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators Guido Günther 2020-12-19 12:25 ` Krzysztof Kozlowski 2020-12-19 12:25 ` Krzysztof Kozlowski 2021-01-10 12:24 ` Shawn Guo 2021-01-10 12:24 ` Shawn Guo 2020-12-17 15:13 ` [PATCH v2 3/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc Guido Günther 2020-12-17 15:13 ` Guido Günther 2020-12-19 12:25 ` Krzysztof Kozlowski 2020-12-19 12:25 ` Krzysztof Kozlowski 2021-01-10 12:25 ` Shawn Guo 2021-01-10 12:25 ` Shawn Guo 2020-12-17 15:13 ` [PATCH v2 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings Guido Günther 2020-12-17 15:13 ` Guido Günther 2020-12-19 12:24 ` Krzysztof Kozlowski 2020-12-19 12:24 ` Krzysztof Kozlowski 2021-01-10 12:25 ` Shawn Guo 2021-01-10 12:25 ` Shawn Guo 2021-01-10 12:26 ` [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit Shawn Guo 2021-01-10 12:26 ` Shawn Guo 2021-01-10 15:06 ` Guido Günther 2021-01-10 15:06 ` Guido Günther
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a930ccca2f9a5dc49f24c46c3f4280c4de960f9d.1608216796.git.agx@sigxcpu.org \ --to=agx@sigxcpu.org \ --cc=Anson.Huang@nxp.com \ --cc=angus@akkea.ca \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=geert+renesas@glider.be \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=martink@posteo.de \ --cc=michael@walle.cc \ --cc=phone-devel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.