From: Ben Gardiner <bengardiner@nanometrics.ca> To: Kevin Hilman <khilman@deeprootsystems.com>, davinci-linux-open-source@linux.davincidsp.com, linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-kernel@vger.kernel.org, Chris Cordahi <christophercordahi@nanometrics.ca>, Paul Mundt <lethal@linux-sh.org>, Alexander Clouter <alex@digriz.org.uk> Subject: [PATCH v2 3/4] da850-evm: extract defines for SEL{A,B,C} pins in UI expander Date: Tue, 16 Nov 2010 14:39:36 -0500 [thread overview] Message-ID: <aa85c5d83111add3a2ed3495ac13bffe5e6b885d.1289935504.git.bengardiner@nanometrics.ca> (raw) In-Reply-To: <cover.1289935504.git.bengardiner@nanometrics.ca> The setup and teardown methods of the UI expander reference the SEL_{A,B,C} pins by 'magic number' in each function. This patch extracts common #defines for their offsets in the expander and uses them. Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca> Reviewed-by: Chris Cordahi <christophercordahi@nanometrics.ca> --- No changes since v1 --- arch/arm/mach-davinci/board-da850-evm.c | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index ff71ffd..dcf21e5 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -292,6 +292,9 @@ static const char const *ui_expander_names[] = { "pb7", "pb6", "pb5", "pb4", "pb3", "pb2", "pb1" }; +#define DA850_SEL_A_OFFSET 7 +#define DA850_SEL_B_OFFSET 6 +#define DA850_SEL_C_OFFSET 5 #define DA850_UI_PB8_OFFSET 8 #define DA850_N_UI_PB 8 @@ -336,23 +339,23 @@ static int da850_evm_ui_expander_setup(struct i2c_client *client, unsigned gpio, { int sel_a, sel_b, sel_c, ret; - sel_a = gpio + 7; - sel_b = gpio + 6; - sel_c = gpio + 5; + sel_a = gpio + DA850_SEL_A_OFFSET; + sel_b = gpio + DA850_SEL_B_OFFSET; + sel_c = gpio + DA850_SEL_C_OFFSET; - ret = gpio_request(sel_a, "sel_a"); + ret = gpio_request(sel_a, ui_expander_names[DA850_SEL_A_OFFSET]); if (ret) { pr_warning("Cannot open UI expander pin %d\n", sel_a); goto exp_setup_sela_fail; } - ret = gpio_request(sel_b, "sel_b"); + ret = gpio_request(sel_b, ui_expander_names[DA850_SEL_B_OFFSET]); if (ret) { pr_warning("Cannot open UI expander pin %d\n", sel_b); goto exp_setup_selb_fail; } - ret = gpio_request(sel_c, "sel_c"); + ret = gpio_request(sel_c, ui_expander_names[DA850_SEL_C_OFFSET]); if (ret) { pr_warning("Cannot open UI expander pin %d\n", sel_c); goto exp_setup_selc_fail; @@ -396,13 +399,13 @@ static int da850_evm_ui_expander_teardown(struct i2c_client *client, platform_device_unregister(&user_ui_pb_gpio_key_device); /* deselect all functionalities */ - gpio_set_value(gpio + 5, 1); - gpio_set_value(gpio + 6, 1); - gpio_set_value(gpio + 7, 1); + gpio_set_value(gpio + DA850_SEL_C_OFFSET, 1); + gpio_set_value(gpio + DA850_SEL_B_OFFSET, 1); + gpio_set_value(gpio + DA850_SEL_A_OFFSET, 1); - gpio_free(gpio + 5); - gpio_free(gpio + 6); - gpio_free(gpio + 7); + gpio_free(gpio + DA850_SEL_C_OFFSET); + gpio_free(gpio + DA850_SEL_B_OFFSET); + gpio_free(gpio + DA850_SEL_A_OFFSET); return 0; } -- 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Ben Gardiner <bengardiner-ScDXFp4xN3PN+rMO2ozGnw@public.gmane.org> To: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>, davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexander Clouter <alex-L4GPcECwBoDe9xe1eoZjHA@public.gmane.org>, Chris Cordahi <christophercordahi-ScDXFp4xN3PN+rMO2ozGnw@public.gmane.org> Subject: [PATCH v2 3/4] da850-evm: extract defines for SEL{A, B, C} pins in UI expander Date: Tue, 16 Nov 2010 14:39:36 -0500 [thread overview] Message-ID: <aa85c5d83111add3a2ed3495ac13bffe5e6b885d.1289935504.git.bengardiner@nanometrics.ca> (raw) In-Reply-To: <cover.1289935504.git.bengardiner-ScDXFp4xN3PN+rMO2ozGnw@public.gmane.org> The setup and teardown methods of the UI expander reference the SEL_{A,B,C} pins by 'magic number' in each function. This patch extracts common #defines for their offsets in the expander and uses them. Signed-off-by: Ben Gardiner <bengardiner-ScDXFp4xN3PN+rMO2ozGnw@public.gmane.org> Reviewed-by: Chris Cordahi <christophercordahi-ScDXFp4xN3PN+rMO2ozGnw@public.gmane.org> --- No changes since v1 --- arch/arm/mach-davinci/board-da850-evm.c | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index ff71ffd..dcf21e5 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -292,6 +292,9 @@ static const char const *ui_expander_names[] = { "pb7", "pb6", "pb5", "pb4", "pb3", "pb2", "pb1" }; +#define DA850_SEL_A_OFFSET 7 +#define DA850_SEL_B_OFFSET 6 +#define DA850_SEL_C_OFFSET 5 #define DA850_UI_PB8_OFFSET 8 #define DA850_N_UI_PB 8 @@ -336,23 +339,23 @@ static int da850_evm_ui_expander_setup(struct i2c_client *client, unsigned gpio, { int sel_a, sel_b, sel_c, ret; - sel_a = gpio + 7; - sel_b = gpio + 6; - sel_c = gpio + 5; + sel_a = gpio + DA850_SEL_A_OFFSET; + sel_b = gpio + DA850_SEL_B_OFFSET; + sel_c = gpio + DA850_SEL_C_OFFSET; - ret = gpio_request(sel_a, "sel_a"); + ret = gpio_request(sel_a, ui_expander_names[DA850_SEL_A_OFFSET]); if (ret) { pr_warning("Cannot open UI expander pin %d\n", sel_a); goto exp_setup_sela_fail; } - ret = gpio_request(sel_b, "sel_b"); + ret = gpio_request(sel_b, ui_expander_names[DA850_SEL_B_OFFSET]); if (ret) { pr_warning("Cannot open UI expander pin %d\n", sel_b); goto exp_setup_selb_fail; } - ret = gpio_request(sel_c, "sel_c"); + ret = gpio_request(sel_c, ui_expander_names[DA850_SEL_C_OFFSET]); if (ret) { pr_warning("Cannot open UI expander pin %d\n", sel_c); goto exp_setup_selc_fail; @@ -396,13 +399,13 @@ static int da850_evm_ui_expander_teardown(struct i2c_client *client, platform_device_unregister(&user_ui_pb_gpio_key_device); /* deselect all functionalities */ - gpio_set_value(gpio + 5, 1); - gpio_set_value(gpio + 6, 1); - gpio_set_value(gpio + 7, 1); + gpio_set_value(gpio + DA850_SEL_C_OFFSET, 1); + gpio_set_value(gpio + DA850_SEL_B_OFFSET, 1); + gpio_set_value(gpio + DA850_SEL_A_OFFSET, 1); - gpio_free(gpio + 5); - gpio_free(gpio + 6); - gpio_free(gpio + 7); + gpio_free(gpio + DA850_SEL_C_OFFSET); + gpio_free(gpio + DA850_SEL_B_OFFSET); + gpio_free(gpio + DA850_SEL_A_OFFSET); return 0; } -- 1.7.0.4
next prev parent reply other threads:[~2010-11-16 19:46 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cover.1289835508.git.bengardiner@nanometrics.ca> [not found] ` <8891d088e9a16122c780f737b1b1ec35f9517c36.1289835508.git.bengardiner@nanometrics.ca> 2010-11-16 9:36 ` [PATCH 1/4] input: gpio_keys: polling mode support Paul Mundt 2010-11-16 18:28 ` Ben Gardiner 2010-11-16 19:39 ` [PATCH v2 0/4] da850-evm: add gpio-{keys,leds} for UI and BB expanders Ben Gardiner 2010-11-16 19:39 ` [PATCH v2 0/4] da850-evm: add gpio-{keys, leds} " Ben Gardiner 2010-11-16 19:39 ` [PATCH v2 1/4] input: gpio_keys: polling mode support Ben Gardiner 2010-11-16 19:39 ` [PATCH v2 2/4] da850-evm: add UI Expander pushbuttons Ben Gardiner 2010-11-19 9:58 ` Nori, Sekhar 2010-11-19 9:58 ` Nori, Sekhar 2010-11-19 15:38 ` Ben Gardiner 2010-11-19 15:38 ` Ben Gardiner 2010-11-22 11:49 ` Nori, Sekhar 2010-11-22 11:49 ` Nori, Sekhar 2010-11-22 13:50 ` Ben Gardiner 2010-11-22 13:50 ` Ben Gardiner 2010-11-23 12:38 ` Nori, Sekhar 2010-11-23 12:38 ` Nori, Sekhar 2010-11-23 13:29 ` Ben Gardiner 2010-11-23 13:29 ` Ben Gardiner 2010-11-23 15:48 ` Kevin Hilman 2010-11-23 15:48 ` Kevin Hilman 2010-11-23 17:58 ` Ben Gardiner 2010-11-23 17:58 ` Ben Gardiner 2010-11-24 6:09 ` Paul Mundt 2010-11-24 6:09 ` Paul Mundt 2010-11-24 17:17 ` Ben Gardiner 2010-11-24 17:17 ` Ben Gardiner 2010-11-16 19:39 ` Ben Gardiner [this message] 2010-11-16 19:39 ` [PATCH v2 3/4] da850-evm: extract defines for SEL{A, B, C} pins in UI expander Ben Gardiner 2010-11-19 11:19 ` Nori, Sekhar 2010-11-19 11:19 ` Nori, Sekhar 2010-11-19 15:38 ` Ben Gardiner 2010-11-19 15:38 ` Ben Gardiner 2010-11-16 19:39 ` [PATCH v2 4/4] da850-evm: add baseboard UI expander buttons, switches and LEDs Ben Gardiner 2010-11-19 12:14 ` Nori, Sekhar 2010-11-19 12:14 ` Nori, Sekhar 2010-11-19 15:40 ` Ben Gardiner 2010-11-19 15:40 ` Ben Gardiner 2010-11-19 17:02 ` Dmitry Torokhov 2010-11-19 17:02 ` Dmitry Torokhov 2010-11-19 17:15 ` Ben Gardiner 2010-11-19 17:15 ` Ben Gardiner 2010-11-22 12:00 ` Nori, Sekhar 2010-11-22 12:00 ` Nori, Sekhar 2010-11-22 14:15 ` Ben Gardiner 2010-11-22 14:15 ` Ben Gardiner 2010-11-23 12:42 ` Nori, Sekhar 2010-11-23 12:42 ` Nori, Sekhar 2010-11-23 13:32 ` Ben Gardiner 2010-11-23 13:32 ` Ben Gardiner 2010-11-19 21:37 ` [PATCH v3 0/4] da850-evm: add gpio-{keys,leds} for UI and BB expanders Ben Gardiner 2010-11-19 21:37 ` [PATCH v3 1/4] input: gpio_keys: polling mode support Ben Gardiner 2010-11-19 21:37 ` [PATCH v3 2/4] da850-evm: add UI Expander pushbuttons Ben Gardiner 2010-11-19 21:37 ` [PATCH v3 3/4] da850-evm: extract defines for SEL{A,B,C} pins in UI expander Ben Gardiner 2010-11-19 21:41 ` [PATCH v3 3/4] da850-evm: extract defines for SEL{A, B, C} " Victor Rodriguez 2010-11-19 21:41 ` Victor Rodriguez 2010-11-19 22:25 ` Ben Gardiner 2010-11-19 22:25 ` Ben Gardiner 2010-11-19 21:37 ` [PATCH v3 4/4] da850-evm: add baseboard GPIO expander buttons, switches and LEDs Ben Gardiner 2010-11-23 19:40 ` [PATCH v4 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders Ben Gardiner 2010-11-23 19:40 ` [PATCH v4 1/5] input: gpio_keys: polling mode support Ben Gardiner 2010-11-23 19:40 ` Ben Gardiner 2010-11-23 19:40 ` [PATCH v4 2/5] da850-evm: add UI Expander pushbuttons Ben Gardiner 2010-11-23 19:40 ` Ben Gardiner 2010-11-24 13:16 ` Nori, Sekhar 2010-11-24 13:16 ` Nori, Sekhar 2010-11-24 17:16 ` Ben Gardiner 2010-11-24 17:16 ` Ben Gardiner 2010-11-23 19:40 ` [PATCH v4 3/5] da850-evm: extract defines for SEL{A,B,C} pins in UI expander Ben Gardiner 2010-11-23 19:40 ` [PATCH v4 4/5] da850-evm: add baseboard GPIO expander buttons, switches and LEDs Ben Gardiner 2010-11-23 19:41 ` [PATCH v4 5/5] da850-evm: KEYBOARD_GPIO and INPUT_POLLDEV Kconfig conditionals Ben Gardiner 2010-11-23 19:41 ` Ben Gardiner 2010-11-24 21:59 ` [PATCH v5 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders Ben Gardiner 2010-11-24 21:59 ` [PATCH v5 1/5] [WIP] input: add input driver for polled GPIO buttons Ben Gardiner 2010-11-24 21:59 ` Ben Gardiner 2010-11-24 21:59 ` [PATCH v5 2/5] da850-evm: add UI Expander pushbuttons Ben Gardiner 2010-11-24 21:59 ` Ben Gardiner 2010-11-24 21:59 ` [PATCH v5 3/5] da850-evm: extract defines for SEL{A,B,C} pins in UI expander Ben Gardiner 2010-11-24 21:59 ` [PATCH v5 4/5] da850-evm: add baseboard GPIO expander buttons, switches and LEDs Ben Gardiner 2010-11-24 21:59 ` [PATCH v5 5/5] da850-evm: KEYBOARD_GPIO_POLLED Kconfig conditional Ben Gardiner 2010-11-24 21:59 ` Ben Gardiner 2010-12-09 21:51 ` [PATCH v6 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders Ben Gardiner 2010-12-09 21:51 ` [PATCH v6 1/5] Input: add input driver for polled GPIO buttons Ben Gardiner 2010-12-09 21:51 ` Ben Gardiner 2010-12-10 15:50 ` Kevin Hilman 2010-12-09 21:51 ` [PATCH v6 2/5] da850-evm: add UI Expander pushbuttons Ben Gardiner 2010-12-09 21:51 ` Ben Gardiner 2010-12-09 21:51 ` [PATCH v6 3/5] da850-evm: extract defines for SEL{A,B,C} pins in UI expander Ben Gardiner 2010-12-09 21:51 ` [PATCH v6 4/5] da850-evm: add baseboard GPIO expander buttons, switches and LEDs Ben Gardiner 2010-12-09 21:51 ` [PATCH v6 5/5] da850-evm: KEYBOARD_GPIO_POLLED Kconfig conditional Ben Gardiner 2010-12-09 21:51 ` Ben Gardiner 2010-12-10 16:16 ` [PATCH v6 0/5] da850-evm: add gpio-{keys,leds} for UI and BB expanders Kevin Hilman 2010-12-10 16:33 ` Ben Gardiner 2010-12-10 16:33 ` Ben Gardiner 2010-12-11 0:04 ` Kevin Hilman 2010-12-11 0:04 ` Kevin Hilman 2010-12-13 17:02 ` Ben Gardiner 2010-12-13 17:02 ` Ben Gardiner 2010-12-13 21:53 ` Kevin Hilman 2010-12-13 21:53 ` [PATCH v6 0/5] da850-evm: add gpio-{keys, leds} " Kevin Hilman 2010-12-14 4:31 ` [PATCH v6 0/5] da850-evm: add gpio-{keys,leds} " Ben Gardiner 2010-12-14 4:31 ` Ben Gardiner 2010-12-14 16:17 ` Ben Gardiner 2010-12-14 17:10 ` Kevin Hilman 2010-12-17 15:15 ` Ben Gardiner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=aa85c5d83111add3a2ed3495ac13bffe5e6b885d.1289935504.git.bengardiner@nanometrics.ca \ --to=bengardiner@nanometrics.ca \ --cc=alex@digriz.org.uk \ --cc=christophercordahi@nanometrics.ca \ --cc=davinci-linux-open-source@linux.davincidsp.com \ --cc=dmitry.torokhov@gmail.com \ --cc=khilman@deeprootsystems.com \ --cc=lethal@linux-sh.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.