All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mitali Borkar <mitaliborkar810@gmail.com>
To: clabbe@baylibre.com, mchehab@kernel.org, gregkh@linuxfoundation.org
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
	mitali_s@me.iitr.ac.in
Subject: [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro
Date: Fri, 9 Apr 2021 02:09:03 +0530	[thread overview]
Message-ID: <ac8ec2b70ac2cc7c541c05a1d9a8db1fe79df793.1617912177.git.mitaliborkar810@gmail.com> (raw)
In-Reply-To: <cover.1617912177.git.mitaliborkar810@gmail.com>

Added #include <linux/bitops.h> and replaced bit shifts by BIT() macro.
This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* bitmasks.
Use of macro is better and neater. It maintains consistency.
Reported by checkpatch.

Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
 drivers/staging/media/zoran/zr36057.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/zoran/zr36057.h b/drivers/staging/media/zoran/zr36057.h
index a2a75fd9f535..93075459f910 100644
--- a/drivers/staging/media/zoran/zr36057.h
+++ b/drivers/staging/media/zoran/zr36057.h
@@ -8,6 +8,8 @@
 #ifndef _ZR36057_H_
 #define _ZR36057_H_
 
+#include <linux/bitops.h>
+
 /* Zoran ZR36057 registers */
 
 #define ZR36057_VFEHCR          0x000	/* Video Front End, Horizontal Configuration Register */
@@ -31,12 +33,12 @@
 #define ZR36057_VFESPFR_VER_DCM          8
 #define ZR36057_VFESPFR_DISP_MODE        6
 #define ZR36057_VFESPFR_YUV422          (0 << 3)
-#define ZR36057_VFESPFR_RGB888          (1 << 3)
+#define ZR36057_VFESPFR_RGB888          BIT(3)
 #define ZR36057_VFESPFR_RGB565          (2 << 3)
 #define ZR36057_VFESPFR_RGB555          (3 << 3)
-#define ZR36057_VFESPFR_ERR_DIF          (1 << 2)
-#define ZR36057_VFESPFR_PACK24          (1 << 1)
-#define ZR36057_VFESPFR_LITTLE_ENDIAN    (1 << 0)
+#define ZR36057_VFESPFR_ERR_DIF          BIT(2)
+#define ZR36057_VFESPFR_PACK24          BIT(1)
+#define ZR36057_VFESPFR_LITTLE_ENDIAN    BIT(0)
 
 #define ZR36057_VDTR            0x00c	/* Video Display "Top" Register */
 
-- 
2.30.2


  parent reply	other threads:[~2021-04-08 20:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 20:38 [PATCH 0/2] media: zoran: clean up style issues Mitali Borkar
2021-04-08 20:38 ` [PATCH 1/2] media: zoran: add spaces around '<<' Mitali Borkar
2021-04-08 21:16   ` [Outreachy kernel] " Julia Lawall
2021-04-08 21:16     ` Julia Lawall
2021-04-08 21:34     ` Mitali Borkar
2021-04-09  7:23   ` Hans Verkuil
2021-04-09 15:11     ` Mitali Borkar
2021-04-09 15:29       ` [Outreachy kernel] " Julia Lawall
2021-04-09 15:29         ` Julia Lawall
2021-04-09 15:48       ` Hans Verkuil
2021-04-09 16:49     ` Mitali Borkar
2021-04-09 17:26       ` [Outreachy kernel] " Julia Lawall
2021-04-09 17:26         ` Julia Lawall
2021-04-08 20:39 ` Mitali Borkar [this message]
2021-04-08 21:15   ` [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro Julia Lawall
2021-04-08 21:15     ` Julia Lawall
2021-04-08 21:45     ` Mitali Borkar
2021-04-08 22:10       ` Julia Lawall
2021-04-08 22:10         ` Julia Lawall
2021-04-08 23:15         ` Mitali Borkar
2021-04-09  7:00           ` Julia Lawall
2021-04-09  7:00             ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac8ec2b70ac2cc7c541c05a1d9a8db1fe79df793.1617912177.git.mitaliborkar810@gmail.com \
    --to=mitaliborkar810@gmail.com \
    --cc=clabbe@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=mitali_s@me.iitr.ac.in \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.