All of lore.kernel.org
 help / color / mirror / Atom feed
From: Souptick Joarder <jrdr.linux@gmail.com>
To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com,
	boris.ostrovsky@oracle.com, jgross@suse.com,
	linux@armlinux.org.uk, robin.murphy@arm.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RESEND PATCH v4 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero()
Date: Tue, 19 Mar 2019 08:00:51 +0530	[thread overview]
Message-ID: <acf678e81d554d01a9b590716ac0ccbdcdf71c25.1552921225.git.jrdr.linux@gmail.com> (raw)
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>

Convert to use vm_map_pages_zero() to map range of kernel
memory to user vma.

This driver has ignored vm_pgoff. We could later "fix" these drivers
to behave according to the normal vm_pgoff offsetting simply by
removing the _zero suffix on the function name and if that causes
regressions, it gives us an easy way to revert.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 drivers/xen/privcmd-buf.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c
index de01a6d..d02dc43 100644
--- a/drivers/xen/privcmd-buf.c
+++ b/drivers/xen/privcmd-buf.c
@@ -166,12 +166,8 @@ static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma)
 	if (vma_priv->n_pages != count)
 		ret = -ENOMEM;
 	else
-		for (i = 0; i < vma_priv->n_pages; i++) {
-			ret = vm_insert_page(vma, vma->vm_start + i * PAGE_SIZE,
-					     vma_priv->pages[i]);
-			if (ret)
-				break;
-		}
+		ret = vm_map_pages_zero(vma, vma_priv->pages,
+						vma_priv->n_pages);
 
 	if (ret)
 		privcmd_buf_vmapriv_free(vma_priv);
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com>
To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com,
	kirill.shutemov@linux.intel.com, vbabka@suse.cz,
	riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com,
	peterz@infradead.org, linux@armlinux.org.uk,
	robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com,
	keescook@chromium.org, m.szyprowski@samsung.com,
	stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de,
	airlied@linux.ie, oleksandr_andrushchenko@epam.com,
	joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com,
	mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-arm-kernel@lists.infradead.org,
	linux1394-devel@lists.sourceforge.net,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org,
	iommu@lists.linux-foundation.org, linux-media@vger.kernel.org,
	Souptick Joarder <jrdr.linux@gmail.com>
Subject: [REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero()
Date: Tue, 16 Apr 2019 17:19:50 +0530	[thread overview]
Message-ID: <acf678e81d554d01a9b590716ac0ccbdcdf71c25.1552921225.git.jrdr.linux@gmail.com> (raw)
Message-ID: <20190416114950.gVSZZKh8NOY13wFCg-fm0gWWyU4S90gsZNsWDygvxUA@z> (raw)
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>

Convert to use vm_map_pages_zero() to map range of kernel
memory to user vma.

This driver has ignored vm_pgoff. We could later "fix" these drivers
to behave according to the normal vm_pgoff offsetting simply by
removing the _zero suffix on the function name and if that causes
regressions, it gives us an easy way to revert.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 drivers/xen/privcmd-buf.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c
index de01a6d..d02dc43 100644
--- a/drivers/xen/privcmd-buf.c
+++ b/drivers/xen/privcmd-buf.c
@@ -166,12 +166,8 @@ static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma)
 	if (vma_priv->n_pages != count)
 		ret = -ENOMEM;
 	else
-		for (i = 0; i < vma_priv->n_pages; i++) {
-			ret = vm_insert_page(vma, vma->vm_start + i * PAGE_SIZE,
-					     vma_priv->pages[i]);
-			if (ret)
-				break;
-		}
+		ret = vm_map_pages_zero(vma, vma_priv->pages,
+						vma_priv->n_pages);
 
 	if (ret)
 		privcmd_buf_vmapriv_free(vma_priv);
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com>
To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com,
	kirill.shutemov@linux.intel.com, vbabka@suse.cz,
	riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com,
	peterz@infradead.org, linux@armlinux.org.uk,
	robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com,
	keescook@chromium.org, m.szyprowski@samsung.com,
	stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de,
	airlied@linux.ie, oleksandr_andrushchenko@epam.com,
	joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com,
	mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org,
	linux-mm@kvack.org, iommu@lists.linux-foundation.org,
	Souptick Joarder <jrdr.linux@gmail.com>,
	linux1394-devel@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: [REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero()
Date: Tue, 16 Apr 2019 17:19:50 +0530	[thread overview]
Message-ID: <acf678e81d554d01a9b590716ac0ccbdcdf71c25.1552921225.git.jrdr.linux@gmail.com> (raw)
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>

Convert to use vm_map_pages_zero() to map range of kernel
memory to user vma.

This driver has ignored vm_pgoff. We could later "fix" these drivers
to behave according to the normal vm_pgoff offsetting simply by
removing the _zero suffix on the function name and if that causes
regressions, it gives us an easy way to revert.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 drivers/xen/privcmd-buf.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c
index de01a6d..d02dc43 100644
--- a/drivers/xen/privcmd-buf.c
+++ b/drivers/xen/privcmd-buf.c
@@ -166,12 +166,8 @@ static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma)
 	if (vma_priv->n_pages != count)
 		ret = -ENOMEM;
 	else
-		for (i = 0; i < vma_priv->n_pages; i++) {
-			ret = vm_insert_page(vma, vma->vm_start + i * PAGE_SIZE,
-					     vma_priv->pages[i]);
-			if (ret)
-				break;
-		}
+		ret = vm_map_pages_zero(vma, vma_priv->pages,
+						vma_priv->n_pages);
 
 	if (ret)
 		privcmd_buf_vmapriv_free(vma_priv);
-- 
1.9.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com>
To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com,
	kirill.shutemov@linux.intel.com, vbabka@suse.cz,
	riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com,
	peterz@infradead.org, linux@armlinux.org.uk,
	robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com,
	keescook@chromium.org, m.szyprowski@samsung.com,
	stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de,
	airlied@linux.ie, oleksandr_andrushchenko@epam.com,
	joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com,
	mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org,
	linux-mm@kvack.org, iommu@lists.linux-foundation.org,
	Souptick Joarder <jrdr.linux@gmail.com>,
	linux1394-devel@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: [REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero()
Date: Tue, 16 Apr 2019 17:19:50 +0530	[thread overview]
Message-ID: <acf678e81d554d01a9b590716ac0ccbdcdf71c25.1552921225.git.jrdr.linux@gmail.com> (raw)
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>
In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com>

Convert to use vm_map_pages_zero() to map range of kernel
memory to user vma.

This driver has ignored vm_pgoff. We could later "fix" these drivers
to behave according to the normal vm_pgoff offsetting simply by
removing the _zero suffix on the function name and if that causes
regressions, it gives us an easy way to revert.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 drivers/xen/privcmd-buf.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c
index de01a6d..d02dc43 100644
--- a/drivers/xen/privcmd-buf.c
+++ b/drivers/xen/privcmd-buf.c
@@ -166,12 +166,8 @@ static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma)
 	if (vma_priv->n_pages != count)
 		ret = -ENOMEM;
 	else
-		for (i = 0; i < vma_priv->n_pages; i++) {
-			ret = vm_insert_page(vma, vma->vm_start + i * PAGE_SIZE,
-					     vma_priv->pages[i]);
-			if (ret)
-				break;
-		}
+		ret = vm_map_pages_zero(vma, vma_priv->pages,
+						vma_priv->n_pages);
 
 	if (ret)
 		privcmd_buf_vmapriv_free(vma_priv);
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-03-19  2:26 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19  2:22 [RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-03-19  2:22 ` [RESEND PATCH v4 " Souptick Joarder
2019-03-19  2:23 ` [RESEND PATCH v4 1/9] mm: Introduce new " Souptick Joarder
2019-03-19  2:23 ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:23   ` [RESEND PATCH v4 " Souptick Joarder
2019-03-19  2:24 ` [RESEND PATCH v4 2/9] arm: mm: dma-mapping: Convert to use vm_map_pages() Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:24   ` [RESEND PATCH v4 " Souptick Joarder
2019-03-19  2:25 ` [RESEND PATCH v4 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:25   ` [RESEND PATCH v4 " Souptick Joarder
2019-03-19  2:26 ` [RESEND PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages() Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:26   ` [RESEND PATCH v4 " Souptick Joarder
2019-03-19  2:27 ` [RESEND PATCH v4 5/9] drm/xen/xen_drm_front_gem.c: " Souptick Joarder
2019-03-19  2:27 ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:28 ` [RESEND PATCH v4 6/9] iommu/dma-iommu.c: " Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:29 ` [RESEND PATCH v4 7/9] videobuf2/videobuf2-dma-sg.c: " Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:30 ` [RESEND PATCH v4 8/9] xen/gntdev.c: " Souptick Joarder
2019-03-19  2:30 ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:30 ` Souptick Joarder [this message]
2019-04-16 11:49   ` [REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-03-19  2:30 ` [RESEND PATCH v4 " Souptick Joarder
2019-04-01  5:26 ` [RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API Souptick Joarder
2019-04-01  5:26   ` Souptick Joarder
2019-04-01  5:26   ` Souptick Joarder
2019-04-01  5:26   ` Souptick Joarder
2019-04-09  6:17   ` Souptick Joarder
2019-04-09  6:17   ` Souptick Joarder
2019-04-09  6:17     ` Souptick Joarder
2019-04-09  6:17     ` Souptick Joarder
2019-04-09  6:17     ` Souptick Joarder
2019-04-09  6:17     ` Souptick Joarder
2019-04-01  5:26 ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 1/9] mm: Introduce new " Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 2/9] arm: mm: dma-mapping: Convert to use vm_map_pages() Souptick Joarder
     [not found] ` <cover.1552921225.git.jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages() Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 5/9] drm/xen/xen_drm_front_gem.c: " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 6/9] iommu/dma-iommu.c: " Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 7/9] videobuf2/videobuf2-dma-sg.c: " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 8/9] xen/gntdev.c: " Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49   ` [REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-04-16 11:49   ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 2/9] arm: mm: dma-mapping: Convert to use vm_map_pages() Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages() Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 5/9] drm/xen/xen_drm_front_gem.c: " Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 6/9] iommu/dma-iommu.c: " Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 7/9] videobuf2/videobuf2-dma-sg.c: " Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 8/9] xen/gntdev.c: " Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` [REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero() Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder
2019-04-16 11:49 ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acf678e81d554d01a9b590716ac0ccbdcdf71c25.1552921225.git.jrdr.linux@gmail.com \
    --to=jrdr.linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=mhocko@suse.com \
    --cc=robin.murphy@arm.com \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.